From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
Laine Jaakko EXT <ext-jaakko.laine@vaisala.com>
Subject: Re: [PATCH] i2c: add 'single-master' property to generic bindings
Date: Sat, 30 May 2020 01:02:52 +0200 [thread overview]
Message-ID: <20200529230252.GA4798@kunai> (raw)
In-Reply-To: <20200529220228.GA3052199@bogus>
[-- Attachment #1: Type: text/plain, Size: 790 bytes --]
Hi Rob,
thanks for the review!
> Could you just have different timeouts for clearing stalled bus. You
> know quickly if 'single-master' is set, but have to wait longer if not?
Timeouts are a difficult topic with I2C; there is no timeout defined.
However, if you want to start communictaing and don't have a 'bus idle'
condition, then the new property makes a difference. With
"single-master", we know the bus is stalled. With "multi-master" it
could be another master communicating.
> Note that we need to add a bunch of these properties to dt-schema
> i2c-controller.yaml. I hadn't done that because I want to dual license
> in the process, but lots of folks have touched i2c.txt IIRC.
What is your motivation for dual licensing?
All the best,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-05-29 23:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 11:30 [PATCH] i2c: add 'single-master' property to generic bindings Wolfram Sang
2020-05-29 22:02 ` Rob Herring
2020-05-29 23:02 ` Wolfram Sang [this message]
2020-06-03 13:58 ` Rob Herring
2020-05-30 21:13 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529230252.GA4798@kunai \
--to=wsa+renesas@sang-engineering.com \
--cc=devicetree@vger.kernel.org \
--cc=ext-jaakko.laine@vaisala.com \
--cc=linux-i2c@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).