devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiaxun Yang <jiaxun.yang@flygoat.com>
To: robh@kernel.org
Cc: apw@canonical.com, joe@perches.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: checkpatch warnings with PCI DT compatible string
Date: Sat, 30 May 2020 15:17:52 +0800	[thread overview]
Message-ID: <20200530151752.2f40fb08@halation.net.flygoat.com> (raw)

Hi there,

When I was trying to create dts for my platform that need PCI
DeviceTree sub node to express interrupt of children devices under the
bridge, like this:

pci@1a000000 {
    compatible = "loongson,ls7a-pci";
    device_type = "pci";
    #address-cells = <3>;
    #size-cells = <2>;
    #interrupt-cells = <2>;
    msi-parent = <&msi>;

    reg = <0 0x1a000000 0 0x02000000>,
        <0xefe 0x00000000 0 0x20000000>;

    ranges = <0x01000000 0x0 0x00020000 0x0 0x00020000 0x0 0x00020000>,
            <0x02000000 0x0 0x40000000 0x0 0x40000000 0x0 0x40000000>;

    ohci@4,0 {
        compatible = "pci0014,7a24.0",
                    "pci0014,7a24",
                    "pciclass0c0310",
                    "pciclass0c03";

        reg = <0x2000 0x0 0x0 0x0 0x0>;
        interrupts = <49 IRQ_TYPE_LEVEL_HIGH>;
        interrupt-parent = <&pic>;
    };
};

I got such checkpatch warnings:

WARNING: DT compatible string "pci0014,7a24.0" appears un-documented --
check ./Documentation/devicetree/bindings/ #206: FILE:
arch/mips/boot/dts/loongson/ls7a-pch.dtsi:38:
+                               compatible = "pci0014,7a24.0",

WARNING: DT compatible string vendor "pci0014" appears un-documented --
check ./Documentation/devicetree/bindings/vendor-prefixes.yaml #206:
FILE: arch/mips/boot/dts/loongson/ls7a-pch.dtsi:38:
+                               compatible = "pci0014,7a24.0",

Just wonder if using such compatible string is allowed?

I've saw some some usages like mine in the tree, such as
arch/x86/platform/ce4100/falconfalls.dts, and
arch/mips/boot/dts/img/boston.dts.

If that's allowed, should we surpress these warnings in checkpatch
script?

Thanks.

--
Jiaxun Yang 

                 reply	other threads:[~2020-05-30  7:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200530151752.2f40fb08@halation.net.flygoat.com \
    --to=jiaxun.yang@flygoat.com \
    --cc=apw@canonical.com \
    --cc=devicetree@vger.kernel.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).