From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B622C433E4 for ; Mon, 1 Jun 2020 21:43:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B1AE206E2 for ; Mon, 1 Jun 2020 21:43:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591047787; bh=uLa7Si1QGqmdKzqCdgycL5Os6wjAozKeff/H2hDefyE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=V9OXzfYlzmIPF0spm7ADkwZKwY2wgV2qVrCqTZxhXdOmfbxkM1TXZgrCF9X/0w/LH S0TIp0R0pbSB1Bfs+lDGe6cSE2IpmwEkWOqUsxEnUK9SWn2gS+qU/hODKDdORmdgXr Ve5+sqteg3txrOfStiOToixM0ahhgQpSEP8Y9Nh4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728818AbgFAVnG (ORCPT ); Mon, 1 Jun 2020 17:43:06 -0400 Received: from mail-il1-f193.google.com ([209.85.166.193]:38459 "EHLO mail-il1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728846AbgFAVnF (ORCPT ); Mon, 1 Jun 2020 17:43:05 -0400 Received: by mail-il1-f193.google.com with SMTP id b5so4720446iln.5; Mon, 01 Jun 2020 14:43:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=h6bmu3CJcmV/9le9YJQNFFMA2nIiHEqBi68n/JP+HZg=; b=GIBpUgXLGNQtvFt1EWaoJF3RlvYpSbbvRcJ0vLAJkJ9CWrSptqT1gHLtcB0/6T0k0v reao62fnjV0XRf5TCK4DpU+XtH7ep1fKtL0A/DbGVMgeKnlbEWjmEMwjmhzphAWRqmXO Oop1FBDbk4TACltLAzmMSOqbUlw3475yR7dQ6bFIEM0q5nu2bRLWgOa60dIT4gG6yjyR etKx1r4fmvInn7F/8YXDofYZIWHPzYi66JD50XyHm/a9/sehxaYlrgkue4vOFo900r8T S9u9rTBYj6IVRZDdm2eW/HrkyT4ES3PrqDA+0ZEEQ1AOrdpt4fi3LqZVRdtkf2UFBrxW zC3g== X-Gm-Message-State: AOAM533467UdltmP5nTId3MNKEV26T91g75gVlFZScGmlxOmEQz7JJC1 aw4zBLAsTa4hFB+02hOumw== X-Google-Smtp-Source: ABdhPJyjdTs1k1AJmK5ghDCtRiwra/ZwCyc7YXPiOjDJbc7itj5xSqUIw+cqQ9LzQTmIn5vJwpBTSQ== X-Received: by 2002:a05:6e02:e53:: with SMTP id l19mr5346647ilk.96.1591047783964; Mon, 01 Jun 2020 14:43:03 -0700 (PDT) Received: from xps15 ([64.188.179.251]) by smtp.gmail.com with ESMTPSA id g4sm387323ilj.45.2020.06.01.14.43.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2020 14:43:03 -0700 (PDT) Received: (nullmailer pid 1554558 invoked by uid 1000); Mon, 01 Jun 2020 21:43:02 -0000 Date: Mon, 1 Jun 2020 15:43:02 -0600 From: Rob Herring To: Kunihiko Hayashi Cc: Bjorn Helgaas , Lorenzo Pieralisi , Jingoo Han , Gustavo Pimentel , Masahiro Yamada , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Masami Hiramatsu , Jassi Brar Subject: Re: [PATCH v2 5/5] PCI: uniphier: Add error message when failed to get phy Message-ID: <20200601214302.GA1538223@bogus> References: <1589536743-6684-1-git-send-email-hayashi.kunihiko@socionext.com> <1589536743-6684-6-git-send-email-hayashi.kunihiko@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1589536743-6684-6-git-send-email-hayashi.kunihiko@socionext.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, May 15, 2020 at 06:59:03PM +0900, Kunihiko Hayashi wrote: > Even if phy driver doesn't probe, the error message can't be distinguished > from other errors. This displays error message caused by the phy driver > explicitly. > > Signed-off-by: Kunihiko Hayashi > --- > drivers/pci/controller/dwc/pcie-uniphier.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-uniphier.c b/drivers/pci/controller/dwc/pcie-uniphier.c > index 493f105..7ae9688 100644 > --- a/drivers/pci/controller/dwc/pcie-uniphier.c > +++ b/drivers/pci/controller/dwc/pcie-uniphier.c > @@ -468,8 +468,11 @@ static int uniphier_pcie_probe(struct platform_device *pdev) > return PTR_ERR(priv->rst); > > priv->phy = devm_phy_optional_get(dev, "pcie-phy"); > - if (IS_ERR(priv->phy)) > - return PTR_ERR(priv->phy); > + if (IS_ERR(priv->phy)) { > + ret = PTR_ERR(priv->phy); > + dev_err(dev, "Failed to get phy (%d)\n", ret); This will print an error on EPROBE_DEFERRED which isn't an error. > + return ret; > + } > > platform_set_drvdata(pdev, priv); > > -- > 2.7.4 >