From: Wolfram Sang <wsa@the-dreams.de>
To: Tali Perry <tali.perry1@gmail.com>
Cc: ofery@google.com, brendanhiggins@google.com,
avifishman70@gmail.com, tmaimon77@gmail.com, kfting@nuvoton.com,
venture@google.com, yuenn@google.com, benjaminfair@google.com,
robh+dt@kernel.org, andriy.shevchenko@linux.intel.com,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
openbmc@lists.ozlabs.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH v14 0/3] i2c: npcm7xx: add NPCM i2c controller driver
Date: Wed, 3 Jun 2020 22:25:53 +0200 [thread overview]
Message-ID: <20200603202553.GB7684@kunai> (raw)
In-Reply-To: <20200527200820.47359-1-tali.perry1@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 876 bytes --]
On Wed, May 27, 2020 at 11:08:17PM +0300, Tali Perry wrote:
> This patch set adds i2c controller support
> for the Nuvoton NPCM Baseboard Management Controller (BMC).
>
> NPCM7xx includes 16 I2C controllers. This driver operates the controller.
> This module also includes a slave mode.
>
> ---
> v14 -> v13:
> - Fix yaml example: add missing include.
> - Replace all udelay to usleep_range, except one which is called from
> irq.
> - Fix compilation error (module_platfrom_init conflict).
> - debugfs counters always updated. Counting till max value,
> then stop counting.
> - Rename bus-frequency to clock-frequency.
> - Remove unused variables.
I don't have time for a deeper review, but from what I can tell this
driver is good to go and we can fix things incrementally from now on.
Applied to for-next (will go into 5.8), thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-06-03 20:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 20:08 [PATCH v14 0/3] i2c: npcm7xx: add NPCM i2c controller driver Tali Perry
2020-05-27 20:08 ` [PATCH v14 1/3] dt-bindings: i2c: npcm7xx: add NPCM I2C controller Tali Perry
2020-05-29 19:07 ` Rob Herring
2020-05-27 20:08 ` [PATCH v14 2/3] i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver Tali Perry
2020-05-27 20:08 ` [PATCH v14 3/3] i2c: npcm7xx: Add support for slave mode for Nuvoton Tali Perry
2020-06-03 20:25 ` Wolfram Sang [this message]
2020-06-04 8:32 ` [PATCH v14 0/3] i2c: npcm7xx: add NPCM i2c controller driver Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200603202553.GB7684@kunai \
--to=wsa@the-dreams.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=brendanhiggins@google.com \
--cc=devicetree@vger.kernel.org \
--cc=kfting@nuvoton.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=ofery@google.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).