Re: [PATCH 3/3] drm/bridge: Introduce LT9611 DSI to HDMI bridge

Vinod Koul
2020-06-04T07:25:57Z

Hi Laurent,

On 28-05-20, 04:52, Laurent Pinchart wrote:

> > +static int lt9611_bridge_attach(struct drm_bridge *bridge,
> > + enum drm_bridge_attach_flags flags)
> > +{
> > + struct lt9611 *lt9611 = bridge_to_lt9611(bridge);
> > + int ret;
> > +
> > + dev_dbg(lt9611->dev, "bridge attach\n");
>
>
> Connector creation in bridge drivers is deprecated. Please at least add

Okay what is the right way for connector creation? I can add support for
that.

> support for the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag, to make connector
> creation optional. Ideally the !DRM_BRIDGE_ATTACH_NO_CONNECTOR case

will add that

> should not be implemented at all. This will require the display
> controller driver to use DRM_BRIDGE_ATTACH_NO_CONNECTOR. Which display
> controller(s) do you use this driver with ?

I am using with msm display driver, this was tested on dragon-board
db845c board.

Thanks
--
~Vinod