From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11CA4C433E1 for ; Thu, 4 Jun 2020 12:23:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6F77207D0 for ; Thu, 4 Jun 2020 12:23:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tpPWgXum" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728076AbgFDMXI (ORCPT ); Thu, 4 Jun 2020 08:23:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728024AbgFDMXH (ORCPT ); Thu, 4 Jun 2020 08:23:07 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93FF0C08C5C2 for ; Thu, 4 Jun 2020 05:23:07 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id t16so2120857plo.7 for ; Thu, 04 Jun 2020 05:23:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Ml/b7XpbKedJnePc4NDty+yg3XSrTj9avgZ4/HGZobY=; b=tpPWgXumYdkZBL23t2pEn4peGPpQJA+Ba5cmfNySNoOUzp6qoLiGbPhrG07r3frJio h0FjXzji74sSaWB/ykKys33C4EUHjuiFZJztd/aXDlA7zi4tW7qpAKWE5v4qvCxqDjO7 vAlJpl06ng5lq6owsElcfhUV7CTcKLHKrtFtT7hC05VTOuZSggbYfHnama6iuGj7pHYU VGyU5ErjYmVhdJYIRFQxC6a8peojHoUeIHE1JjNMrWgWRd/ZZ66FpWuw6QxueV4F0gNl Ejg83+V+oxhqVE+o6WbGHMGPHrUGq2wllWdRudauzQl3vExi38hSgHUW4bff11GO0Ha4 U40A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ml/b7XpbKedJnePc4NDty+yg3XSrTj9avgZ4/HGZobY=; b=o1tjXi0bjeYYaakgmOejoSoOa7otNx5fxQpCSjrKRKdtH+VsoD3WIlp7G6iwgbNl53 s1r0wMqZW30ND+5ml0QBVTmFE6WPLvh/HNxn4k37tpoUEYNLPEBQdtJ3AWZ1JwinTsMh tn27ut+khmAswIecgEXXK+IbIDhr20x9YZg5cnLGuWiZvs2+j551ognv4TZrqzdg2J2R 6YuumPenW3V1xDezkdo8n0aIQ4GmUMfscKgiWbnR7HJcTDCQ5biJhbA2G5wNz8do7cLj zZ1DqwGg9fDp1U84TXcu9ctIAIofrntvZrDxQwMW4SpK7dlHHlWO6wEZ+g2K71TQVqyo p7Bg== X-Gm-Message-State: AOAM532kYC7a8HXLIMZvYsUN0V2zjx2nAsNhlR1UT/bMX5cUwnPZeVOh fMh/i/Aht7q/xnxhGL4P98Du X-Google-Smtp-Source: ABdhPJyKuPxRf/nzrmTHyIaFY68aLoPdFMOUf07lj8gr4/OfPFX7xJELI5xk2of3Spc24oaT+u0sWw== X-Received: by 2002:a17:902:7c81:: with SMTP id y1mr4784792pll.236.1591273386735; Thu, 04 Jun 2020 05:23:06 -0700 (PDT) Received: from Mani-XPS-13-9360 ([2409:4072:6e19:fffb:c404:4d38:8396:d1ee]) by smtp.gmail.com with ESMTPSA id 67sm4640821pfg.84.2020.06.04.05.23.01 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Jun 2020 05:23:05 -0700 (PDT) Date: Thu, 4 Jun 2020 17:52:59 +0530 From: Manivannan Sadhasivam To: Sai Prakash Ranjan Cc: Bjorn Andersson , Dmitry Baryshkov , Andy Gross , Rob Herring , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, patches@linaro.org, linaro-kernel@lists.linaro.org, devicetree-owner@vger.kernel.org Subject: Re: [PATCH 7/7] arm64: dts: qcom: sm8250: add watchdog device Message-ID: <20200604122259.GG16719@Mani-XPS-13-9360> References: <20200604004331.669936-1-dmitry.baryshkov@linaro.org> <20200604004331.669936-7-dmitry.baryshkov@linaro.org> <1a23cf8a6386e8b78c52199bdcde9b5e@codeaurora.org> <20200604113544.GF16719@Mani-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jun 04, 2020 at 05:21:46PM +0530, Sai Prakash Ranjan wrote: > On 2020-06-04 17:05, Manivannan Sadhasivam wrote: > > On Thu, Jun 04, 2020 at 04:37:01PM +0530, Sai Prakash Ranjan wrote: > > > On 2020-06-04 06:13, Dmitry Baryshkov wrote: > > > > Add on-SoC watchdog device node. > > > > > > > > Signed-off-by: Dmitry Baryshkov > > > > --- > > > > arch/arm64/boot/dts/qcom/sm8250.dtsi | 6 ++++++ > > > > 1 file changed, 6 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi > > > > b/arch/arm64/boot/dts/qcom/sm8250.dtsi > > > > index 972d8e04c8a2..f1641c6fe203 100644 > > > > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > > > > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > > > > @@ -1662,6 +1662,12 @@ config { > > > > }; > > > > }; > > > > > > > > + watchdog@17c10000 { > > > > + compatible = "qcom,apss-wdt-sm8250", "qcom,kpss-wdt"; > > > > > > Need to add this compatible to bindings. > > > > > > > I did look into this but the binding says, > > "compatible : shall contain only one of the following" > > > > So clearly the fallback is not going to work and there is no need to add > > a > > dedicated compatible in the driver. The binding is not in the YAML > > format to > > be validated but still... Other option is to convert the binding to YAML > > and > > make the compatibles listed as 'enum' and 'const' elements > > appropriately. > > > > I already converted the bindings to YAML and added the missing compatibles > for > other SoCs[1] . Ah, okay. I didn't find it in linux-next. Anyway, for adding "qcom,apss-wdt-sm8250" compatible, we need to group the compatibles wisely using 'enum' and 'const'. > I thought it was already merged since Rob has already > reviewed > them, but seems like it was missed. Bjorn, can you please take it? > Perhaps for v5.9... Thanks, Mani > [1] https://lore.kernel.org/patchwork/cover/1192757/ > > Thanks, > Sai > > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation