From: Sudeep Holla <sudeep.holla@arm.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Liviu Dudau <liviu.dudau@arm.com>, Rob Herring <robh@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
devicetree@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
Sudeep Holla <sudeep.holla@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: dts: vexpress: Move mcc node back into motherboard node
Date: Thu, 4 Jun 2020 14:13:04 +0100 [thread overview]
Message-ID: <20200604131304.GC12397@bogus> (raw)
In-Reply-To: <159126075826.16785.4183160239670270692.b4-ty@arm.com>
On Thu, Jun 04, 2020 at 09:56:31AM +0100, Sudeep Holla wrote:
> On Wed, 3 Jun 2020 17:22:37 +0100, Andre Przywara wrote:
> > Commit d9258898ad49 ("arm64: dts: arm: vexpress: Move fixed devices
> > out of bus node") moved the "mcc" DT node into the root node, because
> > it does not have any children using "reg" properties, so does violate
> > some dtc checks about "simple-bus" nodes.
> > However this broke the vexpress config-bus code, which walks up the
> > device tree to find the first node with an "arm,vexpress,site" property.
> > This gave the wrong result (matching the root node instead of the
> > motherboard node), so broke the clocks and some other devices for
> > VExpress boards.
> >
> > [...]
>
> Applied to sudeep.holla/linux (for-next/juno), thanks!
>
> [1/1] arm: dts: vexpress: Move mcc node back into motherboard node
> https://git.kernel.org/sudeep.holla/c/8a8cd9a910
Had to fix the 'Fixes' tag based on the report from linux-next, so updated to:
https://git.kernel.org/sudeep.holla/c/38ac46002d1d
--
Regards,
Sudeep
next prev parent reply other threads:[~2020-06-04 13:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 16:22 [PATCH] arm: dts: vexpress: Move mcc node back into motherboard node Andre Przywara
2020-06-04 8:56 ` Sudeep Holla
2020-06-04 13:13 ` Sudeep Holla [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-06-03 19:46 Guenter Roeck
2020-06-04 8:59 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604131304.GC12397@bogus \
--to=sudeep.holla@arm.com \
--cc=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).