From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 904B7C433E0 for ; Thu, 4 Jun 2020 22:02:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C0232067B for ; Thu, 4 Jun 2020 22:02:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="GU9WUQKz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726319AbgFDWCY (ORCPT ); Thu, 4 Jun 2020 18:02:24 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:26968 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726062AbgFDWCY (ORCPT ); Thu, 4 Jun 2020 18:02:24 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1591308144; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=U+qcEcDFlcO/1JNEMt/uEx7bgKnkpDhfMTVm6faeMKk=; b=GU9WUQKzOkaa4cnrY98wSD4bByHgCSB2JVsZQ6F+UwtbucxrkcUmmuKERkgZqBnotcYU4dPE yD5tT2gbJTI/vnv6Q9iG/MfRgmbPOtWuTMle57m4TNAOdhQjVg/WmdKAA7zGMkHCNvOvLsxp jzcrWkXpCHmGH6To0N9uJX6F9mo= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n13.prod.us-east-1.postgun.com with SMTP id 5ed96f6f2738686126a1b798 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 04 Jun 2020 22:02:23 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id A9536C433CA; Thu, 4 Jun 2020 22:02:22 +0000 (UTC) Received: from jcrouse1-lnx.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jcrouse) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0E654C433C6; Thu, 4 Jun 2020 22:02:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0E654C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=jcrouse@codeaurora.org Date: Thu, 4 Jun 2020 16:02:16 -0600 From: Jordan Crouse To: Rob Clark Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm , Linux Kernel Mailing List , Rob Herring , Bjorn Andersson , Andy Gross , freedreno Subject: Re: [Freedreno] [PATCH v7 6/6] arm6: dts: qcom: sm845: Set the compatible string for the GPU SMMU Message-ID: <20200604220216.GA12322@jcrouse1-lnx.qualcomm.com> Mail-Followup-To: Rob Clark , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm , Linux Kernel Mailing List , Rob Herring , Bjorn Andersson , Andy Gross , freedreno References: <20200604205710.3167-1-jcrouse@codeaurora.org> <20200604205710.3167-7-jcrouse@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jun 04, 2020 at 02:27:21PM -0700, Rob Clark wrote: > On Thu, Jun 4, 2020 at 1:57 PM Jordan Crouse wrote: > > > > Set the qcom,adreno-smmu compatible string for the GPU SMMU to enable > > split pagetables. > > > > Signed-off-by: Jordan Crouse > > --- > > > > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > > index 8eb5a31346d2..8b15cd74e9ba 100644 > > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > > @@ -3556,7 +3556,7 @@ > > }; > > > > adreno_smmu: iommu@5040000 { > > - compatible = "qcom,sdm845-smmu-v2", "qcom,smmu-v2"; > > + compatible = "qcom,adreno-smmu", "qcom,smmu-v2"; > > Should this be something like: > > compatible = "qcom,adreno-smmu", "qcom,sdm845-smmu-v2", "qcom,smmu-v2"; > > so that new dtb still works with old kernel? As far as I know qcom,sdm845-smmu-v2 never was actually used unless we were doing the parsing trick somewhere. Jordan > > reg = <0 0x5040000 0 0x10000>; > > #iommu-cells = <1>; > > #global-interrupts = <2>; > > -- > > 2.17.1 > > > > _______________________________________________ > > Freedreno mailing list > > Freedreno@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/freedreno > _______________________________________________ > Freedreno mailing list > Freedreno@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/freedreno -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project