Re: [PATCH V7 RESEND 2/7] soc: qcom-geni-se: Add interconnect support to fix earlycon crash

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2837 bytes --]

Hi Akash,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on driver-core/driver-core-testing]
[also build test ERROR on usb/usb-testing linus/master next-20200608]
[cannot apply to tty/tty-testing spi/for-next wsa/i2c/for-next v5.7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Akash-Asthana/Add-interconnect-support-to-QSPI-and-QUP-drivers/20200609-135943
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git af7b4801030c07637840191c69eb666917e4135d
config: i386-randconfig-s001-20200608 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-247-gcadbd124-dirty
        # save the attached .config to linux build tree
        make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>, old ones prefixed by <<):

drivers/soc/qcom/qcom-geni-se.c: In function 'geni_remove_earlycon_icc_vote':
>> drivers/soc/qcom/qcom-geni-se.c:819:11: error: implicit declaration of function 'of_get_next_parent'; did you mean 'of_get_parent'? [-Werror=implicit-function-declaration]
819 |  parent = of_get_next_parent(wrapper->dev->of_node);
|           ^~~~~~~~~~~~~~~~~~
|           of_get_parent
>> drivers/soc/qcom/qcom-geni-se.c:819:9: warning: assignment to 'struct device_node *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
819 |  parent = of_get_next_parent(wrapper->dev->of_node);
|         ^
cc1: some warnings being treated as errors

vim +819 drivers/soc/qcom/qcom-geni-se.c

   808	
   809	void geni_remove_earlycon_icc_vote(void)
   810	{
   811		struct geni_wrapper *wrapper;
   812		struct device_node *parent;
   813		struct device_node *child;
   814	
   815		if (!earlycon_wrapper)
   816			return;
   817	
   818		wrapper = earlycon_wrapper;
 > 819		parent = of_get_next_parent(wrapper->dev->of_node);
   820		for_each_child_of_node(parent, child) {
   821			if (!of_device_is_compatible(child, "qcom,geni-se-qup"))
   822				continue;
   823			wrapper = platform_get_drvdata(of_find_device_by_node(child));
   824			icc_put(wrapper->to_core.path);
   825			wrapper->to_core.path = NULL;
   826	
   827		}
   828		of_node_put(parent);
   829	
   830		earlycon_wrapper = NULL;
   831	}
   832	EXPORT_SYMBOL(geni_remove_earlycon_icc_vote);
   833	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31928 bytes --]