From: Rob Herring <robh@kernel.org>
To: Jeff Chase <jnchase@google.com>
Cc: linux-media@vger.kernel.org, mchehab@kernel.org,
hverkuil-cisco@xs4all.nl, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: Add ch7322 media i2c device
Date: Wed, 10 Jun 2020 13:53:48 -0600 [thread overview]
Message-ID: <20200610195348.GA3606875@bogus> (raw)
In-Reply-To: <20200602190914.218541-2-jnchase@google.com>
On Tue, Jun 02, 2020 at 03:09:13PM -0400, Jeff Chase wrote:
> The ch7322 is a Chrontel CEC controller.
>
> Signed-off-by: Jeff Chase <jnchase@google.com>
> ---
> .../bindings/media/i2c/chrontel,ch7322.yaml | 67 +++++++++++++++++++
> .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> MAINTAINERS | 7 ++
> 3 files changed, 76 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/chrontel,ch7322.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/chrontel,ch7322.yaml b/Documentation/devicetree/bindings/media/i2c/chrontel,ch7322.yaml
> new file mode 100644
> index 000000000000..daa2869377c5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/chrontel,ch7322.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/media/i2c/chrontel,ch7322.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Chrontel HDMI-CEC Controller
> +
> +maintainers:
> + - Jeff Chase <jnchase@google.com>
> +
> +description:
> + The Chrontel CH7322 is a discrete HDMI-CEC controller. It is
> + programmable through I2C and drives a single CEC line.
> +
> +properties:
> + compatible:
> + const: chrontel,ch7322
> +
> + reg:
> + description: I2C device address
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + reset-gpios:
> + description:
> + Reference to the GPIO connected to the RESET pin, if any. This
> + pin is active-low.
> + maxItems: 1
> +
> + standby-gpios:
> + description:
> + Reference to the GPIO connected to the OE pin, if any. When low
> + the device will respond to power status requests with "standby"
> + if in auto mode.
> + maxItems: 1
> +
> + # see ../cec.txt
> + hdmi-phandle:
> + description: phandle to the HDMI controller
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + ch7322@75 {
> + compatible = "chrontel,ch7322";
> + reg = <0x75>;
> + interrupts = <47 IRQ_TYPE_EDGE_RISING>;
> + standby-gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
> + reset-gpios = <&gpio 15 GPIO_ACTIVE_LOW>;
> + hdmi-phandle = <&hdmi>;
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index d3891386d671..7794ffccd325 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -187,6 +187,8 @@ patternProperties:
> description: ChipOne
> "^chipspark,.*":
> description: ChipSPARK
> + "^chrontel,.*":
> + description: Chrontel, Inc.
This is in Linus' master already, so you can drop it. Otherwise,
Reviewed-by: Rob Herring <robh@kernel.org>
Rob
next prev parent reply other threads:[~2020-06-10 19:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 19:09 [PATCH v4 0/2] CH7322 CEC controller driver Jeff Chase
2020-06-02 19:09 ` [PATCH v4 1/2] dt-bindings: Add ch7322 media i2c device Jeff Chase
2020-06-10 19:53 ` Rob Herring [this message]
2020-06-02 19:09 ` [PATCH v4 2/2] media: cec: i2c: ch7322: Add ch7322 CEC controller driver Jeff Chase
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610195348.GA3606875@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jnchase@google.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).