* [PATCH] dt-bindings: mfd: Ensure 'syscon' has a more specific compatible
@ 2020-06-10 19:46 Rob Herring
2020-06-11 6:38 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2020-06-10 19:46 UTC (permalink / raw)
To: devicetree; +Cc: linux-kernel, linux-arm-kernel, Lee Jones, Maxime Ripard
Using 'syscon' alone should be avoided as compatible strings should be
specific enough to identify the exact set of registers contained. Update
the schema to ensure at least 2 compatible strings are present.
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Maxime Ripard <maxime@cerno.tech>
Signed-off-by: Rob Herring <robh@kernel.org>
---
FYI, there's 43 cases of this on arm32 in my testing.
Documentation/devicetree/bindings/mfd/syscon.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index 19bdaf781853..af7a68051392 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -43,7 +43,8 @@ properties:
- contains:
const: syscon
- additionalItems: true
+ minItems: 2
+ maxItems: 4 # Should be enough
reg:
maxItems: 1
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] dt-bindings: mfd: Ensure 'syscon' has a more specific compatible
2020-06-10 19:46 [PATCH] dt-bindings: mfd: Ensure 'syscon' has a more specific compatible Rob Herring
@ 2020-06-11 6:38 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2020-06-11 6:38 UTC (permalink / raw)
To: Rob Herring, arnd
Cc: devicetree, linux-kernel, linux-arm-kernel, Maxime Ripard
Arnd,
On Wed, 10 Jun 2020, Rob Herring wrote:
> Using 'syscon' alone should be avoided as compatible strings should be
> specific enough to identify the exact set of registers contained. Update
> the schema to ensure at least 2 compatible strings are present.
I'm assuming you're okay with this?
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Maxime Ripard <maxime@cerno.tech>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> FYI, there's 43 cases of this on arm32 in my testing.
>
> Documentation/devicetree/bindings/mfd/syscon.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 19bdaf781853..af7a68051392 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -43,7 +43,8 @@ properties:
>
> - contains:
> const: syscon
> - additionalItems: true
> + minItems: 2
> + maxItems: 4 # Should be enough
>
> reg:
> maxItems: 1
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-11 6:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-10 19:46 [PATCH] dt-bindings: mfd: Ensure 'syscon' has a more specific compatible Rob Herring
2020-06-11 6:38 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).