devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Konovalov <andrey.konovalov@linaro.org>
To: mchehab@kernel.org, sakari.ailus@iki.fi,
	manivannan.sadhasivam@linaro.org
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	c.barrett@framos.com, a.brela@framos.com,
	peter.griffin@linaro.org,
	Andrey Konovalov <andrey.konovalov@linaro.org>
Subject: [PATCH v5 02/10] media: i2c: imx290: fix the order of the args in SET_RUNTIME_PM_OPS()
Date: Fri, 12 Jun 2020 16:53:47 +0300	[thread overview]
Message-ID: <20200612135355.30286-3-andrey.konovalov@linaro.org> (raw)
In-Reply-To: <20200612135355.30286-1-andrey.konovalov@linaro.org>

The macro is defined as SET_RUNTIME_PM_OPS(suspend_fn, resume_fn, idle_fn),
so imx290_power_off must be the 1st arg, and imx290_power_on the 2nd.

Signed-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 drivers/media/i2c/imx290.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
index 2d8c38ffe2f0..d0322f9a8856 100644
--- a/drivers/media/i2c/imx290.c
+++ b/drivers/media/i2c/imx290.c
@@ -648,7 +648,7 @@ static int imx290_power_off(struct device *dev)
 }
 
 static const struct dev_pm_ops imx290_pm_ops = {
-	SET_RUNTIME_PM_OPS(imx290_power_on, imx290_power_off, NULL)
+	SET_RUNTIME_PM_OPS(imx290_power_off, imx290_power_on, NULL)
 };
 
 static const struct v4l2_subdev_video_ops imx290_video_ops = {
-- 
2.17.1


  parent reply	other threads:[~2020-06-12 13:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-12 13:53 [PATCH v5 00/10] Improvements to IMX290 CMOS driver Andrey Konovalov
2020-06-12 13:53 ` [PATCH v5 01/10] media: i2c: imx290: set the format before VIDIOC_SUBDEV_G_FMT is called Andrey Konovalov
2020-06-12 13:53 ` Andrey Konovalov [this message]
2020-06-12 13:53 ` [PATCH v5 03/10] media: i2c: imx290: fix reset GPIO pin handling Andrey Konovalov
2020-06-12 13:53 ` [PATCH v5 04/10] media: i2c: imx290: Add support for 2 data lanes Andrey Konovalov
2020-06-12 13:53 ` [PATCH v5 05/10] media: i2c: imx290: Add configurable link frequency and pixel rate Andrey Konovalov
2020-06-12 13:53 ` [PATCH v5 06/10] media: i2c: imx290: Add support for test pattern generation Andrey Konovalov
2020-06-23 12:25   ` Sakari Ailus
2020-06-12 13:53 ` [PATCH v5 07/10] media: i2c: imx290: Add RAW12 mode support Andrey Konovalov
2020-06-12 13:53 ` [PATCH v5 08/10] media: i2c: imx290: Add support to enumerate all frame sizes Andrey Konovalov
2020-06-12 13:53 ` [PATCH v5 09/10] media: i2c: imx290: Move the settle time delay out of loop Andrey Konovalov
2020-06-12 13:53 ` [PATCH v5 10/10] media: i2c: imx290: set bus_type before calling v4l2_fwnode_endpoint_alloc_parse() Andrey Konovalov
2020-06-15 14:01   ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200612135355.30286-3-andrey.konovalov@linaro.org \
    --to=andrey.konovalov@linaro.org \
    --cc=a.brela@framos.com \
    --cc=c.barrett@framos.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=mchehab@kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=sakari.ailus@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).