Re: [PATCH 2/2 v2] dt-bindings: power: reset: add yaml bindings for LinkStation power off

[Rob Herring <robh@kernel.org>]

On Thu, Jun 11, 2020 at 10:29:22PM +0200, Daniel González Cabanelas wrote:
> Add Linkstation poweroff bindings documentation. 
> 
> Signed-off-by: Daniel González Cabanelas <dgcbueu@gmail.com>
> ---
> Changes in v2:
>   - Changed the required properties and description to adjust to the new
>     driver now enabling the WoL feature on the device.
> 
>  .../power/reset/linkstation-poweroff.yaml     | 43 +++++++++++++++++++
>  1 file changed, 43 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/reset/linkstation-poweroff.yaml
> 
> diff --git a/Documentation/devicetree/bindings/power/reset/linkstation-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/linkstation-poweroff.yaml
> new file mode 100644
> index 0000000000..475eab8225
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/reset/linkstation-poweroff.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: GPL-2.0

Dual license:

(GPL-2.0-only OR BSD-2-Clause)

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/reset/linkstation-poweroff.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Buffalo Linkstation poweroff driver

This is a binding for h/w, not a driver.

> +
> +maintainers:
> +  - Daniel González Cabanelas <dgcbueu@gmail.com>
> +
> +description: |
> +  This driver is used to add the power off function to some Buffalo
> +  LinkStations (ARM MVEBU boards). They use an output pin at the ethernet PHY
> +  (LED2/INTn) to inform the board if the power off operation must be performed
> +  at restart time. This pin is ORed with the power switch and allows the WOL 
> +  function to be also used.
> +
> +  When the power-off handler is called, the ethernet PHY INTn ouptut is set to
> +  LOW state. If the restart command is executed then the PHY INTn output is 
> +  forced to HIGH state.
> +
> +properties:
> +  compatible:
> +    const: linkstation,power-off
> +
> +  phy-handle,intn:

'phy-handle' is not a vendor.

> +    description: Phandle to a node of the ethernet PHY used for the power
> +      function.
> +    $ref: /schemas/types.yaml#/definitions/phandle

Is there more than 1 ethernet phy? If not, then I don't see why you need 
this binding at all. Use the top level compatible and find the ethernet 
phy in the tree.

> +
> +required:
> +  - compatible
> +  - phy-handle,intn
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    poweroff {
> +        compatible = "linkstation,power-off";
> +        phy-handle,intn = <&ethphy0>;
> +    };
> -- 
> 2.27.0
> 
> 
> 
>