From: Rob Herring <robh@kernel.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: broonie@kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: dt-bindings: add compatible string for MAX98360A
Date: Mon, 15 Jun 2020 11:35:30 -0600 [thread overview]
Message-ID: <20200615173530.GB2006513@bogus> (raw)
In-Reply-To: <20200605034931.107713-3-tzungbi@google.com>
On Fri, Jun 05, 2020 at 11:49:31AM +0800, Tzung-Bi Shih wrote:
> Maxim MAX98360A audio amplifier is functionally identical to MAX98357A.
> Adds compatible string "maxim,max98360a" for driver reuse.
>
> Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
> ---
> .../devicetree/bindings/sound/max98357a.txt | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/max98357a.txt b/Documentation/devicetree/bindings/sound/max98357a.txt
> index 4bce14ce806f..75db84d06240 100644
> --- a/Documentation/devicetree/bindings/sound/max98357a.txt
> +++ b/Documentation/devicetree/bindings/sound/max98357a.txt
> @@ -1,9 +1,10 @@
> -Maxim MAX98357A audio DAC
> +Maxim MAX98357A/MAX98360A audio DAC
>
> -This node models the Maxim MAX98357A DAC.
> +This node models the Maxim MAX98357A/MAX98360A DAC.
>
> Required properties:
> -- compatible : "maxim,max98357a"
> +- compatible : "maxim,max98357a" for MAX98357A.
> + "maxim,max98360a" for MAX98360A.
>
> Optional properties:
> - sdmode-gpios : GPIO specifier for the chip's SD_MODE pin.
> @@ -20,3 +21,8 @@ max98357a {
> compatible = "maxim,max98357a";
> sdmode-gpios = <&qcom_pinmux 25 0>;
> };
> +
> +max98360a {
> + compatible = "maxim,max98360a";
> + sdmode-gpios = <&qcom_pinmux 25 0>;
> +};
Nothing new here, you don't need another example.
> --
> 2.27.0.278.ge193c7cf3a9-goog
>
next prev parent reply other threads:[~2020-06-15 17:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 3:49 [PATCH 0/2] ASoC: max98357a: support MAX98360A in OF Tzung-Bi Shih
2020-06-05 3:49 ` [PATCH 1/2] ASoC: max98357a: add compatible string for MAX98360A Tzung-Bi Shih
2020-06-05 3:49 ` [PATCH 2/2] ASoC: dt-bindings: " Tzung-Bi Shih
2020-06-15 17:35 ` Rob Herring [this message]
2020-06-15 23:40 ` [PATCH 0/2] ASoC: max98357a: support MAX98360A in OF Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615173530.GB2006513@bogus \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).