From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84659C433E0 for ; Mon, 15 Jun 2020 17:45:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 649DF2078A for ; Mon, 15 Jun 2020 17:45:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592243120; bh=x7aWa3ERynTO62vC4sDxAGQx/aHtiEifeDzxKPdV7/E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=M90n0R/5bVI6LivxiY2Js1ar38qa6foWNoAkMQRqflnkZ9S5BXnoNLojMPGmMJc5E 2+evxtAnXmgqKvCS0L1EP3QUr4M9MW4g5E09p7kE3hWxo/jjADgRgra5IRp5RzJu2e MSNQ9mAG0I8M+ss77Xm86ih80VpxXVj9m+8eEzNk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728585AbgFORpT (ORCPT ); Mon, 15 Jun 2020 13:45:19 -0400 Received: from mail-il1-f195.google.com ([209.85.166.195]:40524 "EHLO mail-il1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729124AbgFORpT (ORCPT ); Mon, 15 Jun 2020 13:45:19 -0400 Received: by mail-il1-f195.google.com with SMTP id t8so187996ilm.7; Mon, 15 Jun 2020 10:45:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yY9vsdbUetvZHFE31+hfyR4zS8VWyOrgrboCYCv/8Es=; b=Ad+HGS6IhiQAKe6aWHl9u1CsHcl2nBr2y9cFsNKUX07qldfl/lUKKGmoPIFsIjZbk0 ClsrbLeA6vKNI++uRbmqYKbalPsi6RZlEKDSaC0tEqLyh8h9wGSXF3R5J/7St+bLYXbU 775ZBLEIm9dN/3rxndWWFNVGPuilhl7LwFnaJXV5c0myQlQwMbvsXwrZ4TlGR5Js7krP aNN/ctDoMKcunKDZ5k8BckAUTfMflqKQSR2KZIMK/c8hGBQTVTjeA1YgChS6IGKtbbMu KnNhUbkbX0FCnGOUIPfP+s/Ij+gmC/+aHKFNsij2CvvIQEhNfCtFgZ6S+CpvzF0/0rg/ gySQ== X-Gm-Message-State: AOAM531te8qLfIqPnKI7o5KQ5dUOrkigk+BgJuG06HtENKqbJ7So3zjK KvXGaZ4nYr60nmKjiGSBdA== X-Google-Smtp-Source: ABdhPJwOXqazAV/sM0GMJuEhVIuLysGJdm4vB1cY73m25QTyGn1nHq3E9zbNcU5wGs7GjtP99KP3sg== X-Received: by 2002:a92:c985:: with SMTP id y5mr28134527iln.50.1592243118446; Mon, 15 Jun 2020 10:45:18 -0700 (PDT) Received: from xps15 ([64.188.179.251]) by smtp.gmail.com with ESMTPSA id z16sm8322579ilz.64.2020.06.15.10.45.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2020 10:45:17 -0700 (PDT) Received: (nullmailer pid 2023356 invoked by uid 1000); Mon, 15 Jun 2020 17:45:16 -0000 Date: Mon, 15 Jun 2020 11:45:16 -0600 From: Rob Herring To: Jonathan McDowell Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: net: dsa: qca8k: document SGMII properties Message-ID: <20200615174516.GA2018349@bogus> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Jun 05, 2020 at 07:10:02PM +0100, Jonathan McDowell wrote: > This patch documents the qca8k's SGMII related properties that allow > configuration of the SGMII port. > > Signed-off-by: Jonathan McDowell > --- > Documentation/devicetree/bindings/net/dsa/qca8k.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > index ccbc6d89325d..9e7d74a248ad 100644 > --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt > +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > @@ -11,7 +11,11 @@ Required properties: > > Optional properties: > > +- disable-serdes-autoneg: Boolean, disables auto-negotiation on the SerDes > - reset-gpios: GPIO to be used to reset the whole device > +- sgmii-delay: Boolean, presence delays SGMII clock by 2ns > +- sgmii-mode: String, operation mode of the SGMII interface. > + Supported values are: "basex", "mac", "phy". Either these should be common properties and documented in a common spot or they need vendor prefixes. They seem like they former to me (though 'sgmii-delay' would need to be more general and take a time). Rob