From: Pavel Machek <pavel@ucw.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: jacek.anaszewski@gmail.com, devicetree@vger.kernel.org,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v27 03/15] leds: multicolor: Introduce a multicolor class definition
Date: Tue, 16 Jun 2020 12:54:29 +0200 [thread overview]
Message-ID: <20200616105429.GI1718@bug> (raw)
In-Reply-To: <20200608193917.13084-4-dmurphy@ti.com>
Hi!
> +static ssize_t multi_intensity_show(struct device *dev,
> + struct device_attribute *intensity_attr,
> + char *buf)
> +{
> + struct led_classdev *led_cdev = dev_get_drvdata(dev);
> + struct led_classdev_mc *mcled_cdev = lcdev_to_mccdev(led_cdev);
> + int len = 0;
> + int i;
> +
> + for (i = 0; i < mcled_cdev->num_colors; i++) {
> + len += sprintf(buf + len, "%d",
> + mcled_cdev->subled_info[i].intensity);
> + if (i < mcled_cdev->num_colors)
> + len += sprintf(buf + len, " ");
Always false, AFAICT.
Pavel
next prev parent reply other threads:[~2020-06-16 10:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 19:39 [PATCH v27 00/15] Multicolor Framework v27 Dan Murphy
2020-06-08 19:39 ` [PATCH v27 01/15] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2020-06-08 19:39 ` [PATCH v27 02/15] leds: Add multicolor ID to the color ID list Dan Murphy
2020-06-08 19:39 ` [PATCH v27 03/15] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2020-06-16 10:54 ` Pavel Machek [this message]
2020-06-08 19:39 ` [PATCH v27 04/15] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2020-06-08 19:39 ` [PATCH v27 05/15] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2020-06-08 19:39 ` [PATCH v27 06/15] dt-bindings: leds: Convert leds-lp55xx to yaml Dan Murphy
2020-06-08 19:39 ` [PATCH v27 07/15] ARM: dts: n900: Add reg property to the LP5523 channel node Dan Murphy
2020-06-08 19:39 ` [PATCH v27 08/15] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 " Dan Murphy
2020-06-08 19:39 ` [PATCH v27 09/15] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes Dan Murphy
2020-06-08 19:39 ` [PATCH v27 10/15] leds: lp55xx: Convert LED class registration to devm_* Dan Murphy
2020-06-08 19:39 ` [PATCH v27 11/15] leds: lp55xx: Add multicolor framework support to lp55xx Dan Murphy
2020-06-08 19:39 ` [PATCH v27 12/15] leds: lp5523: Update the lp5523 code to add multicolor brightness function Dan Murphy
2020-06-08 19:39 ` [PATCH v27 13/15] leds: lp5521: Add multicolor framework multicolor brightness support Dan Murphy
2020-06-08 19:39 ` [PATCH v27 14/15] leds: lp55xx: Fix file permissions to use DEVICE_ATTR macros Dan Murphy
2020-06-08 19:39 ` [PATCH v27 15/15] leds: lp5523: Fix various formatting issues in the code Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616105429.GI1718@bug \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).