From: Rob Herring <robh@kernel.org>
To: Iskren Chernev <iskren.chernev@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 1/2] dt-bindints: power: supply: Document max17040 extensions
Date: Wed, 17 Jun 2020 14:51:28 -0600 [thread overview]
Message-ID: <20200617205128.GA2775414@bogus> (raw)
In-Reply-To: <20200608182642.592848-1-iskren.chernev@gmail.com>
typo in the subject
On Mon, Jun 08, 2020 at 09:26:41PM +0300, Iskren Chernev wrote:
> Maxim max17040 is a fuel gauge from a larger family utilising the Model
> Gauge thechnology. Document all different compatible strings that the
typo
> max17040 driver recognizes.
>
> Some devices in the wild report double the capacity. The
> maxim,double-soc (from State-Of-Charge) property fixes that.
>
> To compensate for the battery chemistry and operating conditions the
> chips support a compensation value. Specify one or two byte compensation
> via the maxim,rcomp byte array.
>
> Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com>
> ---
> .../power/supply/max17040_battery.txt | 22 ++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/max17040_battery.txt b/Documentation/devicetree/bindings/power/supply/max17040_battery.txt
> index 4e0186b8380fa..be11cab4530b9 100644
> --- a/Documentation/devicetree/bindings/power/supply/max17040_battery.txt
> +++ b/Documentation/devicetree/bindings/power/supply/max17040_battery.txt
> @@ -2,7 +2,9 @@ max17040_battery
> ~~~~~~~~~~~~~~~~
>
> Required properties :
> - - compatible : "maxim,max17040" or "maxim,max77836-battery"
> + - compatible : "maxim,max17040", "maxim,max17041", "maxim,max17043",
> + "maxim,max17044", "maxim,max17048", "maxim,max17049",
> + "maxim,max17058", "maxim,max17059" or "maxim,max77836-battery"
> - reg: i2c slave address
>
> Optional properties :
> @@ -11,6 +13,15 @@ Optional properties :
> generated. Can be configured from 1 up to 32
> (%). If skipped the power up default value of
> 4 (%) will be used.
> +- maxim,double-soc : Certain devices return double the capacity.
> + Specify this boolean property to divide the
> + reported value in 2 and thus normalize it.
> + SOC == State of Charge == Capacity.
> +- maxim,rcomp : A value to compensate readings for various
> + battery chemistries and operating temperatures.
> + max17040,41 have 2 byte rcomp, default to
> + 0x97 0x00. All other devices have one byte
> + rcomp, default to 0x97.
> - interrupts : Interrupt line see Documentation/devicetree/
> bindings/interrupt-controller/interrupts.txt
> - wakeup-source : This device has wakeup capabilities. Use this
> @@ -27,7 +38,16 @@ Example:
> compatible = "maxim,max77836-battery";
> reg = <0x36>;
> maxim,alert-low-soc-level = <10>;
> + maxim,rcomp = /bits/ 8 <0x97 0x00>;
> interrupt-parent = <&gpio7>;
> interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
> wakeup-source;
> };
> +
> + battery-fuel-gauge@36 {
> + compatible = "maxim,max17048";
> + reg = <0x36>;
> + maxim,rcomp = /bits/ 8 <0x97>;
> + maxim,alert-low-soc-level = <10>;
> + maxim,double-soc;
> + };
>
> base-commit: 1713116fa907cc7290020f0d8632ec646d2936f8
> --
> 2.27.0
>
prev parent reply other threads:[~2020-06-17 20:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 18:26 [PATCH 1/2] dt-bindints: power: supply: Document max17040 extensions Iskren Chernev
2020-06-08 18:26 ` [PATCH 2/2] power: supply: max17040: Support compatible devices Iskren Chernev
2020-06-08 21:23 ` kernel test robot
2020-06-08 21:23 ` [RFC PATCH] power: supply: max17040: max17040_family[] can be static kernel test robot
2020-06-08 22:20 ` [PATCH 2/2] power: supply: max17040: Support compatible devices kernel test robot
2020-06-17 20:51 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200617205128.GA2775414@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=iskren.chernev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).