devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/13] Patches to improve transfer efficiency for Rockchip SoCs.
@ 2020-06-09  1:14 Sugar Zhang
  2020-06-09  1:14 ` [PATCH v2 03/13] dt-bindings: dma: pl330: Document the quirk 'arm,pl330-periph-burst' Sugar Zhang
                   ` (11 more replies)
  0 siblings, 12 replies; 16+ messages in thread
From: Sugar Zhang @ 2020-06-09  1:14 UTC (permalink / raw)
  To: Vinod Koul, Heiko Stuebner
  Cc: linux-rockchip, Sugar Zhang, devicetree, Andy Yan,
	Enric Balletbo i Serra, Miquel Raynal, Leonidas P. Papadakos,
	Jonas Karlman, Johan Jonker, linux-kernel, Dan Williams,
	Robin Murphy, Rob Herring, Carlos de Paula, dmaengine,
	Chen-Yu Tsai, linux-arm-kernel, Daniel Lezcano



Changes in v2:
- fix FATAL ERROR: Unable to parse input tree

Sugar Zhang (13):
  dmaengine: pl330: Remove the burst limit for quirk 'NO-FLUSHP'
  dmaengine: pl330: Add quirk 'arm,pl330-periph-burst'
  dt-bindings: dma: pl330: Document the quirk 'arm,pl330-periph-burst'
  ARM: dts: rk3036: Add 'arm,pl330-periph-burst' for dmac
  ARM: dts: rk322x: Add 'arm,pl330-periph-burst' for dmac
  ARM: dts: rk3288: Add 'arm,pl330-periph-burst' for dmac
  ARM: dts: rk3xxx: Add 'arm,pl330-periph-burst' for dmac
  ARM: dts: rv1108: Add 'arm,pl330-periph-burst' for dmac
  arm64: dts: px30: Add 'arm,pl330-periph-burst' for dmac
  arm64: dts: rk3308: Add 'arm,pl330-periph-burst' for dmac
  arm64: dts: rk3328: Add 'arm,pl330-periph-burst' for dmac
  arm64: dts: rk3368: Add 'arm,pl330-periph-burst' for dmac
  arm64: dts: rk3399: Add 'arm,pl330-periph-burst' for dmac

 .../devicetree/bindings/dma/arm-pl330.txt          |  1 +
 arch/arm/boot/dts/rk3036.dtsi                      |  1 +
 arch/arm/boot/dts/rk322x.dtsi                      |  1 +
 arch/arm/boot/dts/rk3288.dtsi                      |  3 ++
 arch/arm/boot/dts/rk3xxx.dtsi                      |  3 ++
 arch/arm/boot/dts/rv1108.dtsi                      |  1 +
 arch/arm64/boot/dts/rockchip/px30.dtsi             |  1 +
 arch/arm64/boot/dts/rockchip/rk3308.dtsi           |  2 +
 arch/arm64/boot/dts/rockchip/rk3328.dtsi           |  1 +
 arch/arm64/boot/dts/rockchip/rk3368.dtsi           |  2 +
 arch/arm64/boot/dts/rockchip/rk3399.dtsi           |  2 +
 drivers/dma/pl330.c                                | 44 +++++++++++++++-------
 12 files changed, 49 insertions(+), 13 deletions(-)

-- 
2.7.4




^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH v2 03/13] dt-bindings: dma: pl330: Document the quirk 'arm,pl330-periph-burst'
  2020-06-09  1:14 [PATCH v2 0/13] Patches to improve transfer efficiency for Rockchip SoCs Sugar Zhang
@ 2020-06-09  1:14 ` Sugar Zhang
  2020-06-17 20:58   ` Rob Herring
  2020-06-09  1:14 ` [PATCH v2 04/13] ARM: dts: rk3036: Add 'arm,pl330-periph-burst' for dmac Sugar Zhang
                   ` (10 subsequent siblings)
  11 siblings, 1 reply; 16+ messages in thread
From: Sugar Zhang @ 2020-06-09  1:14 UTC (permalink / raw)
  To: Vinod Koul, Heiko Stuebner
  Cc: linux-rockchip, Sugar Zhang, Rob Herring, dmaengine, devicetree,
	linux-kernel

This patch Adds the quirk 'arm,pl330-periph-burst' for pl330.

Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>
---

Changes in v2: None

 Documentation/devicetree/bindings/dma/arm-pl330.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/dma/arm-pl330.txt b/Documentation/devicetree/bindings/dma/arm-pl330.txt
index 2c7fd19..315e901 100644
--- a/Documentation/devicetree/bindings/dma/arm-pl330.txt
+++ b/Documentation/devicetree/bindings/dma/arm-pl330.txt
@@ -16,6 +16,7 @@ Optional properties:
   - dma-channels: contains the total number of DMA channels supported by the DMAC
   - dma-requests: contains the total number of DMA requests supported by the DMAC
   - arm,pl330-broken-no-flushp: quirk for avoiding to execute DMAFLUSHP
+  - arm,pl330-periph-burst: quirk for performing burst transfer only
   - resets: contains an entry for each entry in reset-names.
 	    See ../reset/reset.txt for details.
   - reset-names: must contain at least "dma", and optional is "dma-ocp".
-- 
2.7.4




^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v2 04/13] ARM: dts: rk3036: Add 'arm,pl330-periph-burst' for dmac
  2020-06-09  1:14 [PATCH v2 0/13] Patches to improve transfer efficiency for Rockchip SoCs Sugar Zhang
  2020-06-09  1:14 ` [PATCH v2 03/13] dt-bindings: dma: pl330: Document the quirk 'arm,pl330-periph-burst' Sugar Zhang
@ 2020-06-09  1:14 ` Sugar Zhang
  2020-06-09  1:20 ` [PATCH v2 05/13] ARM: dts: rk322x: " Sugar Zhang
                   ` (9 subsequent siblings)
  11 siblings, 0 replies; 16+ messages in thread
From: Sugar Zhang @ 2020-06-09  1:14 UTC (permalink / raw)
  To: Vinod Koul, Heiko Stuebner
  Cc: linux-rockchip, Sugar Zhang, Rob Herring, linux-arm-kernel,
	devicetree, linux-kernel

This patch Add the quirk to specify to use burst transfer
for better compatible and higher performance.

Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>

---

Changes in v2:
- fix FATAL ERROR: Unable to parse input tree

 arch/arm/boot/dts/rk3036.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/rk3036.dtsi b/arch/arm/boot/dts/rk3036.dtsi
index d9a0c9a2..0935670 100644
--- a/arch/arm/boot/dts/rk3036.dtsi
+++ b/arch/arm/boot/dts/rk3036.dtsi
@@ -67,6 +67,7 @@
 				     <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
 			#dma-cells = <1>;
 			arm,pl330-broken-no-flushp;
+			arm,pl330-periph-burst;
 			clocks = <&cru ACLK_DMAC2>;
 			clock-names = "apb_pclk";
 		};
-- 
2.7.4




^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v2 05/13] ARM: dts: rk322x: Add 'arm,pl330-periph-burst' for dmac
  2020-06-09  1:14 [PATCH v2 0/13] Patches to improve transfer efficiency for Rockchip SoCs Sugar Zhang
  2020-06-09  1:14 ` [PATCH v2 03/13] dt-bindings: dma: pl330: Document the quirk 'arm,pl330-periph-burst' Sugar Zhang
  2020-06-09  1:14 ` [PATCH v2 04/13] ARM: dts: rk3036: Add 'arm,pl330-periph-burst' for dmac Sugar Zhang
@ 2020-06-09  1:20 ` Sugar Zhang
  2020-06-09  1:20 ` [PATCH v2 06/13] ARM: dts: rk3288: " Sugar Zhang
                   ` (8 subsequent siblings)
  11 siblings, 0 replies; 16+ messages in thread
From: Sugar Zhang @ 2020-06-09  1:20 UTC (permalink / raw)
  To: heiko, vkoul; +Cc: linux-rockchip, devicetree, Sugar Zhang

This patch Add the quirk to specify to use burst transfer
for better compatible and higher performance.

Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>

---

Changes in v2:
- fix FATAL ERROR: Unable to parse input tree

 arch/arm/boot/dts/rk322x.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
index 5485a99..bd043a8 100644
--- a/arch/arm/boot/dts/rk322x.dtsi
+++ b/arch/arm/boot/dts/rk322x.dtsi
@@ -109,6 +109,7 @@
 			#dma-cells = <1>;
 			clocks = <&cru ACLK_DMAC>;
 			clock-names = "apb_pclk";
+			arm,pl330-periph-burst;
 		};
 	};
 
-- 
2.7.4




^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v2 06/13] ARM: dts: rk3288: Add 'arm,pl330-periph-burst' for dmac
  2020-06-09  1:14 [PATCH v2 0/13] Patches to improve transfer efficiency for Rockchip SoCs Sugar Zhang
                   ` (2 preceding siblings ...)
  2020-06-09  1:20 ` [PATCH v2 05/13] ARM: dts: rk322x: " Sugar Zhang
@ 2020-06-09  1:20 ` Sugar Zhang
  2020-06-09  1:20 ` [PATCH v2 07/13] ARM: dts: rk3xxx: " Sugar Zhang
                   ` (7 subsequent siblings)
  11 siblings, 0 replies; 16+ messages in thread
From: Sugar Zhang @ 2020-06-09  1:20 UTC (permalink / raw)
  To: heiko, vkoul; +Cc: linux-rockchip, devicetree, Sugar Zhang

This patch Add the quirk to specify to use burst transfer
for better compatible and higher performance.

Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>

---

Changes in v2:
- fix FATAL ERROR: Unable to parse input tree

 arch/arm/boot/dts/rk3288.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 0cd8877..740267a 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -168,6 +168,7 @@
 				     <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
 			#dma-cells = <1>;
 			arm,pl330-broken-no-flushp;
+			arm,pl330-periph-burst;
 			clocks = <&cru ACLK_DMAC2>;
 			clock-names = "apb_pclk";
 		};
@@ -179,6 +180,7 @@
 				     <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
 			#dma-cells = <1>;
 			arm,pl330-broken-no-flushp;
+			arm,pl330-periph-burst;
 			clocks = <&cru ACLK_DMAC1>;
 			clock-names = "apb_pclk";
 			status = "disabled";
@@ -191,6 +193,7 @@
 				     <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
 			#dma-cells = <1>;
 			arm,pl330-broken-no-flushp;
+			arm,pl330-periph-burst;
 			clocks = <&cru ACLK_DMAC1>;
 			clock-names = "apb_pclk";
 		};
-- 
2.7.4




^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v2 07/13] ARM: dts: rk3xxx: Add 'arm,pl330-periph-burst' for dmac
  2020-06-09  1:14 [PATCH v2 0/13] Patches to improve transfer efficiency for Rockchip SoCs Sugar Zhang
                   ` (3 preceding siblings ...)
  2020-06-09  1:20 ` [PATCH v2 06/13] ARM: dts: rk3288: " Sugar Zhang
@ 2020-06-09  1:20 ` Sugar Zhang
  2020-06-09  1:20 ` [PATCH v2 08/13] ARM: dts: rv1108: " Sugar Zhang
                   ` (6 subsequent siblings)
  11 siblings, 0 replies; 16+ messages in thread
From: Sugar Zhang @ 2020-06-09  1:20 UTC (permalink / raw)
  To: heiko, vkoul; +Cc: linux-rockchip, devicetree, Sugar Zhang

This patch Add the quirk to specify to use burst transfer
for better compatible and higher performance.

Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>

---

Changes in v2:
- fix FATAL ERROR: Unable to parse input tree

 arch/arm/boot/dts/rk3xxx.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/rk3xxx.dtsi b/arch/arm/boot/dts/rk3xxx.dtsi
index d929b60..859a747 100644
--- a/arch/arm/boot/dts/rk3xxx.dtsi
+++ b/arch/arm/boot/dts/rk3xxx.dtsi
@@ -45,6 +45,7 @@
 				     <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
 			#dma-cells = <1>;
 			arm,pl330-broken-no-flushp;
+			arm,pl330-periph-burst;
 			clocks = <&cru ACLK_DMA1>;
 			clock-names = "apb_pclk";
 		};
@@ -56,6 +57,7 @@
 				     <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
 			#dma-cells = <1>;
 			arm,pl330-broken-no-flushp;
+			arm,pl330-periph-burst;
 			clocks = <&cru ACLK_DMA1>;
 			clock-names = "apb_pclk";
 			status = "disabled";
@@ -68,6 +70,7 @@
 				     <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
 			#dma-cells = <1>;
 			arm,pl330-broken-no-flushp;
+			arm,pl330-periph-burst;
 			clocks = <&cru ACLK_DMA2>;
 			clock-names = "apb_pclk";
 		};
-- 
2.7.4




^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v2 08/13] ARM: dts: rv1108: Add 'arm,pl330-periph-burst' for dmac
  2020-06-09  1:14 [PATCH v2 0/13] Patches to improve transfer efficiency for Rockchip SoCs Sugar Zhang
                   ` (4 preceding siblings ...)
  2020-06-09  1:20 ` [PATCH v2 07/13] ARM: dts: rk3xxx: " Sugar Zhang
@ 2020-06-09  1:20 ` Sugar Zhang
  2020-06-09  1:20 ` [PATCH v2 09/13] arm64: dts: px30: " Sugar Zhang
                   ` (5 subsequent siblings)
  11 siblings, 0 replies; 16+ messages in thread
From: Sugar Zhang @ 2020-06-09  1:20 UTC (permalink / raw)
  To: heiko, vkoul; +Cc: linux-rockchip, devicetree, Sugar Zhang

This patch Add the quirk to specify to use burst transfer
for better compatible and higher performance.

Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>

---

Changes in v2:
- fix FATAL ERROR: Unable to parse input tree

 arch/arm/boot/dts/rv1108.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
index f9cfe2c..4c3444a 100644
--- a/arch/arm/boot/dts/rv1108.dtsi
+++ b/arch/arm/boot/dts/rv1108.dtsi
@@ -97,6 +97,7 @@
 			interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>;
 			#dma-cells = <1>;
 			arm,pl330-broken-no-flushp;
+			arm,pl330-periph-burst;
 			clocks = <&cru ACLK_DMAC>;
 			clock-names = "apb_pclk";
 		};
-- 
2.7.4




^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v2 09/13] arm64: dts: px30: Add 'arm,pl330-periph-burst' for dmac
  2020-06-09  1:14 [PATCH v2 0/13] Patches to improve transfer efficiency for Rockchip SoCs Sugar Zhang
                   ` (5 preceding siblings ...)
  2020-06-09  1:20 ` [PATCH v2 08/13] ARM: dts: rv1108: " Sugar Zhang
@ 2020-06-09  1:20 ` Sugar Zhang
  2020-06-09  1:22 ` [PATCH v2 10/13] arm64: dts: rk3308: " Sugar Zhang
                   ` (4 subsequent siblings)
  11 siblings, 0 replies; 16+ messages in thread
From: Sugar Zhang @ 2020-06-09  1:20 UTC (permalink / raw)
  To: heiko, vkoul; +Cc: linux-rockchip, devicetree, Sugar Zhang

This patch Add the quirk to specify to use burst transfer
for better compatible and higher performance.

Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>

---

Changes in v2:
- fix FATAL ERROR: Unable to parse input tree

 arch/arm64/boot/dts/rockchip/px30.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi
index adc9b8b..5780f47 100644
--- a/arch/arm64/boot/dts/rockchip/px30.dtsi
+++ b/arch/arm64/boot/dts/rockchip/px30.dtsi
@@ -717,6 +717,7 @@
 			clocks = <&cru ACLK_DMAC>;
 			clock-names = "apb_pclk";
 			#dma-cells = <1>;
+			arm,pl330-periph-burst;
 		};
 	};
 
-- 
2.7.4




^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v2 10/13] arm64: dts: rk3308: Add 'arm,pl330-periph-burst' for dmac
  2020-06-09  1:14 [PATCH v2 0/13] Patches to improve transfer efficiency for Rockchip SoCs Sugar Zhang
                   ` (6 preceding siblings ...)
  2020-06-09  1:20 ` [PATCH v2 09/13] arm64: dts: px30: " Sugar Zhang
@ 2020-06-09  1:22 ` Sugar Zhang
  2020-06-09  1:22 ` [PATCH v2 11/13] arm64: dts: rk3328: " Sugar Zhang
                   ` (3 subsequent siblings)
  11 siblings, 0 replies; 16+ messages in thread
From: Sugar Zhang @ 2020-06-09  1:22 UTC (permalink / raw)
  To: heiko, vkoul; +Cc: linux-rockchip, devicetree, Sugar Zhang

This patch Add the quirk to specify to use burst transfer
for better compatible and higher performance.

Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>

---

Changes in v2:
- fix FATAL ERROR: Unable to parse input tree

 arch/arm64/boot/dts/rockchip/rk3308.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3308.dtsi b/arch/arm64/boot/dts/rockchip/rk3308.dtsi
index ac7f694..0a881d1 100644
--- a/arch/arm64/boot/dts/rockchip/rk3308.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3308.dtsi
@@ -527,6 +527,7 @@
 			clocks = <&cru ACLK_DMAC0>;
 			clock-names = "apb_pclk";
 			#dma-cells = <1>;
+			arm,pl330-periph-burst;
 		};
 
 		dmac1: dma-controller@ff2d0000 {
@@ -537,6 +538,7 @@
 			clocks = <&cru ACLK_DMAC1>;
 			clock-names = "apb_pclk";
 			#dma-cells = <1>;
+			arm,pl330-periph-burst;
 		};
 	};
 
-- 
2.7.4




^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v2 11/13] arm64: dts: rk3328: Add 'arm,pl330-periph-burst' for dmac
  2020-06-09  1:14 [PATCH v2 0/13] Patches to improve transfer efficiency for Rockchip SoCs Sugar Zhang
                   ` (7 preceding siblings ...)
  2020-06-09  1:22 ` [PATCH v2 10/13] arm64: dts: rk3308: " Sugar Zhang
@ 2020-06-09  1:22 ` Sugar Zhang
  2020-06-09  1:22 ` [PATCH v2 12/13] arm64: dts: rk3368: " Sugar Zhang
                   ` (2 subsequent siblings)
  11 siblings, 0 replies; 16+ messages in thread
From: Sugar Zhang @ 2020-06-09  1:22 UTC (permalink / raw)
  To: heiko, vkoul; +Cc: linux-rockchip, devicetree, Sugar Zhang

This patch Add the quirk to specify to use burst transfer
for better compatible and higher performance.

Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>

---

Changes in v2:
- fix FATAL ERROR: Unable to parse input tree

 arch/arm64/boot/dts/rockchip/rk3328.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
index a4d591d..8a9ce1e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
@@ -156,6 +156,7 @@
 			clocks = <&cru ACLK_DMAC>;
 			clock-names = "apb_pclk";
 			#dma-cells = <1>;
+			arm,pl330-periph-burst;
 		};
 	};
 
-- 
2.7.4




^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v2 12/13] arm64: dts: rk3368: Add 'arm,pl330-periph-burst' for dmac
  2020-06-09  1:14 [PATCH v2 0/13] Patches to improve transfer efficiency for Rockchip SoCs Sugar Zhang
                   ` (8 preceding siblings ...)
  2020-06-09  1:22 ` [PATCH v2 11/13] arm64: dts: rk3328: " Sugar Zhang
@ 2020-06-09  1:22 ` Sugar Zhang
  2020-06-09  1:22 ` [PATCH v2 13/13] arm64: dts: rk3399: " Sugar Zhang
  2020-06-12  1:06 ` [PATCH v2 0/13] Patches to improve transfer efficiency for Rockchip SoCs Peter Geis
  11 siblings, 0 replies; 16+ messages in thread
From: Sugar Zhang @ 2020-06-09  1:22 UTC (permalink / raw)
  To: heiko, vkoul; +Cc: linux-rockchip, devicetree, Sugar Zhang

This patch Add the quirk to specify to use burst transfer
for better compatible and higher performance.

Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>

---

Changes in v2:
- fix FATAL ERROR: Unable to parse input tree

 arch/arm64/boot/dts/rockchip/rk3368.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
index 1ebb0ee..94273bc 100644
--- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
@@ -149,6 +149,7 @@
 				     <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
 			#dma-cells = <1>;
 			arm,pl330-broken-no-flushp;
+			arm,pl330-periph-burst;
 			clocks = <&cru ACLK_DMAC_PERI>;
 			clock-names = "apb_pclk";
 		};
@@ -160,6 +161,7 @@
 				     <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
 			#dma-cells = <1>;
 			arm,pl330-broken-no-flushp;
+			arm,pl330-periph-burst;
 			clocks = <&cru ACLK_DMAC_BUS>;
 			clock-names = "apb_pclk";
 		};
-- 
2.7.4




^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v2 13/13] arm64: dts: rk3399: Add 'arm,pl330-periph-burst' for dmac
  2020-06-09  1:14 [PATCH v2 0/13] Patches to improve transfer efficiency for Rockchip SoCs Sugar Zhang
                   ` (9 preceding siblings ...)
  2020-06-09  1:22 ` [PATCH v2 12/13] arm64: dts: rk3368: " Sugar Zhang
@ 2020-06-09  1:22 ` Sugar Zhang
  2020-06-12  1:06 ` [PATCH v2 0/13] Patches to improve transfer efficiency for Rockchip SoCs Peter Geis
  11 siblings, 0 replies; 16+ messages in thread
From: Sugar Zhang @ 2020-06-09  1:22 UTC (permalink / raw)
  To: heiko, vkoul; +Cc: linux-rockchip, devicetree, Sugar Zhang

This patch Add the quirk to specify to use burst transfer
for better compatible and higher performance.

Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>

---

Changes in v2:
- fix FATAL ERROR: Unable to parse input tree

 arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index 1448f35..599b1e1 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -211,6 +211,7 @@
 			#dma-cells = <1>;
 			clocks = <&cru ACLK_DMAC0_PERILP>;
 			clock-names = "apb_pclk";
+			arm,pl330-periph-burst;
 		};
 
 		dmac_peri: dma-controller@ff6e0000 {
@@ -221,6 +222,7 @@
 			#dma-cells = <1>;
 			clocks = <&cru ACLK_DMAC1_PERILP>;
 			clock-names = "apb_pclk";
+			arm,pl330-periph-burst;
 		};
 	};
 
-- 
2.7.4




^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH v2 0/13] Patches to improve transfer efficiency for Rockchip SoCs.
  2020-06-09  1:14 [PATCH v2 0/13] Patches to improve transfer efficiency for Rockchip SoCs Sugar Zhang
                   ` (10 preceding siblings ...)
  2020-06-09  1:22 ` [PATCH v2 13/13] arm64: dts: rk3399: " Sugar Zhang
@ 2020-06-12  1:06 ` Peter Geis
  2020-06-12  1:15   ` Peter Geis
  11 siblings, 1 reply; 16+ messages in thread
From: Peter Geis @ 2020-06-12  1:06 UTC (permalink / raw)
  To: Sugar Zhang
  Cc: Vinod Koul, Heiko Stuebner, devicetree, Carlos de Paula,
	dmaengine, Jonas Karlman, Daniel Lezcano, linux-kernel,
	open list:ARM/Rockchip SoC..., Chen-Yu Tsai, Rob Herring,
	linux-arm-kernel, Miquel Raynal, Enric Balletbo i Serra, Andy Yan,
	Johan Jonker, Robin Murphy, Dan Williams, Leonidas P. Papadakos

Good Evening,

I am currently testing this on the rk3399-rockpro64, and it appears to
fully fix the gmac problem without using txpbl.
PCIe also seems to be more stable at high load.
I need to conduct long term testing, but it seems to be doing very well.

Unfortunately it doesn't fix the rk3328 gmac controller.

Tested-by: Peter Geis <pgwipeout@gmail.com>

On Mon, Jun 8, 2020 at 9:15 PM Sugar Zhang <sugar.zhang@rock-chips.com> wrote:
>
>
>
> Changes in v2:
> - fix FATAL ERROR: Unable to parse input tree
>
> Sugar Zhang (13):
>   dmaengine: pl330: Remove the burst limit for quirk 'NO-FLUSHP'
>   dmaengine: pl330: Add quirk 'arm,pl330-periph-burst'
>   dt-bindings: dma: pl330: Document the quirk 'arm,pl330-periph-burst'
>   ARM: dts: rk3036: Add 'arm,pl330-periph-burst' for dmac
>   ARM: dts: rk322x: Add 'arm,pl330-periph-burst' for dmac
>   ARM: dts: rk3288: Add 'arm,pl330-periph-burst' for dmac
>   ARM: dts: rk3xxx: Add 'arm,pl330-periph-burst' for dmac
>   ARM: dts: rv1108: Add 'arm,pl330-periph-burst' for dmac
>   arm64: dts: px30: Add 'arm,pl330-periph-burst' for dmac
>   arm64: dts: rk3308: Add 'arm,pl330-periph-burst' for dmac
>   arm64: dts: rk3328: Add 'arm,pl330-periph-burst' for dmac
>   arm64: dts: rk3368: Add 'arm,pl330-periph-burst' for dmac
>   arm64: dts: rk3399: Add 'arm,pl330-periph-burst' for dmac
>
>  .../devicetree/bindings/dma/arm-pl330.txt          |  1 +
>  arch/arm/boot/dts/rk3036.dtsi                      |  1 +
>  arch/arm/boot/dts/rk322x.dtsi                      |  1 +
>  arch/arm/boot/dts/rk3288.dtsi                      |  3 ++
>  arch/arm/boot/dts/rk3xxx.dtsi                      |  3 ++
>  arch/arm/boot/dts/rv1108.dtsi                      |  1 +
>  arch/arm64/boot/dts/rockchip/px30.dtsi             |  1 +
>  arch/arm64/boot/dts/rockchip/rk3308.dtsi           |  2 +
>  arch/arm64/boot/dts/rockchip/rk3328.dtsi           |  1 +
>  arch/arm64/boot/dts/rockchip/rk3368.dtsi           |  2 +
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi           |  2 +
>  drivers/dma/pl330.c                                | 44 +++++++++++++++-------
>  12 files changed, 49 insertions(+), 13 deletions(-)
>
> --
> 2.7.4
>
>
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2 0/13] Patches to improve transfer efficiency for Rockchip SoCs.
  2020-06-12  1:06 ` [PATCH v2 0/13] Patches to improve transfer efficiency for Rockchip SoCs Peter Geis
@ 2020-06-12  1:15   ` Peter Geis
  2020-06-12  8:58     ` sugar zhang
  0 siblings, 1 reply; 16+ messages in thread
From: Peter Geis @ 2020-06-12  1:15 UTC (permalink / raw)
  To: Sugar Zhang
  Cc: Vinod Koul, Heiko Stuebner, devicetree, Carlos de Paula,
	dmaengine, Jonas Karlman, Daniel Lezcano, linux-kernel,
	open list:ARM/Rockchip SoC..., Chen-Yu Tsai, Rob Herring,
	linux-arm-kernel, Miquel Raynal, Enric Balletbo i Serra, Andy Yan,
	Johan Jonker, Robin Murphy, Dan Williams, Leonidas P. Papadakos

On Thu, Jun 11, 2020 at 9:06 PM Peter Geis <pgwipeout@gmail.com> wrote:
>
> Good Evening,
>
> I am currently testing this on the rk3399-rockpro64, and it appears to
> fully fix the gmac problem without using txpbl.
> PCIe also seems to be more stable at high load.
> I need to conduct long term testing, but it seems to be doing very well.

Belay that, it does make it harder to trigger, but the issue still
remains on the rk3399.

>
> Unfortunately it doesn't fix the rk3328 gmac controller.
>
> Tested-by: Peter Geis <pgwipeout@gmail.com>
>
> On Mon, Jun 8, 2020 at 9:15 PM Sugar Zhang <sugar.zhang@rock-chips.com> wrote:
> >
> >
> >
> > Changes in v2:
> > - fix FATAL ERROR: Unable to parse input tree
> >
> > Sugar Zhang (13):
> >   dmaengine: pl330: Remove the burst limit for quirk 'NO-FLUSHP'
> >   dmaengine: pl330: Add quirk 'arm,pl330-periph-burst'
> >   dt-bindings: dma: pl330: Document the quirk 'arm,pl330-periph-burst'
> >   ARM: dts: rk3036: Add 'arm,pl330-periph-burst' for dmac
> >   ARM: dts: rk322x: Add 'arm,pl330-periph-burst' for dmac
> >   ARM: dts: rk3288: Add 'arm,pl330-periph-burst' for dmac
> >   ARM: dts: rk3xxx: Add 'arm,pl330-periph-burst' for dmac
> >   ARM: dts: rv1108: Add 'arm,pl330-periph-burst' for dmac
> >   arm64: dts: px30: Add 'arm,pl330-periph-burst' for dmac
> >   arm64: dts: rk3308: Add 'arm,pl330-periph-burst' for dmac
> >   arm64: dts: rk3328: Add 'arm,pl330-periph-burst' for dmac
> >   arm64: dts: rk3368: Add 'arm,pl330-periph-burst' for dmac
> >   arm64: dts: rk3399: Add 'arm,pl330-periph-burst' for dmac
> >
> >  .../devicetree/bindings/dma/arm-pl330.txt          |  1 +
> >  arch/arm/boot/dts/rk3036.dtsi                      |  1 +
> >  arch/arm/boot/dts/rk322x.dtsi                      |  1 +
> >  arch/arm/boot/dts/rk3288.dtsi                      |  3 ++
> >  arch/arm/boot/dts/rk3xxx.dtsi                      |  3 ++
> >  arch/arm/boot/dts/rv1108.dtsi                      |  1 +
> >  arch/arm64/boot/dts/rockchip/px30.dtsi             |  1 +
> >  arch/arm64/boot/dts/rockchip/rk3308.dtsi           |  2 +
> >  arch/arm64/boot/dts/rockchip/rk3328.dtsi           |  1 +
> >  arch/arm64/boot/dts/rockchip/rk3368.dtsi           |  2 +
> >  arch/arm64/boot/dts/rockchip/rk3399.dtsi           |  2 +
> >  drivers/dma/pl330.c                                | 44 +++++++++++++++-------
> >  12 files changed, 49 insertions(+), 13 deletions(-)
> >
> > --
> > 2.7.4
> >
> >
> >
> >
> > _______________________________________________
> > Linux-rockchip mailing list
> > Linux-rockchip@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2 0/13] Patches to improve transfer efficiency for Rockchip SoCs.
  2020-06-12  1:15   ` Peter Geis
@ 2020-06-12  8:58     ` sugar zhang
  0 siblings, 0 replies; 16+ messages in thread
From: sugar zhang @ 2020-06-12  8:58 UTC (permalink / raw)
  To: Peter Geis
  Cc: Vinod Koul, Heiko Stuebner, devicetree, Carlos de Paula,
	dmaengine, Jonas Karlman, Daniel Lezcano, linux-kernel,
	open list:ARM/Rockchip SoC..., Chen-Yu Tsai, Rob Herring,
	linux-arm-kernel, Miquel Raynal, Enric Balletbo i Serra, Andy Yan,
	Johan Jonker, Robin Murphy, Dan Williams, Leonidas P. Papadakos

Hi Peter,

Thanks for testing! but, as I know, GMAC does not use the general 
dma(pl330) for data transfer,

so, these patchs should not be helpful for your case.

在 2020/6/12 9:15, Peter Geis 写道:
> On Thu, Jun 11, 2020 at 9:06 PM Peter Geis <pgwipeout@gmail.com> wrote:
>> Good Evening,
>>
>> I am currently testing this on the rk3399-rockpro64, and it appears to
>> fully fix the gmac problem without using txpbl.
>> PCIe also seems to be more stable at high load.
>> I need to conduct long term testing, but it seems to be doing very well.
> Belay that, it does make it harder to trigger, but the issue still
> remains on the rk3399.
>
>> Unfortunately it doesn't fix the rk3328 gmac controller.
>>
>> Tested-by: Peter Geis <pgwipeout@gmail.com>
>>
>> On Mon, Jun 8, 2020 at 9:15 PM Sugar Zhang <sugar.zhang@rock-chips.com> wrote:
>>>
>>>
>>> Changes in v2:
>>> - fix FATAL ERROR: Unable to parse input tree
>>>
>>> Sugar Zhang (13):
>>>    dmaengine: pl330: Remove the burst limit for quirk 'NO-FLUSHP'
>>>    dmaengine: pl330: Add quirk 'arm,pl330-periph-burst'
>>>    dt-bindings: dma: pl330: Document the quirk 'arm,pl330-periph-burst'
>>>    ARM: dts: rk3036: Add 'arm,pl330-periph-burst' for dmac
>>>    ARM: dts: rk322x: Add 'arm,pl330-periph-burst' for dmac
>>>    ARM: dts: rk3288: Add 'arm,pl330-periph-burst' for dmac
>>>    ARM: dts: rk3xxx: Add 'arm,pl330-periph-burst' for dmac
>>>    ARM: dts: rv1108: Add 'arm,pl330-periph-burst' for dmac
>>>    arm64: dts: px30: Add 'arm,pl330-periph-burst' for dmac
>>>    arm64: dts: rk3308: Add 'arm,pl330-periph-burst' for dmac
>>>    arm64: dts: rk3328: Add 'arm,pl330-periph-burst' for dmac
>>>    arm64: dts: rk3368: Add 'arm,pl330-periph-burst' for dmac
>>>    arm64: dts: rk3399: Add 'arm,pl330-periph-burst' for dmac
>>>
>>>   .../devicetree/bindings/dma/arm-pl330.txt          |  1 +
>>>   arch/arm/boot/dts/rk3036.dtsi                      |  1 +
>>>   arch/arm/boot/dts/rk322x.dtsi                      |  1 +
>>>   arch/arm/boot/dts/rk3288.dtsi                      |  3 ++
>>>   arch/arm/boot/dts/rk3xxx.dtsi                      |  3 ++
>>>   arch/arm/boot/dts/rv1108.dtsi                      |  1 +
>>>   arch/arm64/boot/dts/rockchip/px30.dtsi             |  1 +
>>>   arch/arm64/boot/dts/rockchip/rk3308.dtsi           |  2 +
>>>   arch/arm64/boot/dts/rockchip/rk3328.dtsi           |  1 +
>>>   arch/arm64/boot/dts/rockchip/rk3368.dtsi           |  2 +
>>>   arch/arm64/boot/dts/rockchip/rk3399.dtsi           |  2 +
>>>   drivers/dma/pl330.c                                | 44 +++++++++++++++-------
>>>   12 files changed, 49 insertions(+), 13 deletions(-)
>>>
>>> --
>>> 2.7.4
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> Linux-rockchip mailing list
>>> Linux-rockchip@lists.infradead.org
>>> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
-- 
Best Regards!
张学广/Sugar
福州瑞芯微电子股份有限公司
Fuzhou Rockchip Electronics Co.Ltd




^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2 03/13] dt-bindings: dma: pl330: Document the quirk 'arm,pl330-periph-burst'
  2020-06-09  1:14 ` [PATCH v2 03/13] dt-bindings: dma: pl330: Document the quirk 'arm,pl330-periph-burst' Sugar Zhang
@ 2020-06-17 20:58   ` Rob Herring
  0 siblings, 0 replies; 16+ messages in thread
From: Rob Herring @ 2020-06-17 20:58 UTC (permalink / raw)
  To: Sugar Zhang
  Cc: devicetree, Heiko Stuebner, linux-kernel, Vinod Koul,
	linux-rockchip, Rob Herring, dmaengine

On Tue, 09 Jun 2020 09:14:17 +0800, Sugar Zhang wrote:
> This patch Adds the quirk 'arm,pl330-periph-burst' for pl330.
> 
> Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>
> ---
> 
> Changes in v2: None
> 
>  Documentation/devicetree/bindings/dma/arm-pl330.txt | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2020-06-17 20:58 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-09  1:14 [PATCH v2 0/13] Patches to improve transfer efficiency for Rockchip SoCs Sugar Zhang
2020-06-09  1:14 ` [PATCH v2 03/13] dt-bindings: dma: pl330: Document the quirk 'arm,pl330-periph-burst' Sugar Zhang
2020-06-17 20:58   ` Rob Herring
2020-06-09  1:14 ` [PATCH v2 04/13] ARM: dts: rk3036: Add 'arm,pl330-periph-burst' for dmac Sugar Zhang
2020-06-09  1:20 ` [PATCH v2 05/13] ARM: dts: rk322x: " Sugar Zhang
2020-06-09  1:20 ` [PATCH v2 06/13] ARM: dts: rk3288: " Sugar Zhang
2020-06-09  1:20 ` [PATCH v2 07/13] ARM: dts: rk3xxx: " Sugar Zhang
2020-06-09  1:20 ` [PATCH v2 08/13] ARM: dts: rv1108: " Sugar Zhang
2020-06-09  1:20 ` [PATCH v2 09/13] arm64: dts: px30: " Sugar Zhang
2020-06-09  1:22 ` [PATCH v2 10/13] arm64: dts: rk3308: " Sugar Zhang
2020-06-09  1:22 ` [PATCH v2 11/13] arm64: dts: rk3328: " Sugar Zhang
2020-06-09  1:22 ` [PATCH v2 12/13] arm64: dts: rk3368: " Sugar Zhang
2020-06-09  1:22 ` [PATCH v2 13/13] arm64: dts: rk3399: " Sugar Zhang
2020-06-12  1:06 ` [PATCH v2 0/13] Patches to improve transfer efficiency for Rockchip SoCs Peter Geis
2020-06-12  1:15   ` Peter Geis
2020-06-12  8:58     ` sugar zhang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).