From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC244C433DF for ; Wed, 17 Jun 2020 21:34:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C94232184D for ; Wed, 17 Jun 2020 21:34:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726909AbgFQVer (ORCPT ); Wed, 17 Jun 2020 17:34:47 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:54827 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726763AbgFQVer (ORCPT ); Wed, 17 Jun 2020 17:34:47 -0400 X-Originating-IP: 86.202.110.81 Received: from localhost (lfbn-lyo-1-15-81.w86-202.abo.wanadoo.fr [86.202.110.81]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 90FF2C0003; Wed, 17 Jun 2020 21:34:38 +0000 (UTC) Date: Wed, 17 Jun 2020 23:34:38 +0200 From: Alexandre Belloni To: Codrin Ciubotariu Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, nicolas.ferre@microchip.com, ludovic.desroches@microchip.com, claudiu.beznea@microchip.com Subject: Re: [PATCH 3/3] Revert "ARM: at91/dt: sama5d2 Xplained: add pdmic node" Message-ID: <20200617213438.GF3675@piout.net> References: <20200615095525.43414-1-codrin.ciubotariu@microchip.com> <20200615095525.43414-3-codrin.ciubotariu@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200615095525.43414-3-codrin.ciubotariu@microchip.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, The correct subject line prefix is "ARM: dts: at91:" On 15/06/2020 12:55:25+0300, Codrin Ciubotariu wrote: > There are no PDM microphones on SAMA5D2 Xplained, to exercize the > PDMIC. > > This reverts commit ca6349a8c51f2e3d6f2acdb36431e7d7328261f7. > > Signed-off-by: Codrin Ciubotariu > --- > arch/arm/boot/dts/at91-sama5d2_xplained.dts | 16 ---------------- > 1 file changed, 16 deletions(-) > This patch doesn't apply and I think you'll have to motivate the removal a bit more because this seems like a change of policy to me. > diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts > index 54d96649da77..c0a255bda477 100644 > --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts > +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts > @@ -109,16 +109,6 @@ timer1: timer@1 { > }; > }; > > - pdmic@f8018000 { > - pinctrl-names = "default"; > - pinctrl-0 = <&pinctrl_pdmic_default>; > - atmel,model = "PDMIC @ sama5d2_xplained"; > - atmel,mic-min-freq = <1000000>; > - atmel,mic-max-freq = <3246000>; > - atmel,mic-offset = <0x0>; > - status = "okay"; > - }; > - > uart1: serial@f8020000 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_uart1_default>; > @@ -533,12 +523,6 @@ pinctrl_macb0_phy_irq: macb0_phy_irq { > bias-disable; > }; > > - pinctrl_pdmic_default: pdmic_default { > - pinmux = , > - ; > - bias-disable; > - }; > - > pinctrl_sdmmc0_default: sdmmc0_default { > cmd_data { > pinmux = , > -- > 2.25.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com