From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92C15C433E0 for ; Sat, 20 Jun 2020 11:50:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7180B23B3F for ; Sat, 20 Jun 2020 11:50:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="caO5V8De" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728062AbgFTLuD (ORCPT ); Sat, 20 Jun 2020 07:50:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728028AbgFTLuD (ORCPT ); Sat, 20 Jun 2020 07:50:03 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 747A7C06174E; Sat, 20 Jun 2020 04:50:02 -0700 (PDT) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E5E74552; Sat, 20 Jun 2020 13:49:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1592653798; bh=Yse0xxkqBA9zQB6NsSCfIUQj4zPL9RqWGQSBetYmgs0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=caO5V8De5kZPcWSI3NiTx50Pyd+048IPqlDXioJyxqyW6a9pEgbGV8+AlYIYDJRSy 9W5I1Rd/UvI5MkhlWUbfPmQBPuhybIVAG/MqS72vC/EFTw3OzsdGGpKpaVycEsuSuN TFd87E3I4eFwFqyE77kJr5H8D0e6/N6eaj2z0Eu4= Date: Sat, 20 Jun 2020 14:49:34 +0300 From: Laurent Pinchart To: Sam Ravnborg Cc: Dmitry Osipenko , Thierry Reding , Rob Herring , Frank Rowand , linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v8 7/7] drm/panel-simple: Add missing connector type for some panels Message-ID: <20200620114934.GB5829@pendragon.ideasonboard.com> References: <20200617222703.17080-1-digetx@gmail.com> <20200617222703.17080-8-digetx@gmail.com> <20200620112132.GB16901@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200620112132.GB16901@ravnborg.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Sam and Dmitry, On Sat, Jun 20, 2020 at 01:21:32PM +0200, Sam Ravnborg wrote: > On Thu, Jun 18, 2020 at 01:27:03AM +0300, Dmitry Osipenko wrote: > > The DRM panel bridge core requires connector type to be set up properly, > > otherwise it rejects the panel. The missing connector type problem popped > > up while I was trying to wrap CLAA070WP03XG panel into a DRM bridge in > > order to test whether panel's rotation property work properly using > > panel-simple driver on NVIDIA Tegra30 Nexus 7 tablet device, which uses > > CLAA070WP03XG display panel. > > > > The NVIDIA Tegra DRM driver recently gained DRM bridges support for the > > RGB output and now driver wraps directly-connected panels into DRM bridge. > > Hence all panels should have connector type set properly now, otherwise > > the panel's wrapping fails. > > > > This patch adds missing connector types for the LVDS panels that are found > > on NVIDIA Tegra devices: > > > > 1. AUO B101AW03 > > 2. Chunghwa CLAA070WP03XG > > 3. Chunghwa CLAA101WA01A > > 4. Chunghwa CLAA101WB01 > > 5. EDT ET057090DHU > > 6. Innolux N156BGE L21 > > 7. Samsung LTN101NT05 > > > > Signed-off-by: Dmitry Osipenko > > Very good to have this fixed. > I went ahead and pushed this commit to drm-misc-next as it is really > independent from the rest of the series. > > > --- > > drivers/gpu/drm/panel/panel-simple.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > > index 6764ac630e22..9eb2dbb7bfa6 100644 > > --- a/drivers/gpu/drm/panel/panel-simple.c > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > @@ -687,6 +687,7 @@ static const struct panel_desc auo_b101aw03 = { > > .width = 223, > > .height = 125, > > }, > > + .connector_type = DRM_MODE_CONNECTOR_LVDS, Note that, for LVDS panels, the bus_format field is mandatory. This panel, for instance, according to http://www.vslcd.com/Specification/B101AW03%20V.0.pdf, uses MEDIA_BUS_FMT_RGB666_1X7X3_SPWG (see https://linuxtv.org/downloads/v4l-dvb-apis/userspace-api/v4l/subdev-formats.html#v4l2-mbus-pixelcode). The panels below need to be investigated similarly. > > }; > > > > static const struct display_timing auo_b101ean01_timing = { > > @@ -1340,6 +1341,7 @@ static const struct panel_desc chunghwa_claa070wp03xg = { > > .width = 94, > > .height = 150, > > }, > > + .connector_type = DRM_MODE_CONNECTOR_LVDS, > > }; > > > > static const struct drm_display_mode chunghwa_claa101wa01a_mode = { > > @@ -1362,6 +1364,7 @@ static const struct panel_desc chunghwa_claa101wa01a = { > > .width = 220, > > .height = 120, > > }, > > + .connector_type = DRM_MODE_CONNECTOR_LVDS, > > }; > > > > static const struct drm_display_mode chunghwa_claa101wb01_mode = { > > @@ -1384,6 +1387,7 @@ static const struct panel_desc chunghwa_claa101wb01 = { > > .width = 223, > > .height = 125, > > }, > > + .connector_type = DRM_MODE_CONNECTOR_LVDS, > > }; > > > > static const struct drm_display_mode dataimage_scf0700c48ggu18_mode = { > > @@ -1573,6 +1577,7 @@ static const struct panel_desc edt_et057090dhu = { > > }, > > .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > > .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE, > > + .connector_type = DRM_MODE_CONNECTOR_LVDS, This contradicts .bus_format and .bus_flags that hint that the panel is a DPI panel, not an LVDS panel. According to https://www.lcdtek.co.uk/dwpdf/ET057090DHU-RoHS.pdf, this isn't an LVDS panel. I'm worried enough research hasn't gone into this patch, and I'd prefer reverting it until we check each panel individually. > > }; > > > > static const struct drm_display_mode edt_etm0700g0dh6_mode = { > > @@ -2055,6 +2060,7 @@ static const struct panel_desc innolux_n156bge_l21 = { > > .width = 344, > > .height = 193, > > }, > > + .connector_type = DRM_MODE_CONNECTOR_LVDS, > > }; > > > > static const struct drm_display_mode innolux_p120zdg_bf1_mode = { > > @@ -3001,6 +3007,7 @@ static const struct panel_desc samsung_ltn101nt05 = { > > .width = 223, > > .height = 125, > > }, > > + .connector_type = DRM_MODE_CONNECTOR_LVDS, > > }; > > > > static const struct drm_display_mode samsung_ltn140at29_301_mode = { -- Regards, Laurent Pinchart