From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE879C433E0 for ; Sun, 21 Jun 2020 00:02:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B206024759 for ; Sun, 21 Jun 2020 00:02:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728434AbgFUACc (ORCPT ); Sat, 20 Jun 2020 20:02:32 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:44155 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726932AbgFUACc (ORCPT ); Sat, 20 Jun 2020 20:02:32 -0400 X-Originating-IP: 86.202.110.81 Received: from localhost (lfbn-lyo-1-15-81.w86-202.abo.wanadoo.fr [86.202.110.81]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id A3856FF808; Sun, 21 Jun 2020 00:02:20 +0000 (UTC) Date: Sun, 21 Jun 2020 02:02:20 +0200 From: Alexandre Belloni To: Jonathan =?iso-8859-1?Q?Neusch=E4fer?= Cc: linux-kernel@vger.kernel.org, Lee Jones , Rob Herring , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Alessandro Zummo , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sam Ravnborg , Linus Walleij , Heiko Stuebner , Stephan Gerhold , Lubomir Rintel , Mark Brown , allen , Mauro Carvalho Chehab , "David S. Miller" , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Heiko Stuebner , Josua Mayer , Andreas Kemnade Subject: Re: [RFC PATCH 07/10] dt-bindings: rtc: Add bindings for Netronix embedded controller RTC Message-ID: <20200621000220.GB131826@piout.net> References: <20200620224222.1312520-1-j.neuschaefer@gmx.net> <20200620224222.1312520-6-j.neuschaefer@gmx.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200620224222.1312520-6-j.neuschaefer@gmx.net> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On 21/06/2020 00:42:18+0200, Jonathan Neuschäfer wrote: > The Netronix EC implements an RTC with the following functionality: > > - Calendar-based time keeping with single-second resolution > - Automatic power-on with single-minute resolution > - Alarm at single-second resolution > > This binding only supports timekeeping for now. > > Signed-off-by: Jonathan Neuschäfer > --- > .../bindings/mfd/netronix,ntxec.yaml | 7 +++++ > .../bindings/rtc/netronix,ntxec-rtc.yaml | 27 +++++++++++++++++++ > 2 files changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/netronix,ntxec-rtc.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/netronix,ntxec.yaml b/Documentation/devicetree/bindings/mfd/netronix,ntxec.yaml > index 6562c41c5a9a9..f6a32f46f47bb 100644 > --- a/Documentation/devicetree/bindings/mfd/netronix,ntxec.yaml > +++ b/Documentation/devicetree/bindings/mfd/netronix,ntxec.yaml > @@ -34,6 +34,9 @@ properties: > pwm: > $ref: ../pwm/netronix,ntxec-pwm.yaml > > + rtc: > + $ref: ../rtc/netronix,ntxec-rtc.yaml > + Shouldn't the node simply be documented here? Also, do you really need a compatible string to be able to proe the driver? What are the chances that you'll get a similar EC without an RTC? > required: > - compatible > - reg > @@ -61,6 +64,10 @@ examples: > compatible = "netronix,ntxec-pwm"; > #pwm-cells = <1>; > }; > + > + rtc { > + compatible = "netronix,ntxec-rtc"; > + }; > }; > }; > > diff --git a/Documentation/devicetree/bindings/rtc/netronix,ntxec-rtc.yaml b/Documentation/devicetree/bindings/rtc/netronix,ntxec-rtc.yaml > new file mode 100644 > index 0000000000000..4b301ef7319c8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/netronix,ntxec-rtc.yaml > @@ -0,0 +1,27 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/netronix,ntxec-rtc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: RTC functionality in Netronix embedded controller > + > +maintainers: > + - Jonathan Neuschäfer > + > +description: | > + See also Documentation/devicetree/bindings/mfd/netronix,ntxec.yaml > + > + The Netronix EC contains an RTC, which can be used for time-keeping, alarm, > + and automatic power-on. Note that not all of this functionality is currently > + supported in this binding. > + > +allOf: > + - $ref: "rtc.yaml#" > + > +properties: > + compatible: > + const: netronix,ntxec-rtc > + > +required: > + - compatible > -- > 2.27.0 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com