From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D286C433E3 for ; Mon, 22 Jun 2020 08:12:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D59D20768 for ; Mon, 22 Jun 2020 08:12:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="L8MOP02t" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725917AbgFVIMe (ORCPT ); Mon, 22 Jun 2020 04:12:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726128AbgFVIMb (ORCPT ); Mon, 22 Jun 2020 04:12:31 -0400 Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78F38C061796 for ; Mon, 22 Jun 2020 01:12:30 -0700 (PDT) Received: by mail-ot1-x342.google.com with SMTP id d4so12382461otk.2 for ; Mon, 22 Jun 2020 01:12:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4RpwlAyFnjmq4it4DvV6HICg0Qx2ws7Bbf9XwDlyvNU=; b=L8MOP02tH082ssrMnlQVK6MgCCFguURnrHOyjjmPEn46O6qiMW89ifsdfxtdB5k3Su tBOwlwpzkpqwPU+WuXm1lbyDJ6BvoO5G2yb3IhT7bypKJom7G8RzMQwA4RFhz4o0FciI t3cJSDB8HrSMkY4mo9soGsiG8VJ73joqoDLPrYtOwIxsqndMyZXKdd3vaWWQLODw9HNT dAXQ7Ki58sLJQKkSd+TAdrSpiSbuDyV9SXvr4EzjiHfFGNLkAW4qJkfoTNNMdTWcLz9f YW3YddKGxbnrWmTa62JO21S5kcnlohu6HAUPTCczwwIdoOSVIhBA5ImWnAalwxM0FHxy 4QtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4RpwlAyFnjmq4it4DvV6HICg0Qx2ws7Bbf9XwDlyvNU=; b=cBivP2cgnO31X6uvj7Lez3H36OOlz5FhtBmMMZoPcrCmK0nk5F5O89MBOpMn+cA3qZ 2y5yQiCEeIv25LLxcYlWFL8co08lSD8OhQhyFyYLAEFpVIsvPA4tNhIWONEtdcgw6/Sx nsH03U/Vv3pqyhThn9r5PimbGPxyizgaM3UsTEgc87O2BMniNlKWXnPXQhl1LZ3K6+TX OtxCa4dnPwg6HnaEQ1/ujIaDAxgtV5qCN3L0852GYVJ+za9jtS+E7uuelJnjJ3l1yKnS ULvglw2q8/W5caFs9tNJr9W6ciqA8FdoYMbe/cXJzt4Q5fjB3BTuJz6kCUlWZr1cZ+oo ponA== X-Gm-Message-State: AOAM532WwDknL19N/8dkRTLOT+p4WSkxD201wuAF+DYCbuI2zzOJGKCv YkNlS+B9Sg8cj8JUtwrFDImJIw== X-Google-Smtp-Source: ABdhPJyRltu6da/7EU8mqyL2GmxT6IdSGCN9QFVNL+cZ6aMNKXWOP7pN+tWyS1cGEm2kIWwqmVPAeQ== X-Received: by 2002:a9d:611c:: with SMTP id i28mr12578642otj.361.1592813549698; Mon, 22 Jun 2020 01:12:29 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id g2sm3194522otq.9.2020.06.22.01.12.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2020 01:12:29 -0700 (PDT) Date: Mon, 22 Jun 2020 01:09:43 -0700 From: Bjorn Andersson To: Konrad Dybcio Cc: skrzynka@konradybcio.pl, Andy Gross , Michael Turquette , Stephen Boyd , Rob Herring , Linus Walleij , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v2 5/8] arm64: dts: qcom: pm660(l): Add base dts files Message-ID: <20200622080943.GE2421@builder.lan> References: <20200622075749.21925-1-konradybcio@gmail.com> <20200622075749.21925-6-konradybcio@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200622075749.21925-6-konradybcio@gmail.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon 22 Jun 00:57 PDT 2020, Konrad Dybcio wrote: > Add base DTS files for pm660(l) along with GPIOs, power-on and > rtc nodes. > > Signed-off-by: Konrad Dybcio > --- > arch/arm64/boot/dts/qcom/pm660.dtsi | 60 ++++++++++++++++++++++++++++ > arch/arm64/boot/dts/qcom/pm660l.dtsi | 46 +++++++++++++++++++++ > 2 files changed, 106 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/pm660.dtsi > create mode 100644 arch/arm64/boot/dts/qcom/pm660l.dtsi > > diff --git a/arch/arm64/boot/dts/qcom/pm660.dtsi b/arch/arm64/boot/dts/qcom/pm660.dtsi > new file mode 100644 > index 000000000000..041f45264255 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/pm660.dtsi > @@ -0,0 +1,60 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2020, Konrad Dybcio > + */ > + > +#include > +#include > +#include Please keep things alphabetically sorted. > + > +&spmi_bus { > + > + pmic@0 { > + compatible = "qcom,pm660", "qcom,spmi-pmic"; > + reg = <0x0 SPMI_USID>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + rtc@6000 { > + compatible = "qcom,pm8941-rtc"; > + reg = <0x6000>, <0x6100>; > + reg-names = "rtc", "alarm"; > + interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>; > + }; > + > + pon: pon@800 { > + compatible = "qcom,pm8916-pon"; > + > + reg = <0x800>; > + > + pwrkey { > + compatible = "qcom,pm8941-pwrkey"; > + interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>; > + debounce = <15625>; > + bias-pull-up; > + linux,code = ; > + }; > + > + }; > + > + pm660_gpios: gpios@c000 { > + compatible = "qcom,pm660-gpio"; > + reg = <0xc000>; > + gpio-controller; > + #gpio-cells = <2>; > + interrupts = <0 0xc0 0 IRQ_TYPE_NONE>, The spmi gpio driver now relies on hierarchical irq chips to map its pins to the interrupt controller's. So you shouldn't list the interrupts anymore. But it should be an "interrupt-controller" and you need "gpio-ranges". > + <0 0xc1 0 IRQ_TYPE_NONE>, > + <0 0xc2 0 IRQ_TYPE_NONE>, > + <0 0xc3 0 IRQ_TYPE_NONE>, > + <0 0xc4 0 IRQ_TYPE_NONE>, > + <0 0xc5 0 IRQ_TYPE_NONE>, > + <0 0xc6 0 IRQ_TYPE_NONE>, > + <0 0xc7 0 IRQ_TYPE_NONE>, > + <0 0xc8 0 IRQ_TYPE_NONE>, > + <0 0xc9 0 IRQ_TYPE_NONE>, > + <0 0xca 0 IRQ_TYPE_NONE>, > + <0 0xcb 0 IRQ_TYPE_NONE>, > + <0 0xcc 0 IRQ_TYPE_NONE>; > + }; > + }; > +}; > diff --git a/arch/arm64/boot/dts/qcom/pm660l.dtsi b/arch/arm64/boot/dts/qcom/pm660l.dtsi > new file mode 100644 > index 000000000000..5e0f1a6e3966 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/pm660l.dtsi > @@ -0,0 +1,46 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2020, Konrad Dybcio > + */ > + > +#include > +#include > +#include > + > +&spmi_bus { > + > + pmic@2 { > + compatible = "qcom,pm660l", "qcom,spmi-pmic"; > + reg = <0x2 SPMI_USID>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + pm660l_gpios: gpios@c000 { > + compatible = "qcom,pm660l-gpio", "qcom,spmi-gpio"; > + reg = <0xc000>; > + gpio-controller; > + #gpio-cells = <2>; > + #interrupt-cells = <2>; > + interrupts = <0x2 0xc0 0x0 IRQ_TYPE_NONE>, As above. Regards, Bjorn > + <0x2 0xc1 0x0 IRQ_TYPE_NONE>, > + <0x2 0xc2 0x0 IRQ_TYPE_NONE>, > + <0x2 0xc3 0x0 IRQ_TYPE_NONE>, > + <0x2 0xc4 0x0 IRQ_TYPE_NONE>, > + <0x2 0xc5 0x0 IRQ_TYPE_NONE>, > + <0x2 0xc6 0x0 IRQ_TYPE_NONE>, > + <0x2 0xc7 0x0 IRQ_TYPE_NONE>, > + <0x2 0xc8 0x0 IRQ_TYPE_NONE>, > + <0x2 0xc9 0x0 IRQ_TYPE_NONE>, > + <0x2 0xca 0x0 IRQ_TYPE_NONE>, > + <0x2 0xcb 0x0 IRQ_TYPE_NONE>; > + }; > + }; > + > + pmic@3 { > + compatible = "qcom,pm660l", "qcom,spmi-pmic"; > + reg = <0x3 SPMI_USID>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > +}; > + > -- > 2.27.0 >