From: Tony Lindgren <tony@atomide.com>
To: Drew Fustini <drew@beagleboard.org>
Cc: "Rob Herring" <robh+dt@kernel.org>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Linus Walleij" <linus.walleij@linaro.org>,
"Haojian Zhuang" <haojian.zhuang@linaro.org>,
devicetree@vger.kernel.org,
"Benoît Cousson" <bcousson@baylibre.com>,
"Jason Kridner" <jkridner@beagleboard.org>,
"Robert Nelson" <robertcnelson@gmail.com>
Subject: Re: [PATCH 0/3] pinctrl: single: support #pinctrl-cells = 2
Date: Mon, 22 Jun 2020 09:11:32 -0700 [thread overview]
Message-ID: <20200622161132.GM37466@atomide.com> (raw)
In-Reply-To: <20200618125057.41252-1-drew@beagleboard.org>
* Drew Fustini <drew@beagleboard.org> [200618 05:52]:
> Currently, pinctrl-single only allows #pinctrl-cells = 1.
>
> This series will allow pinctrl-single to also support #pinctrl-cells = 2
>
> If "pinctrl-single,pins" has 3 arguments (offset, conf, mux) then
> pcs_parse_one_pinctrl_entry() does an OR operation on to get the
> value to store in the register.
>
> To take advantage of #pinctrl-cells = 2, the AM33XX_PADCONF macro in
> omap.h is modified to keep pin conf and pin mux values separate.
Hmm to me it looks like the order of the patches is the
wrong way around here. Don't we need to first change
pinctrl-single.c, and then only after that update the
dts? And make sure the pinctrl-single.c change does not
break anything without changing the dts :)
Regards,
Tony
next prev parent reply other threads:[~2020-06-22 16:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 12:50 [PATCH 0/3] pinctrl: single: support #pinctrl-cells = 2 Drew Fustini
2020-06-18 12:50 ` [PATCH 1/3] ARM: dts: change AM33XX_PADCONF macro separate conf and mux Drew Fustini
2020-06-19 0:50 ` kernel test robot
2020-06-18 12:50 ` [PATCH 2/3] ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2 Drew Fustini
2020-06-18 12:50 ` [PATCH 3/3] pinctrl: single: parse #pinctrl-cells = 2 Drew Fustini
2020-06-22 16:11 ` Tony Lindgren [this message]
2020-06-22 16:46 ` [PATCH 0/3] pinctrl: single: support " Drew Fustini
2020-06-22 16:48 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622161132.GM37466@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=drew@beagleboard.org \
--cc=haojian.zhuang@linaro.org \
--cc=jkridner@beagleboard.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robertcnelson@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).