From: Lee Jones <lee.jones@linaro.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] ARM: dts: uniphier: change support card to simple-mfd from simple-bus
Date: Tue, 23 Jun 2020 13:24:13 +0100 [thread overview]
Message-ID: <20200623122413.GA954398@dell> (raw)
In-Reply-To: <20200623114614.792648-4-yamada.masahiro@socionext.com>
On Tue, 23 Jun 2020, Masahiro Yamada wrote:
> 'make ARCH=arm dtbs_check' emits the following warning:
>
> support-card@1,1f00000: $nodename:0: 'support-card@1,1f00000' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
>
> Maybe, simple-mfd could be a better fit for this device.
The two should be equivalent.
What do you mean by "maybe"? Does this squash the warning?
Isn't the issue caused by the ','?
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> arch/arm/boot/dts/uniphier-support-card.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/uniphier-support-card.dtsi b/arch/arm/boot/dts/uniphier-support-card.dtsi
> index 11e46e7de7c5..eedc10cbc6e6 100644
> --- a/arch/arm/boot/dts/uniphier-support-card.dtsi
> +++ b/arch/arm/boot/dts/uniphier-support-card.dtsi
> @@ -10,7 +10,7 @@ &system_bus {
> ranges = <1 0x00000000 0x42000000 0x02000000>;
>
> support_card: support-card@1,1f00000 {
> - compatible = "simple-bus";
> + compatible = "simple-mfd";
> #address-cells = <1>;
> #size-cells = <1>;
> ranges = <0x00000000 1 0x01f00000 0x00100000>;
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-06-23 12:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 11:46 [PATCH 1/4] ARM: dts: uniphier: add interrupts to support card serial Masahiro Yamada
2020-06-23 11:46 ` [PATCH 2/4] arm64: " Masahiro Yamada
2020-06-23 11:46 ` [PATCH 3/4] ARM: dts: uniphier: rename support card serial node to fix schema warning Masahiro Yamada
2020-06-23 11:46 ` [PATCH 4/4] ARM: dts: uniphier: change support card to simple-mfd from simple-bus Masahiro Yamada
2020-06-23 12:24 ` Lee Jones [this message]
2020-06-24 16:29 ` Masahiro Yamada
2020-06-24 18:16 ` Lee Jones
2020-06-25 14:37 ` Masahiro Yamada
2020-06-25 14:57 ` Lee Jones
2020-06-29 1:58 ` Masahiro Yamada
2020-06-29 7:36 ` Lee Jones
2020-06-29 7:43 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623122413.GA954398@dell \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).