From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5727C433E0 for ; Tue, 23 Jun 2020 23:29:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F2E2208A9 for ; Tue, 23 Jun 2020 23:29:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uXmuk7eh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387713AbgFWX3u (ORCPT ); Tue, 23 Jun 2020 19:29:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387596AbgFWX3t (ORCPT ); Tue, 23 Jun 2020 19:29:49 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8062CC061573 for ; Tue, 23 Jun 2020 16:29:49 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id m2so178544pjv.2 for ; Tue, 23 Jun 2020 16:29:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3lh416h2e2kRb2/LsSBkohB356M1N+qOaKq6eORI8us=; b=uXmuk7ehxvRGsVHcL8khoLVr4fOZ234FwxAOIKq0i00gIufVBnljLcwkTf71j03Sws w4Box+7A1mgbNGYRvSnGSba1SBoDmmxbvB8Wp3RQErSOjMHJHffkZhL93sViBBQGgOs/ 7pTWUApqFWxLZ+4pfw96IfZE0YWWR8Jf4ZXqXbYFrwk86ApHfQGr4xO5YG9gxiOAe0ph XJPFllehb17BKtehRI19Vl04GuPoibrzb02ok3K3eIgIgr+vv3wWpkFeIjeTUqzjtZFi 2iZ3qwRQ9vUSbOPiAULPC47O+7DxsfFbnl82x0ePTdu8FJlGJyUs5x3qqooFhSiZYkXG WIuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3lh416h2e2kRb2/LsSBkohB356M1N+qOaKq6eORI8us=; b=gnIp4RID9O/+Ap7DvMMQ+A6m0GRgOtNThJEwkcStU4+ScdrxjIYR6qBbsFTa0JNiZC OkRTzJ/WpDX8VRae8vKBkNHiIrsrnAUP/Cui+3cHOpggpFilqdFsDopy1HTGmff039OI ZZoJJaadDoOLh9zflDlCKd/V/EeMO8V4qgGXwe3vo0GZePUwu/RGe44JzUYWuPDx31pO 7Nq3jEuSa4D6yecszToRNYmoOIHcd2Lhg8S3OZdhEticp04knim2I3d4j8lA57biQknN 2ufD3GVG8PKqq8qrLPVxGQ87VrJi9WuOEHrV6SewEYCBuDulrIPYiJKxPL213lgn7sdo LV9Q== X-Gm-Message-State: AOAM532+isemtc+nRbsQ/MbOjweODRTsHk/UKpfOFTuR2hvAFfrqPhOq g69QtnkhVz3YWNS5p6B6N6P17A== X-Google-Smtp-Source: ABdhPJw3mIyTGvmU4iMJz6YtqydnFmB4TE6mvoU592WVL56jB50WHwDXCBzDiEAPcEzosMiKF6Yt8Q== X-Received: by 2002:a17:90a:4a6:: with SMTP id g35mr25710525pjg.155.1592954988826; Tue, 23 Jun 2020 16:29:48 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id m14sm15058323pgn.83.2020.06.23.16.29.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2020 16:29:48 -0700 (PDT) Date: Tue, 23 Jun 2020 16:27:05 -0700 From: Bjorn Andersson To: Konrad Dybcio Cc: skrzynka@konradybcio.pl, Andy Gross , Rob Herring , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 12/12] arm64: dts: qcom: Add support for Sony Xperia Z5 (SoMC Sumire-RoW) Message-ID: <20200623232705.GR128451@builder.lan> References: <20200623224813.297077-1-konradybcio@gmail.com> <20200623224813.297077-13-konradybcio@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200623224813.297077-13-konradybcio@gmail.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue 23 Jun 15:48 PDT 2020, Konrad Dybcio wrote: > diff --git a/arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-sumire.dts b/arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-sumire.dts > new file mode 100644 > index 000000000000..e70d54ed7325 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-sumire.dts > @@ -0,0 +1,395 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2020, Konrad Dybcio > + */ > + > +/dts-v1/; > + > +#include "msm8994.dtsi" > +#include "pm8994.dtsi" > +#include "pmi8994.dtsi" > +#include > +#include > + > +/ { > + model = "Sony Xperia Z5"; > + compatible = "somc,sumire-row", "qcom,msm8994"; > + /* required for bootloader to select correct board */ > + qcom,msm-id = <0xcf 0x20001>; > + qcom,pmic-id = <0x10009 0x1000a 0x00 0x00>; > + qcom,board-id = <8 0>; > + > + /* Xperia Z5's firmware doesn't support PSCI */ > + /delete-node/ psci; This does worry me... [..] > +&pm8994_regulators { Per earlier patches, please update the way regulators are described. Regards, Bjorn