devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "周琰杰 (Zhou Yanjie)" <zhouyanjie@wanyeetech.com>
Cc: aric.pzqi@ingenic.com, devicetree@vger.kernel.org,
	paul@crapouillou.net, tglx@linutronix.de, robh+dt@kernel.org,
	sernia.zhou@foxmail.com, zhenwenjin@gmail.com,
	daniel.lezcano@linaro.org, dongsheng.qiu@ingenic.com,
	linux-kernel@vger.kernel.org, rick.tyliu@ingenic.com,
	yanfei.li@ingenic.com
Subject: Re: [PATCH v2 1/2] dt-bindings: timer: Add Ingenic X1000 OST bindings.
Date: Mon, 29 Jun 2020 16:02:02 -0600	[thread overview]
Message-ID: <20200629220202.GA3013651@bogus> (raw)
In-Reply-To: <20200625175714.57271-2-zhouyanjie@wanyeetech.com>

On Fri, 26 Jun 2020 01:57:13 +0800, 周琰杰 (Zhou Yanjie) wrote:
> Add the OST bindings for the X10000 SoC from Ingenic.
> 
> Tested-by: 周正 (Zhou Zheng) <sernia.zhou@foxmail.com>
> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> ---
> 
> Notes:
>     v1->v2:
>     No change.
> 
>  .../devicetree/bindings/timer/ingenic,ost.yaml     | 62 ++++++++++++++++++++++
>  include/dt-bindings/clock/ingenic,ost.h            | 12 +++++
>  2 files changed, 74 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/timer/ingenic,ost.yaml
>  create mode 100644 include/dt-bindings/clock/ingenic,ost.h
> 


My bot found errors running 'make dt_binding_check' on your patch:

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/timer/ingenic,ost.example.dt.yaml: timer@12000000: clocks: [[4294967295, 34]] is too short


See https://patchwork.ozlabs.org/patch/1317097

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.


  reply	other threads:[~2020-06-29 22:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25 17:57 [PATCH v2 0/2] Add support for the OST in Ingenic X1000 周琰杰 (Zhou Yanjie)
2020-06-25 17:57 ` [PATCH v2 1/2] dt-bindings: timer: Add Ingenic X1000 OST bindings 周琰杰 (Zhou Yanjie)
2020-06-29 22:02   ` Rob Herring [this message]
2020-06-25 17:57 ` [PATCH v2 2/2] clocksource: Ingenic: Add support for the Ingenic X1000 OST 周琰杰 (Zhou Yanjie)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200629220202.GA3013651@bogus \
    --to=robh@kernel.org \
    --cc=aric.pzqi@ingenic.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dongsheng.qiu@ingenic.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@crapouillou.net \
    --cc=rick.tyliu@ingenic.com \
    --cc=robh+dt@kernel.org \
    --cc=sernia.zhou@foxmail.com \
    --cc=tglx@linutronix.de \
    --cc=yanfei.li@ingenic.com \
    --cc=zhenwenjin@gmail.com \
    --cc=zhouyanjie@wanyeetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).