From: Tao Ren <rentao.bupt@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: robh+dt@kernel.org, balbi@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: usb: aspeed: Remove the leading zeroes
Date: Mon, 29 Jun 2020 16:39:28 -0700 [thread overview]
Message-ID: <20200629233927.GB25245@taoren-ubuntu-R90MNF91> (raw)
In-Reply-To: <20200629214027.16768-1-festevam@gmail.com>
On Mon, Jun 29, 2020 at 06:40:27PM -0300, Fabio Estevam wrote:
> Remove the leading zeroes to fix the following warning seen with
> 'make dt_binding_check':
>
> Documentation/devicetree/bindings/usb/aspeed,usb-vhub.example.dts:37.33-42.23: Warning (unit_address_format): /example-0/usb-vhub@1e6a0000/vhub-strings/string@0409: unit name should not have leading 0s
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Thanks for the fix, Fabio!
Reviewed-by: Tao Ren <rentao.bupt@gmail.com>
> ---
> Documentation/devicetree/bindings/usb/aspeed,usb-vhub.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/aspeed,usb-vhub.yaml b/Documentation/devicetree/bindings/usb/aspeed,usb-vhub.yaml
> index e4e83d3971ac..8b019ac05bbe 100644
> --- a/Documentation/devicetree/bindings/usb/aspeed,usb-vhub.yaml
> +++ b/Documentation/devicetree/bindings/usb/aspeed,usb-vhub.yaml
> @@ -127,8 +127,8 @@ examples:
> #address-cells = <1>;
> #size-cells = <0>;
>
> - string@0409 {
> - reg = <0x0409>;
> + string@409 {
> + reg = <0x409>;
> manufacturer = "ASPEED";
> product = "USB Virtual Hub";
> serial-number = "0000";
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-06-29 23:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 21:40 [PATCH] dt-bindings: usb: aspeed: Remove the leading zeroes Fabio Estevam
2020-06-29 23:39 ` Tao Ren [this message]
2020-06-30 2:03 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629233927.GB25245@taoren-ubuntu-R90MNF91 \
--to=rentao.bupt@gmail.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox