Re: [PATCH v3 1/3] dt-binding: phy: convert ti,omap-usb2 to YAML

Roger Quadros
2020-07-16T07:49:34Z

On 03/07/2020 11:58, Roger Quadros wrote:
> Hi Rob,
>
> On 02/07/2020 23:47, Rob Herring wrote:
>> On Tue, 30 Jun 2020 12:27:27 +0300, Roger Quadros wrote:
>>> Move ti,omap-usb2 to its own YAML schema.
>>>
>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>> ---
>>>   .../devicetree/bindings/phy/ti,omap-usb2.yaml | 69 +++++++++++++++++++
>>>   .../devicetree/bindings/phy/ti-phy.txt        | 37 ----------
>>>   2 files changed, 69 insertions(+), 37 deletions(-)
>>>   create mode 100644 Documentation/devicetree/bindings/phy/ti,omap-usb2.yaml
>>>
>>
>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/ti,omap-usb2.example.dt.yaml: example-0: phy@4100000:reg:0: [0, 68157440, 0, 84] is too long
>>
>
> In my local build in the dt example I see
>
>     phy@4100000:
>       compatible: ["ti,am654-usb2", "ti,omap-usb2"]
>       reg: [[0x0, 0x4100000, 0x0, 0x54]]
>
> And I don't see any errors. I've updated my dt-schema as well.

I'm able to see the issue now. Will fix it and send v4.

>
>>
>> See https://patchwork.ozlabs.org/patch/1319665
>>
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure dt-schema is up to date:
>>
>> pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
>>
>> Please check and re-submit.
>>
>

cheers,
-roger