From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BEADC433E0 for ; Wed, 1 Jul 2020 16:04:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D00D207D0 for ; Wed, 1 Jul 2020 16:04:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732189AbgGAQEW (ORCPT ); Wed, 1 Jul 2020 12:04:22 -0400 Received: from honk.sigxcpu.org ([24.134.29.49]:34572 "EHLO honk.sigxcpu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728534AbgGAQEV (ORCPT ); Wed, 1 Jul 2020 12:04:21 -0400 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id B872FFB03; Wed, 1 Jul 2020 18:04:19 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mCQhS3pQ3pkg; Wed, 1 Jul 2020 18:04:18 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 9117340972; Wed, 1 Jul 2020 18:04:18 +0200 (CEST) Date: Wed, 1 Jul 2020 18:04:18 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Ondrej Jirman Cc: linux-sunxi@googlegroups.com, Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Purism Kernel Team , Rob Herring , Maxime Ripard , Chen-Yu Tsai , Linus Walleij , Icenowy Zheng , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Samuel Holland , Martijn Braam , Luca Weiss , Bhushan Shah Subject: Re: [PATCH v6 10/13] drm/panel: st7703: Enter sleep after display off Message-ID: <20200701160418.GI174356@bogon.m.sigxcpu.org> References: <20200701103126.1512615-1-megous@megous.com> <20200701103126.1512615-11-megous@megous.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200701103126.1512615-11-megous@megous.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On Wed, Jul 01, 2020 at 12:31:23PM +0200, Ondrej Jirman wrote: > The datasheet suggests to issue sleep in after display off > as a part of the panel's shutdown sequence. Out of curiosity: which exact datasheet did you use? Reviewed-by: Guido Günther > > Signed-off-by: Ondrej Jirman > Reviewed-by: Linus Walleij > --- > drivers/gpu/drm/panel/panel-sitronix-st7703.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/drm/panel/panel-sitronix-st7703.c > index 5cd5503f894f..0c4167994d01 100644 > --- a/drivers/gpu/drm/panel/panel-sitronix-st7703.c > +++ b/drivers/gpu/drm/panel/panel-sitronix-st7703.c > @@ -395,8 +395,19 @@ static int st7703_disable(struct drm_panel *panel) > { > struct st7703 *ctx = panel_to_st7703(panel); > struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev); > + int ret; > + > + ret = mipi_dsi_dcs_set_display_off(dsi); > + if (ret < 0) > + DRM_DEV_ERROR(ctx->dev, > + "Failed to turn off the display: %d\n", ret); > > - return mipi_dsi_dcs_set_display_off(dsi); > + ret = mipi_dsi_dcs_enter_sleep_mode(dsi); > + if (ret < 0) > + DRM_DEV_ERROR(ctx->dev, > + "Failed to enter sleep mode: %d\n", ret); > + > + return 0; > } > > static int st7703_unprepare(struct drm_panel *panel) > -- > 2.27.0 >