From: Mark Brown <broonie@kernel.org>
To: Christoph Fritz <chf.fritz@googlemail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: fan53880: Add initial support
Date: Wed, 1 Jul 2020 19:09:13 +0100 [thread overview]
Message-ID: <20200701180913.GA22871@sirena.org.uk> (raw)
In-Reply-To: <20200630185203.22882-2-chf.fritz@googlemail.com>
[-- Attachment #1: Type: text/plain, Size: 2126 bytes --]
On Tue, Jun 30, 2020 at 08:52:02PM +0200, Christoph Fritz wrote:
> This patch adds support for ON Semiconductor FAN53880 regulator.
>
> The FAN53880 is an I2C porgrammable power management IC (PMIC)
> that contains a BUCK (step-down converter), four LDOs (low dropouts)
> and one BOOST (step-up converter). It is designed for mobile power
> applications.
This doesn't build with current code, there are *many* errors in the
form
/mnt/kernel/drivers/regulator/fan53880.c:48:52: error: array type has incomplete element type 'struct regulator_linear_range'
.linear_ranges = (struct regulator_linear_range[]) { \
^
/mnt/kernel/drivers/regulator/fan53880.c:63:2: note: in expansion of macro 'FAN53880_LDO'
FAN53880_LDO(1, "VIN12", 2800000),
^~~~~~~~~~~~
In file included from /mnt/kernel/drivers/regulator/fan53880.c:5:
/mnt/kernel/include/linux/regulator/driver.h:46:2: error: field name not in record or union initializer
.min = _min_uV, \
^
/mnt/kernel/drivers/regulator/fan53880.c:49:9: note: in expansion of macro 'REGULATOR_LINEAR_RANGE'
REGULATOR_LINEAR_RANGE(_default, 0x0, 0x0, 0), \
^~~~~~~~~~~~~~~~~~~~~~
/mnt/kernel/drivers/regulator/fan53880.c:63:2: note: in expansion of macro 'FAN53880_LDO'
FAN53880_LDO(1, "VIN12", 2800000),
^~~~~~~~~~~~
/mnt/kernel/include/linux/regulator/driver.h:46:2: note: (near initialization for '(anonymous)')
.min = _min_uV, \
^
/mnt/kernel/drivers/regulator/fan53880.c:49:9: note: in expansion of macro 'REGULATOR_LINEAR_RANGE'
REGULATOR_LINEAR_RANGE(_default, 0x0, 0x0, 0), \
^~~~~~~~~~~~~~~~~~~~~~
/mnt/kernel/drivers/regulator/fan53880.c:63:2: note: in expansion of macro 'FAN53880_LDO'
FAN53880_LDO(1, "VIN12", 2800000),
^~~~~~~~~~~~
/mnt/kernel/include/linux/regulator/driver.h:47:2: error: field name not in record or union initializer
.min_sel = _min_sel, \
^
most likely due to the conversion introduced in 60ab7f4153b6af46
(regulator: use linear_ranges helper). Please rebase against current
code.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 484 bytes --]
next prev parent reply other threads:[~2020-07-01 18:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 18:52 [PATCH 0/2] regulator: Add FAN53880 support Christoph Fritz
2020-06-30 18:52 ` [PATCH 1/2] regulator: fan53880: Add initial support Christoph Fritz
2020-07-01 18:09 ` Mark Brown [this message]
2020-07-02 21:09 ` Christoph Fritz
2020-06-30 18:52 ` [PATCH 2/2] dt-bindings: regulator: Document bindings for fan53880 Christoph Fritz
2020-07-03 17:04 ` [PATCH 0/2] regulator: Add FAN53880 support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701180913.GA22871@sirena.org.uk \
--to=broonie@kernel.org \
--cc=chf.fritz@googlemail.com \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).