From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: "周琰杰 (Zhou Yanjie)" <zhouyanjie@wanyeetech.com>,
linux-mips@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, "Rob Herring" <robh+dt@kernel.org>,
paul@crapouillou.net, dongsheng.qiu@ingenic.com,
aric.pzqi@ingenic.com, rick.tyliu@ingenic.com,
yanfei.li@ingenic.com, sernia.zhou@foxmail.com,
zhenwenjin@gmail.com
Subject: Re: [PATCH v2 1/1] dt-bindings: MIPS: Document Ingenic SoCs binding.
Date: Thu, 2 Jul 2020 12:12:29 +0200 [thread overview]
Message-ID: <20200702101229.GA9924@alpha.franken.de> (raw)
In-Reply-To: <CAOMZO5CuxzMm+XFX6-mh55mcw5jgf5iYs-ej5NqjCsD6hSnr7Q@mail.gmail.com>
On Mon, Jun 29, 2020 at 04:28:31PM -0300, Fabio Estevam wrote:
> On Fri, Jun 19, 2020 at 9:48 AM Thomas Bogendoerfer
> <tsbogend@alpha.franken.de> wrote:
> >
> > On Wed, Jun 03, 2020 at 02:33:54AM +0800, 周琰杰 (Zhou Yanjie) wrote:
> > > Document the available properties for the SoC root node and the
> > > CPU nodes of the devicetree for the Ingenic XBurst SoCs.
> > >
> > > Tested-by: H. Nikolaus Schaller <hns@goldelico.com>
> > > Tested-by: Paul Boddie <paul@boddie.org.uk>
> > > Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> > > ---
> > >
> > > Notes:
> > > v1->v2:
> > > 1.Remove unnecessary "items".
> > > 2.Add "clocks" as suggested by Paul Cercueil.
> > >
> > > .../bindings/mips/ingenic/ingenic,cpu.yaml | 67 ++++++++++++++++++++++
> > > 1 file changed, 67 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.yaml
> >
> > applied to mips-next.
>
> This causes 'make dt_binding_check' to fail:
>
> $ make dt_binding_check
> CHKDT Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.yaml
> Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.yaml:
> while scanning a block scalar
> in "<unicode string>", line 42, column 5
> found a tab character where an indentation space is expected
> in "<unicode string>", line 46, column 1
> Documentation/devicetree/bindings/Makefile:20: recipe for target
> 'Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.example.dts'
> failed
> make[1]: *** [Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.example.dts]
> Error 1
> Makefile:1343: recipe for target 'dt_binding_check' failed
> make: *** [dt_binding_check] Error 2
thank you for noticing. It's my fault, I've changed spaces into tabs while
applying, which is of course wrong for yaml files... I've commited a fix
for this to mips-next and 'make dt_binding_check' now passes for me.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2020-07-02 10:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 18:33 [PATCH v2 0/1] Document Ingenic SoCs binding 周琰杰 (Zhou Yanjie)
2020-06-02 18:33 ` [PATCH v2 1/1] dt-bindings: MIPS: " 周琰杰 (Zhou Yanjie)
2020-06-10 19:50 ` Rob Herring
2020-06-19 11:05 ` Thomas Bogendoerfer
2020-06-29 19:28 ` Fabio Estevam
2020-07-02 10:12 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702101229.GA9924@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=aric.pzqi@ingenic.com \
--cc=devicetree@vger.kernel.org \
--cc=dongsheng.qiu@ingenic.com \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=rick.tyliu@ingenic.com \
--cc=robh+dt@kernel.org \
--cc=sernia.zhou@foxmail.com \
--cc=yanfei.li@ingenic.com \
--cc=zhenwenjin@gmail.com \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).