From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DE00C433E1 for ; Fri, 3 Jul 2020 05:12:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0585C20723 for ; Fri, 3 Jul 2020 05:12:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726152AbgGCFMG (ORCPT ); Fri, 3 Jul 2020 01:12:06 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:49266 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725294AbgGCFMG (ORCPT ); Fri, 3 Jul 2020 01:12:06 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 7FE7C80615; Fri, 3 Jul 2020 07:11:57 +0200 (CEST) Date: Fri, 3 Jul 2020 07:11:55 +0200 From: Sam Ravnborg To: =?utf-8?Q?Ond=C5=99ej?= Jirman , Rob Herring , David Airlie , Daniel Vetter , Guido =?iso-8859-1?Q?G=FCnther?= , linux-kernel@vger.kernel.org, Purism Kernel Team , Chen-Yu Tsai , Samuel Holland , devicetree@vger.kernel.org, Bhushan Shah , Thierry Reding , linux-sunxi@googlegroups.com, Luca Weiss , Martijn Braam , Icenowy Zheng , Maxime Ripard , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Linus Walleij , Rob Herring Subject: Re: [PATCH v7 02/13] dt-bindings: panel: Convert rocktech, jh057n00900 to yaml Message-ID: <20200703051155.GA1685118@ravnborg.org> References: <20200701162928.1638874-1-megous@megous.com> <20200701162928.1638874-3-megous@megous.com> <20200702205143.GA1670522@bogus> <20200702210354.562wkzpdmyrlwojx@core.my.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200702210354.562wkzpdmyrlwojx@core.my.home> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=aP3eV41m c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=voM4FWlXAAAA:8 a=YG64nluAAAAA:20 a=b3wYd58VKnsUGY093mYA:9 a=CjuIK1q_8ugA:10 a=IC2XNlieTeVoXbcui8wp:22 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Ondrej. > > My bot found errors running 'make dt_binding_check' on your patch: > > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: '#address-cells', '#size-cells', 'port@0' do not match any of the regexes: 'pinctrl-[0-9]+' > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'vcc-supply' is a required property > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'iovcc-supply' is a required property > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'reset-gpios' is a required property > > Paths look bogus ^^^^ > > It should be .../rocktech,jh057n00900.yaml: ... The example in nwl-dsi.yaml contains: compatible = "rocktech,jh057n00900"; So the example is checked against your updated binding. And the binding check fails because the example is no longer valid. This needs to be fixed as we do not wat to introduce new errors. Either the example or the binding needs the fix. Sam > > regards, > o. > > > > > See https://patchwork.ozlabs.org/patch/1320690 > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure dt-schema is up to date: > > > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > > > Please check and re-submit. > >