From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 934C6C433E1 for ; Fri, 3 Jul 2020 15:06:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73C45208E4 for ; Fri, 3 Jul 2020 15:06:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726098AbgGCPGp (ORCPT ); Fri, 3 Jul 2020 11:06:45 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:49802 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726039AbgGCPGo (ORCPT ); Fri, 3 Jul 2020 11:06:44 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 051642002D; Fri, 3 Jul 2020 17:06:38 +0200 (CEST) Date: Fri, 3 Jul 2020 17:06:37 +0200 From: Sam Ravnborg To: Vinay Simha BN Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , David Airlie , open list , "open list:DRM DRIVERS" , Rob Herring Subject: Re: [PATCH v6 1/2] dt-binding: Add DSI/LVDS TC358775 bridge bindings Message-ID: <20200703150637.GD25632@ravnborg.org> References: <20200702123651.12177-1-simhavcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200702123651.12177-1-simhavcs@gmail.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=pGLkceISAAAA:8 a=gEfo2CItAAAA:8 a=e5mUnYsNAAAA:8 a=0rtKju-ii_ScJ6bGwYQA:9 a=j2Z7r55SUaVgpyYN:21 a=LqFKNBjxuT_MqUgU:21 a=CjuIK1q_8ugA:10 a=sptkURWiP4Gy88Gu7hUp:22 a=Vxmtnl_E_bksehYqCbjh:22 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Vinay. On Thu, Jul 02, 2020 at 06:06:33PM +0530, Vinay Simha BN wrote: > Signed-off-by: Vinay Simha BN > > --- > v1: > Initial version wast .txt file > > v2: > From txt to yaml file format > > v3: > * Andrzej Hajda review comments incorporated > dual port lvds implemented > > * Laurent Pinchart review comments incorporated > dsi lanes property removed and it is dynamically > picked from the dsi ports > VESA/JEIDA format picked from panel-lvds dts > > v4: > * Sam Ravnborg review comments incorporated > }' is indented properly in examples data-lanes > description for single-link and dual-link lvds > --- > .../display/bridge/toshiba,tc358775.yaml | 215 ++++++++++++++++++ > 1 file changed, 215 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml > new file mode 100644 > index 000000000000..9ddd63bee403 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml > @@ -0,0 +1,215 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 One detail that I missed - any specific reason this is not (GPL-2.0-only OR BSD-2-Clause) This is the preferred license for new bindings - as checkpatch also tells you. Sam > +--- > +$id: http://devicetree.org/schemas/display/bridge/toshiba,tc358775.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Toshiba TC358775 DSI to LVDS bridge bindings > + > +maintainers: > + - Vinay Simha BN > + > +description: | > + This binding supports DSI to LVDS bridge TC358775 > + > + MIPI DSI-RX Data 4-lane, CLK 1-lane with data rates up to 800 Mbps/lane. > + Video frame size: > + Up to 1600x1200 24-bit/pixel resolution for single-link LVDS display panel > + limited by 135 MHz LVDS speed > + Up to WUXGA (1920x1200 24-bit pixels) resolution for dual-link LVDS display > + panel, limited by 270 MHz LVDS speed. > + > +properties: > + compatible: > + const: toshiba,tc358775 > + > + reg: > + maxItems: 1 > + description: i2c address of the bridge, 0x0f > + > + vdd-supply: > + maxItems: 1 > + description: 1.2V LVDS Power Supply > + > + vddio-supply: > + maxItems: 1 > + description: 1.8V IO Power Supply > + > + stby-gpios: > + maxItems: 1 > + description: Standby pin, Low active > + > + reset-gpios: > + maxItems: 1 > + description: Hardware reset, Low active > + > + ports: > + type: object > + description: > + A node containing input and output port nodes with endpoint definitions > + as documented in > + Documentation/devicetree/bindings/media/video-interfaces.txt > + properties: > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + port@0: > + type: object > + description: | > + DSI Input. The remote endpoint phandle should be a > + reference to a valid mipi_dsi_host device node. > + > + port@1: > + type: object > + description: | > + Video port for LVDS output (panel or connector). > + > + port@2: > + type: object > + description: | > + Video port for Dual link LVDS output (panel or connector). > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - vdd-supply > + - vddio-supply > + - stby-gpios > + - reset-gpios > + - ports > + > +examples: > + - | > + #include > + > + /* For single-link LVDS display panel */ > + > + i2c@78b8000 { > + /* On High speed expansion */ > + label = "HS-I2C2"; > + reg = <0x078b8000 0x500>; > + clock-frequency = <400000>; /* fastmode operation */ > + #address-cells = <1>; > + #size-cells = <0>; > + > + tc_bridge: bridge@f { > + compatible = "toshiba,tc358775"; > + reg = <0x0f>; > + > + vdd-supply = <&pm8916_l2>; > + vddio-supply = <&pm8916_l6>; > + > + stby-gpios = <&msmgpio 99 GPIO_ACTIVE_LOW>; > + reset-gpios = <&msmgpio 72 GPIO_ACTIVE_LOW>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + d2l_in_test: endpoint { > + remote-endpoint = <&dsi0_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + lvds_out: endpoint { > + remote-endpoint = <&panel_in>; > + }; > + }; > + }; > + }; > + }; > + > + dsi@1a98000 { > + reg = <0x1a98000 0x25c>; > + reg-names = "dsi_ctrl"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@1 { > + reg = <1>; > + dsi0_out: endpoint { > + remote-endpoint = <&d2l_in_test>; > + data-lanes = <0 1 2 3>; > + }; > + }; > + }; > + }; > + > + - | > + /* For dual-link LVDS display panel */ > + > + i2c@78b8000 { > + /* On High speed expansion */ > + label = "HS-I2C2"; > + reg = <0x078b8000 0x500>; > + clock-frequency = <400000>; /* fastmode operation */ > + #address-cells = <1>; > + #size-cells = <0>; > + > + tc_bridge_dual: bridge@f { > + compatible = "toshiba,tc358775"; > + reg = <0x0f>; > + > + vdd-supply = <&pm8916_l2>; > + vddio-supply = <&pm8916_l6>; > + > + stby-gpios = <&msmgpio 99 GPIO_ACTIVE_LOW>; > + reset-gpios = <&msmgpio 72 GPIO_ACTIVE_LOW>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + d2l_in_dual: endpoint { > + remote-endpoint = <&dsi0_out_dual>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + lvds0_out: endpoint { > + remote-endpoint = <&panel_in0>; > + }; > + }; > + > + port@2 { > + reg = <2>; > + lvds1_out: endpoint { > + remote-endpoint = <&panel_in1>; > + }; > + }; > + }; > + }; > + }; > + > + dsi@1a98000 { > + reg = <0x1a98000 0x25c>; > + reg-names = "dsi_ctrl"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@1 { > + reg = <1>; > + dsi0_out_dual: endpoint { > + remote-endpoint = <&d2l_in_dual>; > + data-lanes = <0 1 2 3>; > + }; > + }; > + }; > + }; > +... > -- > 2.17.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel