From: Andrew Lunn <andrew@lunn.ch>
To: vineetha.g.jaya.kumaran@intel.com
Cc: davem@davemloft.net, kuba@kernel.org, mcoquelin.stm32@gmail.com,
robh+dt@kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, weifeng.voon@intel.com,
hock.leong.kweh@intel.com, boon.leong.ong@intel.com
Subject: Re: [PATCH 1/2] dt-bindings: net: Add bindings for Intel Keem Bay
Date: Tue, 7 Jul 2020 15:07:41 +0200 [thread overview]
Message-ID: <20200707130741.GA938746@lunn.ch> (raw)
In-Reply-To: <1594097238-8827-2-git-send-email-vineetha.g.jaya.kumaran@intel.com>
> + mdio0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "snps,dwmac-mdio";
> +
> + ethernet-phy@0 {
> + compatible = "ethernet-phy-id0141.0dd0",
> + "ethernet-phy-ieee802.3-c22";
You only need to provide the phy-id when the PHY is broken and
registers 2 and 3 don't contain a valid ID. And c22 is the default, so
also not needed. The Marvell 88E1510 will work without these
compatible strings.
Andrew
next prev parent reply other threads:[~2020-07-07 13:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 4:47 [PATCH 0/2] Add Ethernet support for Intel Keem Bay SoC vineetha.g.jaya.kumaran
2020-07-07 4:47 ` [PATCH 1/2] dt-bindings: net: Add bindings for Intel Keem Bay vineetha.g.jaya.kumaran
2020-07-07 13:07 ` Andrew Lunn [this message]
2020-07-09 14:40 ` G Jaya Kumaran, Vineetha
2020-07-09 16:45 ` Rob Herring
2020-07-10 11:15 ` G Jaya Kumaran, Vineetha
2020-07-07 4:47 ` [PATCH 2/2] net: stmmac: Add dwmac-intel-plat for GBE driver vineetha.g.jaya.kumaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707130741.GA938746@lunn.ch \
--to=andrew@lunn.ch \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hock.leong.kweh@intel.com \
--cc=kuba@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vineetha.g.jaya.kumaran@intel.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).