From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2841EC433E1 for ; Fri, 10 Jul 2020 09:45:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0FDA8206F4 for ; Fri, 10 Jul 2020 09:45:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727818AbgGJJpO (ORCPT ); Fri, 10 Jul 2020 05:45:14 -0400 Received: from mail.baikalelectronics.com ([87.245.175.226]:49924 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726288AbgGJJpO (ORCPT ); Fri, 10 Jul 2020 05:45:14 -0400 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id C83A8803202B; Fri, 10 Jul 2020 09:45:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H6tr9SV-mKxq; Fri, 10 Jul 2020 12:45:11 +0300 (MSK) Date: Fri, 10 Jul 2020 12:45:10 +0300 From: Serge Semin To: Andy Shevchenko CC: Vinod Koul , Viresh Kumar , Dan Williams , Alexey Malahov , Thomas Bogendoerfer , Arnd Bergmann , Rob Herring , , , , Subject: Re: [PATCH v7 08/11] dmaengine: dw: Add dummy device_caps callback Message-ID: <20200710094510.j6ugxygkadxex53c@mobilestation> References: <20200709224550.15539-1-Sergey.Semin@baikalelectronics.ru> <20200709224550.15539-9-Sergey.Semin@baikalelectronics.ru> <20200710085123.GF3703480@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200710085123.GF3703480@smile.fi.intel.com> X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Jul 10, 2020 at 11:51:23AM +0300, Andy Shevchenko wrote: > On Fri, Jul 10, 2020 at 01:45:47AM +0300, Serge Semin wrote: > > Since some DW DMA controllers (like one installed on Baikal-T1 SoC) may > > have non-uniform DMA capabilities per device channels, let's add > > the DW DMA specific device_caps callback to expose that specifics up to > > the DMA consumer. It's a dummy function for now. We'll fill it in with > > capabilities overrides in the next commits. > > Just a reminder (mainly to Vinod) of my view to this. > Unneeded churn, should be folded to patch 9. Just to remind (mainly to Vinod). That's Andy's bikeshedding. This isn't a churn, since it's totally normal to design the patchset in this way: introduce a callback, then fill it in with functionality. -Sergey > > > Signed-off-by: Serge Semin > > Cc: Alexey Malahov > > Cc: Thomas Bogendoerfer > > Cc: Arnd Bergmann > > Cc: Rob Herring > > Cc: linux-mips@vger.kernel.org > > Cc: devicetree@vger.kernel.org > > > > --- > > > > Changelog v3: > > - This is a new patch created as a result of the discussion with Vinud and > > Andy in the framework of DW DMA burst and LLP capabilities. > > --- > > drivers/dma/dw/core.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/drivers/dma/dw/core.c b/drivers/dma/dw/core.c > > index fb95920c429e..ceded21537e2 100644 > > --- a/drivers/dma/dw/core.c > > +++ b/drivers/dma/dw/core.c > > @@ -1049,6 +1049,11 @@ static void dwc_free_chan_resources(struct dma_chan *chan) > > dev_vdbg(chan2dev(chan), "%s: done\n", __func__); > > } > > > > +static void dwc_caps(struct dma_chan *chan, struct dma_slave_caps *caps) > > +{ > > + > > +} > > + > > int do_dma_probe(struct dw_dma_chip *chip) > > { > > struct dw_dma *dw = chip->dw; > > @@ -1214,6 +1219,7 @@ int do_dma_probe(struct dw_dma_chip *chip) > > dw->dma.device_prep_dma_memcpy = dwc_prep_dma_memcpy; > > dw->dma.device_prep_slave_sg = dwc_prep_slave_sg; > > > > + dw->dma.device_caps = dwc_caps; > > dw->dma.device_config = dwc_config; > > dw->dma.device_pause = dwc_pause; > > dw->dma.device_resume = dwc_resume; > > -- > > 2.26.2 > > > > -- > With Best Regards, > Andy Shevchenko > >