From: Pavel Machek <pavel@ucw.cz>
To: Marek Behun <marek.behun@nic.cz>
Cc: linux-leds@vger.kernel.org, Rob Herring <robh@kernel.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: leds: add cznic,turris-omnia-leds binding
Date: Sun, 12 Jul 2020 10:00:50 +0200 [thread overview]
Message-ID: <20200712080050.GD8295@amd> (raw)
In-Reply-To: <20200511220151.24985832@nic.cz>
[-- Attachment #1: Type: text/plain, Size: 787 bytes --]
Hi!
> > What's the numbering here based on? Might be better to use 'reg' (and a
> > unit-address) rather than led-sources. led-sources was for cases where
> > the control interface (defined by reg) could have differing regulators
> > connected to the LEDs.
>
> Jacek, Pavel, it seems that it would be better if I just rewrote the
> driver into Dan's multicolor API. It would solve Rob's complaint and
> could be merged once multicolor framework is...
It would be great to try that now. Multicolor is now very close to
being merged, and having independend verification that it works would
be great.
Thank you,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2020-07-12 8:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200423065100.2652-1-marek.behun@nic.cz>
2020-04-23 6:50 ` [PATCH v2 1/2] dt-bindings: leds: add cznic,turris-omnia-leds binding Marek Behún
2020-05-11 19:43 ` Rob Herring
2020-05-11 20:01 ` Marek Behun
2020-07-12 8:00 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200712080050.GD8295@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).