From: Jonathan Cameron <jic23@kernel.org>
To: Artur Rojek <contact@artur-rojek.eu>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Paul Cercueil <paul@crapouillou.net>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 3/6] IIO: Ingenic JZ47xx: Add xlate cb to retrieve correct channel idx
Date: Sun, 12 Jul 2020 13:05:17 +0100 [thread overview]
Message-ID: <20200712130517.397fd668@archlinux> (raw)
In-Reply-To: <20200709152200.10039-4-contact@artur-rojek.eu>
On Thu, 9 Jul 2020 17:21:57 +0200
Artur Rojek <contact@artur-rojek.eu> wrote:
> Provide an of_xlate callback in order to retrieve the correct channel
> specifier index from the IIO channels array.
>
> Signed-off-by: Artur Rojek <contact@artur-rojek.eu>
> Tested-by: Paul Cercueil <paul@crapouillou.net>
Applied. Thanks,
Jonathan
> ---
>
> Changes:
>
> v2-v8: no change
>
> drivers/iio/adc/ingenic-adc.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/iio/adc/ingenic-adc.c b/drivers/iio/adc/ingenic-adc.c
> index c1946a9f1cca..89019fb59d48 100644
> --- a/drivers/iio/adc/ingenic-adc.c
> +++ b/drivers/iio/adc/ingenic-adc.c
> @@ -400,6 +400,21 @@ static int ingenic_adc_read_raw(struct iio_dev *iio_dev,
> }
> }
>
> +static int ingenic_adc_of_xlate(struct iio_dev *iio_dev,
> + const struct of_phandle_args *iiospec)
> +{
> + int i;
> +
> + if (!iiospec->args_count)
> + return -EINVAL;
> +
> + for (i = 0; i < iio_dev->num_channels; ++i)
> + if (iio_dev->channels[i].channel == iiospec->args[0])
> + return i;
> +
> + return -EINVAL;
> +}
> +
> static void ingenic_adc_clk_cleanup(void *data)
> {
> clk_unprepare(data);
> @@ -409,6 +424,7 @@ static const struct iio_info ingenic_adc_info = {
> .write_raw = ingenic_adc_write_raw,
> .read_raw = ingenic_adc_read_raw,
> .read_avail = ingenic_adc_read_avail,
> + .of_xlate = ingenic_adc_of_xlate,
> };
>
> static const struct iio_chan_spec ingenic_channels[] = {
next prev parent reply other threads:[~2020-07-12 12:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 15:21 [PATCH v8 0/6] iio/adc: ingenic: Cleanups & add touchscreen mode Artur Rojek
2020-07-09 15:21 ` [PATCH v8 1/6] dt-bindings: iio/adc: Convert ingenic-adc docs to YAML Artur Rojek
2020-07-12 11:22 ` Jonathan Cameron
2020-07-09 15:21 ` [PATCH v8 2/6] IIO: Ingenic JZ47xx: Error check clk_enable calls Artur Rojek
2020-07-12 12:02 ` Jonathan Cameron
2020-07-13 5:07 ` Ardelean, Alexandru
2020-07-13 11:20 ` Jonathan Cameron
2020-07-09 15:21 ` [PATCH v8 3/6] IIO: Ingenic JZ47xx: Add xlate cb to retrieve correct channel idx Artur Rojek
2020-07-12 12:05 ` Jonathan Cameron [this message]
2020-07-09 15:21 ` [PATCH v8 4/6] iio/adc: ingenic: Retrieve channels list from soc data struct Artur Rojek
2020-07-12 12:07 ` Jonathan Cameron
2020-07-12 12:11 ` Jonathan Cameron
2020-07-12 19:53 ` Artur Rojek
2020-07-09 15:21 ` [PATCH v8 5/6] dt-bindings: iio/adc: Add touchscreen idx for JZ47xx SoC ADC Artur Rojek
2020-07-09 20:24 ` Rob Herring
2020-07-09 15:22 ` [PATCH v8 6/6] IIO: Ingenic JZ47xx: Add touchscreen mode Artur Rojek
2020-07-12 13:19 ` Jonathan Cameron
2020-07-12 20:16 ` Paul Cercueil
2020-07-20 11:49 ` Jonathan Cameron
2020-07-09 15:43 ` [PATCH v8 0/6] iio/adc: ingenic: Cleanups & add " Andy Shevchenko
2020-07-09 16:05 ` Artur Rojek
2020-07-09 16:42 ` Andy Shevchenko
2020-07-14 18:33 ` Heiko Stuebner
2020-07-19 22:16 ` Artur Rojek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200712130517.397fd668@archlinux \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=contact@artur-rojek.eu \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=heiko@sntech.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).