* [PATCH v2] ARM: dts: vf610-zii-dev-rev-c: Configure fiber port to 1000BaseX
@ 2020-07-08 23:25 Chris Healy
2020-07-09 0:11 ` Fabio Estevam
2020-07-13 8:23 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Chris Healy @ 2020-07-08 23:25 UTC (permalink / raw)
To: festevam, andrew, shawnguo, s.hauer, stefan, robh+dt,
linux-arm-kernel, devicetree, linux-kernel
Cc: Chris Healy
The SFF soldered onto the board expects the port to use 1000BaseX. It
makes no sense to have the port set to SGMII, since it doesn't even
support that mode.
Signed-off-by: Chris Healy <cphealy@gmail.com>
---
v2:
- convert spaces back to tabs
- remove .dts from subject line
arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
index 778e02c000d1..de79dcfd32e6 100644
--- a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
+++ b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
@@ -164,7 +164,7 @@
port@9 {
reg = <9>;
label = "sff2";
- phy-mode = "sgmii";
+ phy-mode = "1000base-x";
managed = "in-band-status";
sfp = <&sff2>;
};
--
2.21.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] ARM: dts: vf610-zii-dev-rev-c: Configure fiber port to 1000BaseX
2020-07-08 23:25 [PATCH v2] ARM: dts: vf610-zii-dev-rev-c: Configure fiber port to 1000BaseX Chris Healy
@ 2020-07-09 0:11 ` Fabio Estevam
2020-07-13 8:23 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2020-07-09 0:11 UTC (permalink / raw)
To: Chris Healy
Cc: Andrew Lunn, Shawn Guo, Sascha Hauer, Stefan Agner, Rob Herring,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel
On Wed, Jul 8, 2020 at 8:25 PM Chris Healy <cphealy@gmail.com> wrote:
>
> The SFF soldered onto the board expects the port to use 1000BaseX. It
> makes no sense to have the port set to SGMII, since it doesn't even
> support that mode.
>
> Signed-off-by: Chris Healy <cphealy@gmail.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ARM: dts: vf610-zii-dev-rev-c: Configure fiber port to 1000BaseX
2020-07-08 23:25 [PATCH v2] ARM: dts: vf610-zii-dev-rev-c: Configure fiber port to 1000BaseX Chris Healy
2020-07-09 0:11 ` Fabio Estevam
@ 2020-07-13 8:23 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2020-07-13 8:23 UTC (permalink / raw)
To: Chris Healy
Cc: festevam, andrew, s.hauer, stefan, robh+dt, linux-arm-kernel,
devicetree, linux-kernel
On Wed, Jul 08, 2020 at 04:25:01PM -0700, Chris Healy wrote:
> The SFF soldered onto the board expects the port to use 1000BaseX. It
> makes no sense to have the port set to SGMII, since it doesn't even
> support that mode.
>
> Signed-off-by: Chris Healy <cphealy@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-13 8:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-08 23:25 [PATCH v2] ARM: dts: vf610-zii-dev-rev-c: Configure fiber port to 1000BaseX Chris Healy
2020-07-09 0:11 ` Fabio Estevam
2020-07-13 8:23 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).