From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA191C433DF for ; Tue, 14 Jul 2020 02:30:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F783207BB for ; Tue, 14 Jul 2020 02:30:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594693853; bh=/hS33VdzsRLPV6IWYMz6RL4rg+LZtzUiUyPbAEDJ0TM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=qcHIAMZnCNWwbSPPXmvygMLvCs3K/4Z30faJuDE0eSQr3z+9rvvmoYTczq8l+6aBY gd4ugUYSu6jIuPcYe3ulrDy267CVPSuSPgoWeuKPK3F6OKH25/eTHoTfVkT5G0OBMp lUL0+ToJnedkXcKlu7M3EMclzcjjrFV1FFO4cIpQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726456AbgGNCax (ORCPT ); Mon, 13 Jul 2020 22:30:53 -0400 Received: from mail-il1-f195.google.com ([209.85.166.195]:43643 "EHLO mail-il1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726150AbgGNCax (ORCPT ); Mon, 13 Jul 2020 22:30:53 -0400 Received: by mail-il1-f195.google.com with SMTP id i18so13002043ilk.10; Mon, 13 Jul 2020 19:30:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PIQmxPiwEmBfrqbUBFZETE9PAgGB7RmQQ0RmEk0XV2o=; b=RYoG1x2+pv8cg4uWfokhXlJ0T0F6iOIjGOcUkZfgkpxYgbDBzAu5pdZ2I+9jBMJTWo H/sESeoDp/huWygzfpKNeCKf4DmyHxkT2O7MPicDBYKlMefCEq0rZVygncdqnwmIdF52 eA4GhGiqTFLO5FBxasW0KLs237Q2B/xhga3GwRBE1t3kBAv8/NbsZGc6PPogJmJEUvpY GxVXAilFM+gYENctPXiGZGwvNc55PiA0Bb7xHjPhfax6moK9Zn1Utbx8xV0N56lwmPbA I8INyFu6k6Zf39B7qmuuOAIErX6RhlzPpgIdIM5p4wV4DC0KTcuXolnvmEDfjAx8opCc Mp3g== X-Gm-Message-State: AOAM533xx3RNSDE5t9q2B7JEVVw/bJv+vs1qwsh/Ot/ZFrUSn/rjZYcN U0eUOy5W8/imiwkrstbvEg== X-Google-Smtp-Source: ABdhPJxXsnuwtyRrz+snuTSfJAc/5Y1nlNxsR/FuJxzhcyWKWH7prPgt9D2+OmHoYyG5esy2UjixSg== X-Received: by 2002:a05:6e02:f85:: with SMTP id v5mr2688806ilo.31.1594693851894; Mon, 13 Jul 2020 19:30:51 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id b2sm9386188ilf.0.2020.07.13.19.30.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 19:30:51 -0700 (PDT) Received: (nullmailer pid 1161968 invoked by uid 1000); Tue, 14 Jul 2020 02:30:48 -0000 Date: Mon, 13 Jul 2020 20:30:48 -0600 From: Rob Herring To: Wolfram Sang Cc: Alain Volmat , mark.rutland@arm.com, pierre-yves.mordret@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, fabrice.gasnier@st.com Subject: Re: [PATCH v2 3/4] dt-bindings: i2c-stm32: add SMBus Alert bindings Message-ID: <20200714023048.GA1151665@bogus> References: <1593070769-9106-1-git-send-email-alain.volmat@st.com> <1593070769-9106-4-git-send-email-alain.volmat@st.com> <20200630194107.GA999@ninjato> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200630194107.GA999@ninjato> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Jun 30, 2020 at 09:41:07PM +0200, Wolfram Sang wrote: > On Thu, Jun 25, 2020 at 09:39:28AM +0200, Alain Volmat wrote: > > Add a new binding of the i2c-stm32f7 driver to enable the handling > > of the SMBUS-Alert. > > > > The I2C/SMBUS framework already provides a mechanism to enable SMBus-Alert > > by naming an IRQ line "smbus_alert". However, on stm32, the SMBus-Alert is > > part of the i2c IRQ. Using the smbus_alert naming here would lead to having > > 2 handlers (the handler of the driver and the smbus_alert handler > > from I2C/SMBUS framework) on the unique i2c IRQ of the stm32. Meaning that > > the smbus_alert handler would get called for all IRQ generated by the stm32 > > I2C controller. > > > > For that reason, the smbus_alert IRQ naming cannot be used and a dedicated > > binding is introduced. > > What if we update the core to not register another irq handler if the > "smbus_alert" and main irq are the same? > > I think it could work. However, while trying to make a proof-of-concept, > I found that irq descriptions in the generic i2c binding document are > probably mixed up. And before fixing that, I'd like to get HostNotify > done first. Why does this even need to be in DT? Can't the driver just register that it supports SMBus alert or have some call to the core signaling an SMBus alert? Rob