From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA3E5C433E6 for ; Wed, 15 Jul 2020 14:14:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4FA3206E9 for ; Wed, 15 Jul 2020 14:14:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728003AbgGOOOH (ORCPT ); Wed, 15 Jul 2020 10:14:07 -0400 Received: from pi.codeconstruct.com.au ([103.231.89.101]:35654 "EHLO codeconstruct.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726720AbgGOOOG (ORCPT ); Wed, 15 Jul 2020 10:14:06 -0400 X-Greylist: delayed 452 seconds by postgrey-1.27 at vger.kernel.org; Wed, 15 Jul 2020 10:14:04 EDT Received: by codeconstruct.com.au (Postfix, from userid 20001) id A1AB340172; Wed, 15 Jul 2020 10:06:30 -0400 (EDT) From: Jeremy Kerr To: linux-gpio@vger.kernel.org, linux-aspeed@lists.ozlabs.org, devicetree@vger.kernel.org Cc: Joel Stanley , Andrew Jeffery Subject: [PATCH 2/2] gpio/aspeed-sgpio: don't enable all interrupts by default Date: Wed, 15 Jul 2020 21:54:18 +0800 Message-Id: <20200715135418.3194860-2-jk@codeconstruct.com.au> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200715135418.3194860-1-jk@codeconstruct.com.au> References: <20200715135418.3194860-1-jk@codeconstruct.com.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Currently, the IRQ setup for the SGPIO driver enables all interrupts for dual-edge trigger mode. Since the default handler is handle_bad_irq, any state change on input GPIOs will trigger bad IRQ warnings. This change applies sensible (disabled) IRQ defaults. Signed-off-by: Jeremy Kerr --- drivers/gpio/gpio-aspeed-sgpio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-aspeed-sgpio.c b/drivers/gpio/gpio-aspeed-sgpio.c index 927d46f159b8..23a3a40901d6 100644 --- a/drivers/gpio/gpio-aspeed-sgpio.c +++ b/drivers/gpio/gpio-aspeed-sgpio.c @@ -451,9 +451,7 @@ static int aspeed_sgpio_setup_irqs(struct aspeed_sgpio *gpio, /* trigger type is edge */ iowrite32(0x00000000, bank_reg(gpio, bank, reg_irq_type1)); /* dual edge trigger mode. */ - iowrite32(0xffffffff, bank_reg(gpio, bank, reg_irq_type2)); - /* enable irq */ - iowrite32(0xffffffff, bank_reg(gpio, bank, reg_irq_enable)); + iowrite32(0x00000000, bank_reg(gpio, bank, reg_irq_type2)); } return 0; -- 2.27.0