From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FFF2C433E6 for ; Wed, 15 Jul 2020 20:06:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A27820663 for ; Wed, 15 Jul 2020 20:06:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594843605; bh=9W6vSYp92NRVcJCh9FKa27oMzyrh00zpAVYb4mIPK+A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=x7uHISpc3noyqFPaSG73r+MvgeNWjNawV2+4Et+gAeLytDokvUmWY1Mj1MmRCL4p5 IJyWr/0d2H2WRZpXO68NAKp9+gTCyCG6bBtOl0fuiOOEW16uPe/4exT0lyN58HUBBq 8Uz4SlZlUTpnyMUS6h4tkG3lIsWgQcq9NsLYCNTk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726878AbgGOUGo (ORCPT ); Wed, 15 Jul 2020 16:06:44 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:40123 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726858AbgGOUGo (ORCPT ); Wed, 15 Jul 2020 16:06:44 -0400 Received: by mail-io1-f68.google.com with SMTP id l17so3596878iok.7; Wed, 15 Jul 2020 13:06:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cpHgt95lxQHT5Zpu11pSPfByIAbS3Y8PM2+zGuMvPf4=; b=Of9OvNvuJxei8uTA5JXZ9uAn3NPce9/B/kDyJS1v3/yWtcIa1CzomBOWeC9xBojUdE diJsaqFz+Rudum5zGOMAvJu9IH3mbNwEGubsBxgLT/xf7vZZwAsAiTuqFvM5f3kkne/4 GxMO+8Gob/cJ6Axf2y2pQELcFzYJX7KcxlOo2gGeQ0dV3iZu+JuEjLqPPIq0vhkZ4fiG /mQBAXB5jZOHVl8xLboT1VnPZmhujjrPmESpQVZfjZYLTdgMQW7Vu4vdh2JpLpUAfmYp BJrBY2guVACh0LBKcPmfR9q5BdXzqczQdDOutqiFNwcOnbStp8K77/W5pY95EOEHWByT s05Q== X-Gm-Message-State: AOAM531weLA4YQUhRdJ5A4TKDyA/R1fNcWsf20MI3vX8W6mGE/brprBl ttYJme4kYyzik4e8QA//tA== X-Google-Smtp-Source: ABdhPJzTqc0usjbSP/XwBpuP5jwxFaTQOXK6S9rjAZx6oYxlBd6iuUMXJPDTaUqiQq5nLvvMyIBD2g== X-Received: by 2002:a02:1c02:: with SMTP id c2mr1168973jac.102.1594843603060; Wed, 15 Jul 2020 13:06:43 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id l17sm1507537ilm.70.2020.07.15.13.06.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 13:06:42 -0700 (PDT) Received: (nullmailer pid 735110 invoked by uid 1000); Wed, 15 Jul 2020 20:06:41 -0000 Date: Wed, 15 Jul 2020 14:06:41 -0600 From: Rob Herring To: Maxime Ripard Cc: Nicolas Saenz Julienne , Mike Turquette , Stephen Boyd , linux-rpi-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-clk@vger.kernel.org, Mark Rutland , Frank Rowand , devicetree@vger.kernel.org, Florian Fainelli Subject: Re: [PATCH] dt-bindings: arm: bcm: Add a select to the RPI Firmware binding Message-ID: <20200715200641.GA732316@bogus> References: <20200626115433.125735-1-maxime@cerno.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200626115433.125735-1-maxime@cerno.tech> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Jun 26, 2020 at 01:54:33PM +0200, Maxime Ripard wrote: > The RaspberryPi firmware binding uses two compatible, include simple-bus. > The select statement generated by default will thus select any node that > has simple-bus, not all of them being the raspberrypi firmware node. > > This results in warnings being wrongfully reported. Let's add a custom > select statement to fix that. > > Fixes: 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML") > Signed-off-by: Maxime Ripard > > --- > > The original binding has been merged through the clock tree, so it should > be merged there. > > Even though the original binding (and the DT) are using the simple-bus > compatible, this creates some DTC warnings since the firmware really isn't > a bus, so the node name doesn't match what a bus should have, none of the > children have a reg property, #address-cells and #size-cells are missing, > etc. > > I can only guess that simple-bus was used to make the sub-devices probe, > but maybe simple-mfd would be more appropriate here? As these are not mmio devices, I think simple-mfd is better. > --- > .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml > index b48ed875eb8e..17e4f20c8d39 100644 > --- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml > +++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml > @@ -10,6 +10,15 @@ maintainers: > - Eric Anholt > - Stefan Wahren > > +select: > + properties: > + compatible: > + contains: > + const: raspberrypi,bcm2835-firmware > + > + required: > + - compatible > + > properties: > compatible: > items: > -- > 2.26.2 >