From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
Cc: linux-arm-kernel@lists.infradead.org,
Lee Jones <lee.jones@linaro.org>,
Furquan Shaikh <furquan@chromium.org>,
Raul E Rangel <rrangel@chromium.org>,
Eric Peers <epeers@google.com>,
Duncan Laurie <dlaurie@google.com>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] platform/chrome: cros_ec_uart: Add cros-ec-uart transport layer
Date: Thu, 16 Jul 2020 08:29:36 +0200 [thread overview]
Message-ID: <20200716062936.GB958325@kroah.com> (raw)
In-Reply-To: <20200716062807.GA958325@kroah.com>
On Thu, Jul 16, 2020 at 08:28:07AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 15, 2020 at 10:14:29PM -0700, Bhanu Prakash Maiya wrote:
> > From: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
> >
> > This patch enables uart transport layer for cros_ec framework.
> > The cros-ec-uart binds with EC device working on uart transport to
> > send request and receive response.
> >
> > Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
>
> If this really is a "UART", why is this not a serial/tty driver?
Ah, it's a serdev driver. that wasn't obvious.
Please write a much better changelog saying what this driver is and why
it needs to be the type that it is, as I totally missed that from these
2 sentences.
thanks,
greg k-h
prev parent reply other threads:[~2020-07-16 6:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 5:14 [PATCH v3 1/2] platform/chrome: cros_ec_uart: Add cros-ec-uart transport layer Bhanu Prakash Maiya
2020-07-16 6:28 ` Greg Kroah-Hartman
2020-07-16 6:29 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716062936.GB958325@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bhanumaiya@chromium.org \
--cc=bleung@chromium.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dlaurie@google.com \
--cc=enric.balletbo@collabora.com \
--cc=epeers@google.com \
--cc=furquan@chromium.org \
--cc=groeck@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=robh@kernel.org \
--cc=rrangel@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox