* [PATCH v2 0/3] dt-bindings: adv7604: Convert bindings to json-schema
@ 2020-07-15 9:14 Niklas Söderlund
2020-07-15 9:14 ` [PATCH v2 1/3] dt-bindings: adv7604: Fix documentation for hpd-gpios Niklas Söderlund
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Niklas Söderlund @ 2020-07-15 9:14 UTC (permalink / raw)
To: Hans Verkuil, Rob Herring
Cc: devicetree, linux-renesas-soc, Niklas Söderlund
Hi Hans,
This series converts the ADV7604 bindings to YAML and lists the new file
under MAINTAINERS. I have used the schema to validate the usage of the
bindings and only found one issue that is fixed in [1].
1. [PATCH] ARM: dts: gose: Fix ports node name for adv7612
Niklas Söderlund (3):
dt-bindings: adv7604: Fix documentation for hpd-gpios
dt-bindings: adv7604: Convert bindings to json-schema
MAINTAINERS: Add ADV7604 bindings documentation
.../devicetree/bindings/media/i2c/adv7604.txt | 88 ----------
.../bindings/media/i2c/adv7604.yaml | 161 ++++++++++++++++++
MAINTAINERS | 1 +
3 files changed, 162 insertions(+), 88 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/i2c/adv7604.txt
create mode 100644 Documentation/devicetree/bindings/media/i2c/adv7604.yaml
--
2.27.0
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2 1/3] dt-bindings: adv7604: Fix documentation for hpd-gpios 2020-07-15 9:14 [PATCH v2 0/3] dt-bindings: adv7604: Convert bindings to json-schema Niklas Söderlund @ 2020-07-15 9:14 ` Niklas Söderlund 2020-07-15 9:14 ` [PATCH v2 2/3] dt-bindings: adv7604: Convert bindings to json-schema Niklas Söderlund 2020-07-15 9:14 ` [PATCH v2 3/3] MAINTAINERS: Add ADV7604 bindings documentation Niklas Söderlund 2 siblings, 0 replies; 5+ messages in thread From: Niklas Söderlund @ 2020-07-15 9:14 UTC (permalink / raw) To: Hans Verkuil, Rob Herring Cc: devicetree, linux-renesas-soc, Niklas Söderlund, Rob Herring As of [1] the hpd-gpios property is optional, document it as such. 1. commit 269bd1324fbfaa52 ("[media] media: adv7604: improve usage of gpiod API") Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by: Rob Herring <robh@kernel.org> --- Documentation/devicetree/bindings/media/i2c/adv7604.txt | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/media/i2c/adv7604.txt b/Documentation/devicetree/bindings/media/i2c/adv7604.txt index b3e688b77a38cb6d..8c7cdc7cd7aaebc8 100644 --- a/Documentation/devicetree/bindings/media/i2c/adv7604.txt +++ b/Documentation/devicetree/bindings/media/i2c/adv7604.txt @@ -19,10 +19,6 @@ Required Properties: slave device on the I2C bus. The main address is mandatory, others are optional and revert to defaults if not specified. - - hpd-gpios: References to the GPIOs that control the HDMI hot-plug - detection pins, one per HDMI input. The active flag indicates the GPIO - level that enables hot-plug detection. - The device node must contain one 'port' child node per device input and output port, in accordance with the video interface bindings defined in Documentation/devicetree/bindings/media/video-interfaces.txt. The port nodes @@ -37,6 +33,9 @@ The digital output port node must contain at least one endpoint. Optional Properties: + - hpd-gpios: References to the GPIOs that control the HDMI hot-plug + detection pins, one per HDMI input. The active flag indicates the GPIO + level that enables hot-plug detection. - reset-gpios: Reference to the GPIO connected to the device's reset pin. - default-input: Select which input is selected after reset. - reg-names : Names of maps with programmable addresses. -- 2.27.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/3] dt-bindings: adv7604: Convert bindings to json-schema 2020-07-15 9:14 [PATCH v2 0/3] dt-bindings: adv7604: Convert bindings to json-schema Niklas Söderlund 2020-07-15 9:14 ` [PATCH v2 1/3] dt-bindings: adv7604: Fix documentation for hpd-gpios Niklas Söderlund @ 2020-07-15 9:14 ` Niklas Söderlund 2020-07-16 15:25 ` Rob Herring 2020-07-15 9:14 ` [PATCH v2 3/3] MAINTAINERS: Add ADV7604 bindings documentation Niklas Söderlund 2 siblings, 1 reply; 5+ messages in thread From: Niklas Söderlund @ 2020-07-15 9:14 UTC (permalink / raw) To: Hans Verkuil, Rob Herring Cc: devicetree, linux-renesas-soc, Niklas Söderlund Convert ADV7604 video decoder documentation to json-schema. Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> --- * Changes since v1 - Simplify enum for reg-names. --- .../devicetree/bindings/media/i2c/adv7604.txt | 87 ---------- .../bindings/media/i2c/adv7604.yaml | 161 ++++++++++++++++++ 2 files changed, 161 insertions(+), 87 deletions(-) delete mode 100644 Documentation/devicetree/bindings/media/i2c/adv7604.txt create mode 100644 Documentation/devicetree/bindings/media/i2c/adv7604.yaml diff --git a/Documentation/devicetree/bindings/media/i2c/adv7604.txt b/Documentation/devicetree/bindings/media/i2c/adv7604.txt deleted file mode 100644 index 8c7cdc7cd7aaebc8..0000000000000000 --- a/Documentation/devicetree/bindings/media/i2c/adv7604.txt +++ /dev/null @@ -1,87 +0,0 @@ -* Analog Devices ADV7604/11/12 video decoder with HDMI receiver - -The ADV7604 and ADV7611/12 are multiformat video decoders with an integrated -HDMI receiver. The ADV7604 has four multiplexed HDMI inputs and one analog -input, and the ADV7611 has one HDMI input and no analog input. The 7612 is -similar to the 7611 but has 2 HDMI inputs. - -These device tree bindings support the ADV7611/12 only at the moment. - -Required Properties: - - - compatible: Must contain one of the following - - "adi,adv7611" for the ADV7611 - - "adi,adv7612" for the ADV7612 - - - reg: I2C slave addresses - The ADV76xx has up to thirteen 256-byte maps that can be accessed via the - main I2C ports. Each map has it own I2C address and acts as a standard - slave device on the I2C bus. The main address is mandatory, others are - optional and revert to defaults if not specified. - -The device node must contain one 'port' child node per device input and output -port, in accordance with the video interface bindings defined in -Documentation/devicetree/bindings/media/video-interfaces.txt. The port nodes -are numbered as follows. - - Port ADV7611 ADV7612 ------------------------------------------------------------- - HDMI 0 0, 1 - Digital output 1 2 - -The digital output port node must contain at least one endpoint. - -Optional Properties: - - - hpd-gpios: References to the GPIOs that control the HDMI hot-plug - detection pins, one per HDMI input. The active flag indicates the GPIO - level that enables hot-plug detection. - - reset-gpios: Reference to the GPIO connected to the device's reset pin. - - default-input: Select which input is selected after reset. - - reg-names : Names of maps with programmable addresses. - It can contain any map needing a non-default address. - Possible maps names are : - "main", "avlink", "cec", "infoframe", "esdp", "dpp", "afe", - "rep", "edid", "hdmi", "test", "cp", "vdp" - -Optional Endpoint Properties: - - The following three properties are defined in video-interfaces.txt and are - valid for source endpoints only. - - - hsync-active: Horizontal synchronization polarity. Defaults to active low. - - vsync-active: Vertical synchronization polarity. Defaults to active low. - - pclk-sample: Pixel clock polarity. Defaults to output on the falling edge. - - If none of hsync-active, vsync-active and pclk-sample is specified the - endpoint will use embedded BT.656 synchronization. - -Example: - - hdmi_receiver@4c { - compatible = "adi,adv7611"; - /* - * The edid page will be accessible @ 0x66 on the I2C bus. All - * other maps will retain their default addresses. - */ - reg = <0x4c>, <0x66>; - reg-names = "main", "edid"; - - reset-gpios = <&ioexp 0 GPIO_ACTIVE_LOW>; - hpd-gpios = <&ioexp 2 GPIO_ACTIVE_HIGH>; - - #address-cells = <1>; - #size-cells = <0>; - - default-input = <0>; - - port@0 { - reg = <0>; - }; - port@1 { - reg = <1>; - hdmi_in: endpoint { - remote-endpoint = <&ccdc_in>; - }; - }; - }; diff --git a/Documentation/devicetree/bindings/media/i2c/adv7604.yaml b/Documentation/devicetree/bindings/media/i2c/adv7604.yaml new file mode 100644 index 0000000000000000..b585745b66d70ac9 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/adv7604.yaml @@ -0,0 +1,161 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/adv7604.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices ADV7604/11/12 video decoder with HDMI receiver + +maintainers: + - Hans Verkuil <hverkuil-cisco@xs4all.nl> + +description: + The ADV7604 and ADV7611/12 are multiformat video decoders with an integrated + HDMI receiver. The ADV7604 has four multiplexed HDMI inputs and one analog + input, and the ADV7611 has one HDMI input and no analog input. The 7612 is + similar to the 7611 but has 2 HDMI inputs. + + These device tree bindings support the ADV7611/12 only at the moment. + +properties: + compatible: + items: + - enum: + - adi,adv7611 + - adi,adv7612 + + reg: + minItems: 1 + maxItems: 13 + + reg-names: + minItems: 1 + maxItems: 13 + items: + enum: [ main, avlink, cec, infoframe, esdp, dpp, afe, rep, edid, hdmi, test, cp, vdp ] + + reset-gpios: + maxItems: 1 + + hpd-gpios: + minItems: 1 + description: + References to the GPIOs that control the HDMI hot-plug detection pins, + one per HDMI input. The active flag indicates the GPIO level that + enables hot-plug detection. + + default-input: + maxItems: 1 + description: + Select which input is selected after reset. + + ports: + type: object + description: + A node containing input and output port nodes with endpoint definitions + as documented in + Documentation/devicetree/bindings/media/video-interfaces.txt + +required: + - compatible + - reg + +allOf: + - if: + properties: + compatible: + contains: + const: adi,adv7611 + then: + properties: + ports: + properties: + '#address-cells': + const: 1 + '#size-cells': + const: 0 + port@0: + type: object + description: Input port + port@1: + type: object + description: Output port + + required: + - port@1 + + additionalProperties: false + + required: + - ports + + - if: + properties: + compatible: + contains: + const: adi,adv7612 + then: + properties: + ports: + properties: + '#address-cells': + const: 1 + '#size-cells': + const: 0 + port@2: + type: object + description: Output port + + patternProperties: + "^port@[0-1]$": + type: object + description: Input port + + required: + - port@2 + + additionalProperties: false + + required: + - ports + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + hdmi_receiver@4c { + compatible = "adi,adv7611"; + /* + * The edid page will be accessible @ 0x66 on the I2C bus. All + * other maps will retain their default addresses. + */ + reg = <0x4c>, <0x66>; + reg-names = "main", "edid"; + + reset-gpios = <&ioexp 0 GPIO_ACTIVE_LOW>; + hpd-gpios = <&ioexp 2 GPIO_ACTIVE_HIGH>; + default-input = <0>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + }; + + port@1 { + reg = <1>; + hdmi_in: endpoint { + remote-endpoint = <&ccdc_in>; + }; + }; + }; + + + }; + }; -- 2.27.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: adv7604: Convert bindings to json-schema 2020-07-15 9:14 ` [PATCH v2 2/3] dt-bindings: adv7604: Convert bindings to json-schema Niklas Söderlund @ 2020-07-16 15:25 ` Rob Herring 0 siblings, 0 replies; 5+ messages in thread From: Rob Herring @ 2020-07-16 15:25 UTC (permalink / raw) To: Niklas Söderlund; +Cc: Hans Verkuil, devicetree, linux-renesas-soc On Wed, Jul 15, 2020 at 11:14:54AM +0200, Niklas Söderlund wrote: > Convert ADV7604 video decoder documentation to json-schema. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > * Changes since v1 > - Simplify enum for reg-names. > --- > .../devicetree/bindings/media/i2c/adv7604.txt | 87 ---------- > .../bindings/media/i2c/adv7604.yaml | 161 ++++++++++++++++++ > 2 files changed, 161 insertions(+), 87 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/media/i2c/adv7604.txt > create mode 100644 Documentation/devicetree/bindings/media/i2c/adv7604.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/adv7604.txt b/Documentation/devicetree/bindings/media/i2c/adv7604.txt > deleted file mode 100644 > index 8c7cdc7cd7aaebc8..0000000000000000 > --- a/Documentation/devicetree/bindings/media/i2c/adv7604.txt > +++ /dev/null > @@ -1,87 +0,0 @@ > -* Analog Devices ADV7604/11/12 video decoder with HDMI receiver > - > -The ADV7604 and ADV7611/12 are multiformat video decoders with an integrated > -HDMI receiver. The ADV7604 has four multiplexed HDMI inputs and one analog > -input, and the ADV7611 has one HDMI input and no analog input. The 7612 is > -similar to the 7611 but has 2 HDMI inputs. > - > -These device tree bindings support the ADV7611/12 only at the moment. > - > -Required Properties: > - > - - compatible: Must contain one of the following > - - "adi,adv7611" for the ADV7611 > - - "adi,adv7612" for the ADV7612 > - > - - reg: I2C slave addresses > - The ADV76xx has up to thirteen 256-byte maps that can be accessed via the > - main I2C ports. Each map has it own I2C address and acts as a standard > - slave device on the I2C bus. The main address is mandatory, others are > - optional and revert to defaults if not specified. You've lost this detail which either as a schema or freeform text seems important.. > - > -The device node must contain one 'port' child node per device input and output > -port, in accordance with the video interface bindings defined in > -Documentation/devicetree/bindings/media/video-interfaces.txt. The port nodes > -are numbered as follows. > - > - Port ADV7611 ADV7612 > ------------------------------------------------------------- > - HDMI 0 0, 1 > - Digital output 1 2 > - > -The digital output port node must contain at least one endpoint. > - > -Optional Properties: > - > - - hpd-gpios: References to the GPIOs that control the HDMI hot-plug > - detection pins, one per HDMI input. The active flag indicates the GPIO > - level that enables hot-plug detection. > - - reset-gpios: Reference to the GPIO connected to the device's reset pin. > - - default-input: Select which input is selected after reset. > - - reg-names : Names of maps with programmable addresses. > - It can contain any map needing a non-default address. > - Possible maps names are : > - "main", "avlink", "cec", "infoframe", "esdp", "dpp", "afe", > - "rep", "edid", "hdmi", "test", "cp", "vdp" > - > -Optional Endpoint Properties: > - > - The following three properties are defined in video-interfaces.txt and are > - valid for source endpoints only. > - > - - hsync-active: Horizontal synchronization polarity. Defaults to active low. > - - vsync-active: Vertical synchronization polarity. Defaults to active low. > - - pclk-sample: Pixel clock polarity. Defaults to output on the falling edge. > - > - If none of hsync-active, vsync-active and pclk-sample is specified the > - endpoint will use embedded BT.656 synchronization. > - > -Example: > - > - hdmi_receiver@4c { > - compatible = "adi,adv7611"; > - /* > - * The edid page will be accessible @ 0x66 on the I2C bus. All > - * other maps will retain their default addresses. > - */ > - reg = <0x4c>, <0x66>; > - reg-names = "main", "edid"; > - > - reset-gpios = <&ioexp 0 GPIO_ACTIVE_LOW>; > - hpd-gpios = <&ioexp 2 GPIO_ACTIVE_HIGH>; > - > - #address-cells = <1>; > - #size-cells = <0>; > - > - default-input = <0>; > - > - port@0 { > - reg = <0>; > - }; > - port@1 { > - reg = <1>; > - hdmi_in: endpoint { > - remote-endpoint = <&ccdc_in>; > - }; > - }; > - }; > diff --git a/Documentation/devicetree/bindings/media/i2c/adv7604.yaml b/Documentation/devicetree/bindings/media/i2c/adv7604.yaml > new file mode 100644 > index 0000000000000000..b585745b66d70ac9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/adv7604.yaml > @@ -0,0 +1,161 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/adv7604.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices ADV7604/11/12 video decoder with HDMI receiver > + > +maintainers: > + - Hans Verkuil <hverkuil-cisco@xs4all.nl> > + > +description: > + The ADV7604 and ADV7611/12 are multiformat video decoders with an integrated > + HDMI receiver. The ADV7604 has four multiplexed HDMI inputs and one analog > + input, and the ADV7611 has one HDMI input and no analog input. The 7612 is > + similar to the 7611 but has 2 HDMI inputs. > + > + These device tree bindings support the ADV7611/12 only at the moment. > + > +properties: > + compatible: > + items: > + - enum: > + - adi,adv7611 > + - adi,adv7612 > + > + reg: > + minItems: 1 > + maxItems: 13 > + > + reg-names: > + minItems: 1 > + maxItems: 13 > + items: > + enum: [ main, avlink, cec, infoframe, esdp, dpp, afe, rep, edid, hdmi, test, cp, vdp ] > + > + reset-gpios: > + maxItems: 1 > + > + hpd-gpios: > + minItems: 1 > + description: > + References to the GPIOs that control the HDMI hot-plug detection pins, > + one per HDMI input. The active flag indicates the GPIO level that > + enables hot-plug detection. > + > + default-input: > + maxItems: 1 > + description: > + Select which input is selected after reset. > + > + ports: > + type: object > + description: > + A node containing input and output port nodes with endpoint definitions > + as documented in > + Documentation/devicetree/bindings/media/video-interfaces.txt > + > +required: > + - compatible > + - reg Add: additionalProperties: false > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: adi,adv7611 > + then: > + properties: > + ports: > + properties: > + '#address-cells': > + const: 1 > + '#size-cells': > + const: 0 > + port@0: > + type: object > + description: Input port > + port@1: > + type: object > + description: Output port > + > + required: > + - port@1 > + > + additionalProperties: false > + > + required: > + - ports > + > + - if: > + properties: > + compatible: > + contains: > + const: adi,adv7612 > + then: > + properties: > + ports: > + properties: > + '#address-cells': > + const: 1 > + '#size-cells': > + const: 0 > + port@2: > + type: object > + description: Output port > + > + patternProperties: > + "^port@[0-1]$": > + type: object > + description: Input port > + > + required: > + - port@2 > + > + additionalProperties: false > + > + required: > + - ports > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + hdmi_receiver@4c { > + compatible = "adi,adv7611"; > + /* > + * The edid page will be accessible @ 0x66 on the I2C bus. All > + * other maps will retain their default addresses. > + */ > + reg = <0x4c>, <0x66>; > + reg-names = "main", "edid"; > + > + reset-gpios = <&ioexp 0 GPIO_ACTIVE_LOW>; > + hpd-gpios = <&ioexp 2 GPIO_ACTIVE_HIGH>; > + default-input = <0>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + }; > + > + port@1 { > + reg = <1>; > + hdmi_in: endpoint { > + remote-endpoint = <&ccdc_in>; > + }; > + }; > + }; > + > + > + }; > + }; > -- > 2.27.0 > ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 3/3] MAINTAINERS: Add ADV7604 bindings documentation 2020-07-15 9:14 [PATCH v2 0/3] dt-bindings: adv7604: Convert bindings to json-schema Niklas Söderlund 2020-07-15 9:14 ` [PATCH v2 1/3] dt-bindings: adv7604: Fix documentation for hpd-gpios Niklas Söderlund 2020-07-15 9:14 ` [PATCH v2 2/3] dt-bindings: adv7604: Convert bindings to json-schema Niklas Söderlund @ 2020-07-15 9:14 ` Niklas Söderlund 2 siblings, 0 replies; 5+ messages in thread From: Niklas Söderlund @ 2020-07-15 9:14 UTC (permalink / raw) To: Hans Verkuil, Rob Herring Cc: devicetree, linux-renesas-soc, Niklas Söderlund Add the YAML dt-bindings document for ADV7604. Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 496fd4eafb68cccc..b00210a1f6c8da0c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1091,6 +1091,7 @@ M: Hans Verkuil <hverkuil-cisco@xs4all.nl> L: linux-media@vger.kernel.org S: Maintained F: drivers/media/i2c/adv7604* +F: Documentation/devicetree/bindings/media/i2c/adv7604.yaml ANALOG DEVICES INC ADV7842 DRIVER M: Hans Verkuil <hverkuil-cisco@xs4all.nl> -- 2.27.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-07-16 15:25 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-07-15 9:14 [PATCH v2 0/3] dt-bindings: adv7604: Convert bindings to json-schema Niklas Söderlund 2020-07-15 9:14 ` [PATCH v2 1/3] dt-bindings: adv7604: Fix documentation for hpd-gpios Niklas Söderlund 2020-07-15 9:14 ` [PATCH v2 2/3] dt-bindings: adv7604: Convert bindings to json-schema Niklas Söderlund 2020-07-16 15:25 ` Rob Herring 2020-07-15 9:14 ` [PATCH v2 3/3] MAINTAINERS: Add ADV7604 bindings documentation Niklas Söderlund
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).