From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6EFBC43459 for ; Thu, 16 Jul 2020 23:09:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A9482137B for ; Thu, 16 Jul 2020 23:09:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594940982; bh=oZQUIN0T3e/W14X1ipGHgVlqksyFRf0ot5zg7bunJLM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=i8F2k+ueBS6wN709Px9VHG9YF9P5lZ6un5zixcFL8S6fa+qUXl3nipMe0XBSpM07r BjYtLcGjM8PE7wvwh5smfhJ8Kbfz3jv+ylzWe0u723LC+GYJrrPirJGDP3l8oEFOzF kCuY7nvS27lr/nbwy5m+p2IwPZ5PjJXrtzTgM/Hs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728085AbgGPXJg (ORCPT ); Thu, 16 Jul 2020 19:09:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728028AbgGPXJW (ORCPT ); Thu, 16 Jul 2020 19:09:22 -0400 Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB68EC08C5FD; Thu, 16 Jul 2020 16:04:54 -0700 (PDT) Received: by mail-io1-xd44.google.com with SMTP id k23so8069059iom.10; Thu, 16 Jul 2020 16:04:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eDT8ZBhNeJbznzfPJdQt1GGooj/iP+F7BcxCoXIsS98=; b=ZO/ZUOOKENY4J7SKNW83pfoweXvjpCYUuMVcEOOM8350v42vBjpuim6/Z5Grl3HWrl LQ/0XYZ9uSE8b8c1HOjVYq/AaFSu0bd5J28AfyLx/sEs2AygquWIXma6os8cTsLUsYHN iEP6IfnxgTouvXt3p8JcIaQEFpXmdj00qamIY2IYAmcf3aoDh2EPWjMG+aJDy4VkQjUl i4hAtJVulCm9a2vW++ZItkCB1T+El/LMxpgbX5rv3fQulQQFP5Ha79+Ubamb1hWACczk /1T4YfE8r6gcfpWEcC43LNk/+siPwOrtZGoEb1wIjEAGtKI5WBKDO1eTzEgI1VyZ4fx/ OjYg== X-Gm-Message-State: AOAM530ClT62bp3RYyXQZGgW/EFfChGQDRjhvabAr2O5Dd+IDIxeXK20 po6Le+9qMXA681wW6IzjNw== X-Google-Smtp-Source: ABdhPJxtvwZsJGPyF4/aHmjE6iE0550P7hSG08wHNUdd2IYc9L30ABvSfVU3gTVaBW7qJaETeEmXVA== X-Received: by 2002:a05:6638:223:: with SMTP id f3mr7706474jaq.144.1594940693894; Thu, 16 Jul 2020 16:04:53 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id q2sm3358270ilp.82.2020.07.16.16.04.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 16:04:53 -0700 (PDT) Received: (nullmailer pid 3053333 invoked by uid 1000); Thu, 16 Jul 2020 23:04:51 -0000 Date: Thu, 16 Jul 2020 17:04:51 -0600 From: Rob Herring To: Masahiro Yamada Cc: Frank Rowand , devicetree@vger.kernel.org, Amit Kucheria , Daniel Lezcano , Kunihiko Hayashi , Zhang Rui , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH] dt-bindings: uniphier-thermal: add minItems to socionext,tmod-calibration Message-ID: <20200716230451.GA3041278@bogus> References: <20200707102338.989660-1-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200707102338.989660-1-yamada.masahiro@socionext.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Jul 07, 2020 at 07:23:38PM +0900, Masahiro Yamada wrote: > As the description says, this property contains a pair of calibration > values. The number of items must be exactly 2. > > Add minItems to check a too short property. > > While I was here, I also added this property to the example because > this is the case in the real DT file, > arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi > > Also, fix the interrupt type (edge -> level) to align with the > real DT. > > Signed-off-by: Masahiro Yamada > --- > > .../bindings/thermal/socionext,uniphier-thermal.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml > index 553c9dcdaeeb..57ffd0c4c474 100644 > --- a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml > +++ b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml > @@ -29,6 +29,7 @@ properties: > > socionext,tmod-calibration: > $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 2 The intent was if minItems is not defined, then the default is the same as maxItems. This is not the default for json-schema, so the tooling is supposed to add it. But looking at processed-schema.yaml, it doesn't seem to be happening for one case here. I'm working on a fix in the tools. Rob