From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56DB4C433E2 for ; Thu, 16 Jul 2020 23:45:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 333B4204EC for ; Thu, 16 Jul 2020 23:45:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="a5rn2ThY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726530AbgGPXpR (ORCPT ); Thu, 16 Jul 2020 19:45:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726234AbgGPXpN (ORCPT ); Thu, 16 Jul 2020 19:45:13 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1CCEC08C5DB for ; Thu, 16 Jul 2020 16:45:13 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id u185so4479750pfu.1 for ; Thu, 16 Jul 2020 16:45:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7HMps4EVe5QouaH170Ni6vFF1hKv4OVRQ58+hvK869s=; b=a5rn2ThYvk32OHonppZRgr0gWChDuOIPVBbDLQ1uQhEBEWduMAs8sxC7Wtn5610Kwf BciU3PiM4HVbTqEi+YdL05OTqTb7BhYaltbnoIY1SK98AUoRxrJlxTW7LgrHy8yaaFzg wHc8SukhPm1z3uRr1c6PYMn6oqqCyyOOZztVtJfyLTr/Rw9rWqSwpZ1q30JamSf1DvS4 cK+9L1/ntRGxVe4zJRnol1izTRhavFA1NySWDPzwZ39usxUlrRmIR0YXRyolCBGhoqhD myQZ6X+dn2KLMSc73YoDPqwaaCFslzde3FXdY5+5qBfVbX8WlFGpZY3zk9f4aIRfvls5 3E3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7HMps4EVe5QouaH170Ni6vFF1hKv4OVRQ58+hvK869s=; b=Dt7tWN5F3ODCYm5Ofbk92q8KQoczSzOJDezBj3SUaLnS18s8shpnocTdveKZfi1NMa oVtT4SL9WLUOiftCZ9i1Ru5h8Wt2ZeigDHGGdaDDaWxzjjBFeLOLIf+31xaV4Zy94JmA z90kVNAUizzARaBlgia9TtpSs9Pz3/WzdLaM6liH+AQM5yy5ZhMAr28ltMIwHE3F936M 758K0+NGk/vrp7PZGCVCNvbeYyEC+6N1tv8i8Op+PS/jpQc2poXIFzEAwIUsolLog/wt I3mS+J3JOOM8eqhi5rI1tFPAgbej8W6lcR8EsNi4ZJFhkRW041+ZOQF0hS/6UkGUzyIN gqdg== X-Gm-Message-State: AOAM530+4pY72k20ihNUpg9GvDvQbgZ9oonoPbT3GApSdB8pPFSWl39A qBlOEVrWOYBVNVzOuosk0LrKpg== X-Google-Smtp-Source: ABdhPJwmfESAulSis3weUqV/31ICtbnWJSbR9MqBo6uiZUCmpXjfWM5F052GbpZ/gabM+1BDHHe16A== X-Received: by 2002:a65:4786:: with SMTP id e6mr6275744pgs.258.1594943113069; Thu, 16 Jul 2020 16:45:13 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id o8sm5752304pgb.23.2020.07.16.16.45.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 16:45:12 -0700 (PDT) Date: Thu, 16 Jul 2020 16:43:10 -0700 From: Bjorn Andersson To: Rajendra Nayak Cc: stanimir.varbanov@linaro.org, robh+dt@kernel.org, agross@kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mka@chromium.org Subject: Re: [PATCH v2 1/4] dt-bindings: media: venus: Add an optional power domain for perf voting Message-ID: <20200716234310.GH1218486@builder.lan> References: <1594878139-3402-1-git-send-email-rnayak@codeaurora.org> <1594878139-3402-2-git-send-email-rnayak@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1594878139-3402-2-git-send-email-rnayak@codeaurora.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed 15 Jul 22:42 PDT 2020, Rajendra Nayak wrote: > Add an optional power domain which when specified can be used for > setting the performance state of Venus. > > Signed-off-by: Rajendra Nayak > --- > This is a resend of https://lore.kernel.org/patchwork/patch/1241077/ > > Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml | 6 +++++- > Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 6 +++++- > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml > index 55f2d67..1e8675b 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml > @@ -25,12 +25,16 @@ properties: > maxItems: 1 > > power-domains: > - maxItems: 2 > + minItems: 2 > + maxItems: 3 > > power-domain-names: > + minItems: 2 > + maxItems: 3 > items: > - const: venus > - const: vcodec0 > + - const: opp-pd In line with Rob's question, the "opp power-domain" seems like a software construct, wouldn't this be better named e.g. "cx"? Regards, Bjorn > > clocks: > maxItems: 5 > diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml > index 157dff8..437286d 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml > @@ -25,13 +25,17 @@ properties: > maxItems: 1 > > power-domains: > - maxItems: 3 > + minItems: 3 > + maxItems: 4 > > power-domain-names: > + minItems: 3 > + maxItems: 4 > items: > - const: venus > - const: vcodec0 > - const: vcodec1 > + - const: opp-pd > > clocks: > maxItems: 7 > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation >