devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Chen <peter.chen@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: Philippe Schenker <philippe.schenker@toradex.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: usb: ci-hdrc-usb2: add property disable-runtime-pm
Date: Fri, 17 Jul 2020 02:31:09 +0000	[thread overview]
Message-ID: <20200717023108.GA17070@b29397-desktop> (raw)
In-Reply-To: <20200716192452.GA2699629@bogus>

On 20-07-16 13:24:52, Rob Herring wrote:
> On Tue, Jul 14, 2020 at 05:18:20PM +0200, Philippe Schenker wrote:
> > Chipidea depends on some hardware signals to be there in order
> > for runtime-pm to work well. Add the possibility to disable runtime
> > power management that is necessary for certain boards.
> 
> This is why we have SoC specific compatible strings. Use that.

It is a board design limitation, not SoC's. To support USB low power
mode for device mode, either VBUS connects to SoC, or VBUS connect to
GPIO, or VBUS connect to Type-C IC, but none of the design is used
at that board. So the USB can't enter low power mode for that board,
otherwise, the USB controller can't be woken up since no any interrupts
will occur if USB cable (host at other side) connects to the connector.

Peter
> 
> > 
> > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> > ---
> > 
> > Changes in v2: None
> > 
> >  Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> > index 51376cbe5f3d..67a31df13e69 100644
> > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> > @@ -90,6 +90,7 @@ Optional properties:
> >    case, the "idle" state needs to pull down the data and strobe pin
> >    and the "active" state needs to pull up the strobe pin.
> >  - pinctrl-n: alternate pin modes
> > +- disable-runtime-pm: This disables the runtime power management.
> 
> This is a Linux feature, not h/w description or config.
> 
> >  
> >  i.mx specific properties
> >  - fsl,usbmisc: phandler of non-core register device, with one
> > -- 
> > 2.27.0
> > 

-- 

Thanks,
Peter Chen

  reply	other threads:[~2020-07-17  2:31 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14 15:18 [PATCH v2 1/3] dt-bindings: usb: ci-hdrc-usb2: add property disable-runtime-pm Philippe Schenker
2020-07-14 15:18 ` [PATCH v2 2/3] usb: chipidea: imx: support disabling runtime-pm Philippe Schenker
2020-07-15  0:51   ` Peter Chen
2020-07-15 10:23     ` Philippe Schenker
2020-07-20  3:44       ` Peter Chen
2020-07-20  7:51         ` Philippe Schenker
2020-07-20  8:06           ` Peter Chen
2020-07-20 10:10             ` Philippe Schenker
2023-05-04 16:23               ` Luca Ceresoli
2023-05-04 16:50                 ` Francesco Dolcini
2023-05-05  9:23                   ` Luca Ceresoli
2023-05-05 10:58                     ` Francesco Dolcini
2023-05-05  9:49                   ` Jun Li
2023-05-05 10:06                     ` Luca Ceresoli
2023-05-05 11:00                       ` Francesco Dolcini
2023-05-06  9:02                         ` Jun Li
2023-05-08 11:17                           ` Francesco Dolcini
2023-05-08 11:53                             ` Jun Li
2023-05-08 14:35                               ` Francesco Dolcini
2023-05-08 13:17                             ` Luca Ceresoli
2023-05-29 10:18                               ` Luca Ceresoli
2023-05-30 11:22                                 ` Jun Li
2023-07-06 10:23                                   ` Francesco Dolcini
2023-07-17 16:45                                     ` Luca Ceresoli
2023-07-18  8:14                                       ` Francesco Dolcini
2023-07-18  8:31                                       ` [EXT] " Xu Yang
2023-07-18 12:25                                         ` Luca Ceresoli
2023-07-19 11:23                                           ` Xu Yang
2023-07-19 16:48                                             ` Luca Ceresoli
2023-07-20 10:13                                               ` Xu Yang
2023-07-20 12:49                                                 ` Luca Ceresoli
2023-07-21  2:06                                                   ` Xu Yang
     [not found]                                                     ` <20230721232750.0aea6e0f@booty>
     [not found]                                                       ` <DB7PR04MB450517AD9F25F47320835A5B8C03A@DB7PR04MB4505.eurprd04.prod.outlook.com>
2023-09-29 13:37                                                         ` Luca Ceresoli
2023-10-10 10:52                                                           ` Xu Yang
2020-07-14 15:18 ` [PATCH v2 3/3] ARM: dts: colibri-imx6ull: disable runtime pm Philippe Schenker
2020-07-16 19:24 ` [PATCH v2 1/3] dt-bindings: usb: ci-hdrc-usb2: add property disable-runtime-pm Rob Herring
2020-07-17  2:31   ` Peter Chen [this message]
2020-07-17 14:14     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200717023108.GA17070@b29397-desktop \
    --to=peter.chen@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=philippe.schenker@toradex.com \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).