From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE002C433E1 for ; Sat, 18 Jul 2020 07:07:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8724C2076D for ; Sat, 18 Jul 2020 07:07:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zOrVrQ8v" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728951AbgGRHHq (ORCPT ); Sat, 18 Jul 2020 03:07:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725920AbgGRHHp (ORCPT ); Sat, 18 Jul 2020 03:07:45 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7469FC0619D2 for ; Sat, 18 Jul 2020 00:07:45 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id s26so6437451pfm.4 for ; Sat, 18 Jul 2020 00:07:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FvB+EstirEoaTYLy3FAmpSy2vtZp1fbnxBznhXtHkyU=; b=zOrVrQ8vs9K/U2uxQicdd0HuHtzFZWRl13/zXu2H/VSzWMsxphMZUUccwK34jqeiRr KYSzLmJrqdrS1FHjnsQxrBD5jirXXrbWPj8UksDOnkWSD9lGGhcFULfAvndSAaH7vbrz di3kEoRa+6Nt83wAeKHtAxGjWguI+iTDqOswGzEDwQ1HwjmRXOMG6tLFULIiSFfQBztv bAVQNa8r7K1RiTJ/0He0A1X5MTFZ9NZo4mfRLsI/3T4z3g3mM6lT2jXLRaL/SFC+mr6C nQP3VAn06OoxobWjoZ0bkub4ez4+feDmW4qpkYZ/BNALw2aDF1EcgC9jV2cbozWHDlBv PMWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FvB+EstirEoaTYLy3FAmpSy2vtZp1fbnxBznhXtHkyU=; b=ZUkZgOiS7bzHFYOQL7dhOzoK96P72RWJFGN7s+BptNRJqa81uaOUJxnDgezfobAWIG z9MFaouBlYrupXk1wO2Zp8rqV2LVrBNQ0cJHX3slGNIdpeJkTqWl6AvbY4Rf2TeJR2Eh 0BsxrRpT/y2wpSbEmkQNPAYPgzoFn3d7dgmiJqwwJTtJWaBQPUgON0UjcIYOFhQcJizI wbR5wHpDZrMhMcHIUU0tmMAwlNtmh2Kh5Ob340fcFRIZAdtRf1r9P3yGF75DSUa3sBu8 +T37gD96UWMn6hFv8Tj85DLvChPqmAQ06sshsbkJDJNWFsuVsUMNl5B1VrqVw6zbGpeE iHLA== X-Gm-Message-State: AOAM532+ekUeUfw2ZUL/0S8Pdj9eLz86ufD8qDiu1TYOgNMV0laHBMCx TR8MMsm4y7sI6E5oxkshe8B6Ng== X-Google-Smtp-Source: ABdhPJxI1f6Tah2zpEfBV0ApJb35RLL0rDSc8ngWpvA54RkvtaT4kEQqaoMfJx9gdGEPqAzFnsReiQ== X-Received: by 2002:a63:be4e:: with SMTP id g14mr11652459pgo.193.1595056064925; Sat, 18 Jul 2020 00:07:44 -0700 (PDT) Received: from yoga (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id r8sm9689269pfh.29.2020.07.18.00.07.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2020 00:07:44 -0700 (PDT) Date: Sat, 18 Jul 2020 00:07:40 -0700 From: Bjorn Andersson To: Shaik Sajida Bhanu Cc: adrian.hunter@intel.com, ulf.hansson@linaro.org, robh+dt@kernel.org, mka@chromium.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, agross@kernel.org, Veerabhadrarao Badiganti Subject: Re: [PATCH V1] arm64: dts: qcom: SD-card GPIO pin set bias-pull up Message-ID: <20200718070740.GB61202@yoga> References: <1595054041-6872-1-git-send-email-sbhanu@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1595054041-6872-1-git-send-email-sbhanu@codeaurora.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri 17 Jul 23:34 PDT 2020, Shaik Sajida Bhanu wrote: > From: Veerabhadrarao Badiganti > > On some sc7180 based platforms where external pull is not present on cd-gpio, > this gpio state is getting read as HIGH when sleep config is applied on it. > This is resulting in SDcard rescan after suspend-resume even though SDcard > is not present. > > Update cd-gpio sleep config with bais-pull to fix this issue. > > Also include xo clock to sdhc clocks list which will be used > in calculating MCLK_FREQ field of DLL_CONFIG2 register. > Please split this in two patches; one fixing the card detect bias and one for adding the xo clock. This needs Veerabhadrarao's signed-off-by as well (followed by yours). Regards, Bjorn > Signed-off-by: Shaik Sajida Bhanu > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index d78a066..8034fcc 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -682,8 +682,9 @@ > interrupt-names = "hc_irq", "pwr_irq"; > > clocks = <&gcc GCC_SDCC1_APPS_CLK>, > - <&gcc GCC_SDCC1_AHB_CLK>; > - clock-names = "core", "iface"; > + <&gcc GCC_SDCC1_AHB_CLK>, > + <&xo_board>; > + clock-names = "core", "iface", "xo"; > interconnects = <&aggre1_noc MASTER_EMMC &mc_virt SLAVE_EBI1>, > <&gem_noc MASTER_APPSS_PROC &config_noc SLAVE_EMMC_CFG>; > interconnect-names = "sdhc-ddr","cpu-sdhc"; > @@ -1819,7 +1820,7 @@ > > pinconf-sd-cd { > pins = "gpio69"; > - bias-disable; > + bias-pull-up; > drive-strength = <2>; > }; > }; > @@ -2481,8 +2482,9 @@ > interrupt-names = "hc_irq", "pwr_irq"; > > clocks = <&gcc GCC_SDCC2_APPS_CLK>, > - <&gcc GCC_SDCC2_AHB_CLK>; > - clock-names = "core", "iface"; > + <&gcc GCC_SDCC2_AHB_CLK>, > + <&xo_board>; > + clock-names = "core", "iface", "xo"; > > interconnects = <&aggre1_noc MASTER_SDCC_2 &mc_virt SLAVE_EBI1>, > <&gem_noc MASTER_APPSS_PROC &config_noc SLAVE_SDCC_2>; > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation >