From: Andrew Lunn <andrew@lunn.ch>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Martin Rowe <martin.p.rowe@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org,
Gregory Clement <gregory.clement@bootlin.com>,
Jakub Kicinski <kuba@kernel.org>,
Jason Cooper <jason@lakedaemon.net>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [PATCH net] arm64: dts: clearfog-gt-8k: fix switch link configuration
Date: Sun, 19 Jul 2020 17:27:23 +0200 [thread overview]
Message-ID: <20200719152723.GG1383417@lunn.ch> (raw)
In-Reply-To: <E1jx73g-0006mp-UI@rmk-PC.armlinux.org.uk>
On Sun, Jul 19, 2020 at 12:00:40PM +0100, Russell King wrote:
> The commit below caused a regression for clearfog-gt-8k, where the link
> between the switch and the host does not come up.
>
> Investigation revealed two issues:
> - MV88E6xxx DSA no longer allows an in-band link to come up as the link
> is programmed to be forced down. Commit "net: dsa: mv88e6xxx: fix
> in-band AN link establishment" addresses this.
>
> - The dts configured dissimilar link modes at each end of the host to
> switch link; the host was configured using a fixed link (so has no
> in-band status) and the switch was configured to expect in-band
> status.
>
> With both issues fixed, the regression is resolved.
>
> Fixes: 34b5e6a33c1a ("net: dsa: mv88e6xxx: Configure MAC when using fixed link")
> Reported-by: Martin Rowe <martin.p.rowe@gmail.com>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2020-07-19 15:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-19 11:00 [PATCH net] arm64: dts: clearfog-gt-8k: fix switch link configuration Russell King
2020-07-19 15:27 ` Andrew Lunn [this message]
2020-07-20 1:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200719152723.GG1383417@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=jason@lakedaemon.net \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=martin.p.rowe@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).