From: Rob Herring <robh@kernel.org>
To: Eddie James <eajames@linux.ibm.com>
Cc: Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, dmurphy@ti.com,
jacek.anaszewski@gmail.com, vishwa@linux.ibm.com
Subject: Re: [PATCH 1/2] dt-bindings: leds: pca955x: Add IBM implementation compatible string
Date: Mon, 20 Jul 2020 16:25:03 -0600 [thread overview]
Message-ID: <20200720222503.GA3058862@bogus> (raw)
In-Reply-To: <ad50a2a7-0b06-420e-baa7-dec2787ab30d@linux.ibm.com>
On Mon, Jul 13, 2020 at 09:28:32AM -0500, Eddie James wrote:
>
> On 7/11/20 8:48 AM, Pavel Machek wrote:
> > Hi!
> >
> > > IBM created an implementation of the PCA9552 on a PIC16F
> > > microcontroller. Document the new compatible string for this device.
> > Is the implementation opensource?
>
>
> Hi, no it is not.
>
>
> >
> > > Signed-off-by: Eddie James <eajames@linux.ibm.com>
> > > +++ b/Documentation/devicetree/bindings/leds/leds-pca955x.txt
> > > @@ -9,6 +9,7 @@ Required properties:
> > > "nxp,pca9550"
> > > "nxp,pca9551"
> > > "nxp,pca9552"
> > > + "nxp,pca9552-ibm"
> > > "nxp,pca9553"
> > Is it good idea to use nxp prefix for something that is
> > software-defined and not built by nxp?
>
>
> Yea I suppose not...
>
> >
> > Would ibm,pca9552 be better, or maybe even sw,pca9552 to indicate that
> > is not real hardware, but software emulation?
>
>
> How about ibm,pca9552-sw? Someone suggested that just adding "sw" could be a
> problem if another company does the same thing but it isn't compatible.
ibm,pca9552 is good.
Rob
next prev parent reply other threads:[~2020-07-20 22:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 20:12 [PATCH 0/2] leds: pca955x: Add IBM software implemenation of the PCA9552 chip Eddie James
2020-07-09 20:12 ` [PATCH 1/2] dt-bindings: leds: pca955x: Add IBM implementation compatible string Eddie James
2020-07-11 13:48 ` Pavel Machek
2020-07-13 14:28 ` Eddie James
2020-07-20 22:25 ` Rob Herring [this message]
2020-07-09 20:12 ` [PATCH 2/2] leds: pca955x: Add an IBM software implementation of the PCA9552 chip Eddie James
2020-07-09 20:50 ` Andy Shevchenko
2020-07-13 14:29 ` Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720222503.GA3058862@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=eajames@linux.ibm.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=vishwa@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).