From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBF7DC433E3 for ; Mon, 20 Jul 2020 22:27:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB78D20702 for ; Mon, 20 Jul 2020 22:27:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595284052; bh=planpqVcwQaihBx8qpLiBFI3CIQQYNfylFZYUkwwZaI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=MQPyc8CjaR3pur/zi9IDUBeFYlOrqqm98I9ebajE/zCGzEEY4NOs6NRYIAx0xW7I4 VdxC763lncrmFcg0UsqCwwQgKpnuTR3vdrjyjhdvROpj20Zbq5dtsaNc56UBoZ/ntf jyG2YIKmnKxjnkrpvnV22tzebszcbnZdSTt+DocI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726994AbgGTW13 (ORCPT ); Mon, 20 Jul 2020 18:27:29 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:41680 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726021AbgGTW12 (ORCPT ); Mon, 20 Jul 2020 18:27:28 -0400 Received: by mail-io1-f65.google.com with SMTP id p205so19295094iod.8; Mon, 20 Jul 2020 15:27:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dmZWPiwMYUt+IEOD9Wmpq4+HBAIL3pN57wPHpCepilk=; b=NVgjAt10Bh+KGXIpX9dITjy+osGa6XRraIDegnMKhiACafJJDKDj5incm/9RRzqJcb /pf+Zvl133Mt9whgbBQVZKzyCJ9NlU8LrvjSLiTqD2XG0ZyTKBPdkS7oXl6kHJ46eFnQ PGM+6PX/RmUxtnXwD6Cz7pQyquzt54SnJ7GgGsDU/0F6NxnsI2ZGgz4doct9qFVNV6DB 4zxQjgC3gC1SKkYLXiu0+YXFvobC2L7Sm17Spi7c3TCrtqm8SFUck9aFAPPOb68tHxwi vPVpAriaUwq/KCJewWhc0YVC2f+oRdmqvq1XmlIQ0jg3qFqdu5GXP0HIXbZHfEoKVTR2 VdTA== X-Gm-Message-State: AOAM532iegcP7sCMAY/HtiSF0udAiphoI0R27ifhYc+aMh1tboDtkAv3 WEMv7+32cwbKFgMARE62sA== X-Google-Smtp-Source: ABdhPJzT/wiVQZfvilkAhuT/SHp5hylwqI28PubTIp6kEeIwB33d4SeJdoyIdotXOPRW4VF+nUs4vw== X-Received: by 2002:a02:c88c:: with SMTP id m12mr14461904jao.2.1595284047756; Mon, 20 Jul 2020 15:27:27 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id c7sm9727477ilo.85.2020.07.20.15.27.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2020 15:27:26 -0700 (PDT) Received: (nullmailer pid 3063847 invoked by uid 1000); Mon, 20 Jul 2020 22:27:25 -0000 Date: Mon, 20 Jul 2020 16:27:25 -0600 From: Rob Herring To: Guenter Roeck Cc: Chu Lin , belgaied@google.com, jasonling@google.com, jdelvare@suse.com, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, zhongqil@google.com Subject: Re: [PATCH] dt-bindings: hwmon: adm1272: add adm1272-adm1275-temp1-en binding Message-ID: <20200720222725.GA3061855@bogus> References: <20200710004258.296017-1-linchuyuan@google.com> <20200719222222.GA78762@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200719222222.GA78762@roeck-us.net> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, Jul 19, 2020 at 03:22:22PM -0700, Guenter Roeck wrote: > On Fri, Jul 10, 2020 at 12:42:58AM +0000, Chu Lin wrote: > > Problem: > > adm1272 and adm1278 supports temperature sampling. The > > current way of enabling it requires the user manually unbind the device > > from the driver, flip the temperature sampling control bit and then bind > > the device back to the driver. It would be nice if we can control this in a > > better way by reading the dt. > > > > Solution: > > Introducing device tree binding adm1272-adm1278-temp1-en. If the > > flag is set, flip the temp1_en control bit on probing. > > > > Testing: > > make dt_binding_check > > > > Signed-off-by: Chu Lin > > --- > > Documentation/devicetree/bindings/hwmon/adm1275.txt | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/hwmon/adm1275.txt b/Documentation/devicetree/bindings/hwmon/adm1275.txt > > index 1ecd03f3da4d..4403fe30f005 100644 > > --- a/Documentation/devicetree/bindings/hwmon/adm1275.txt > > +++ b/Documentation/devicetree/bindings/hwmon/adm1275.txt > > @@ -15,6 +15,8 @@ Optional properties: > > > > - shunt-resistor-micro-ohms > > Shunt resistor value in micro-Ohm > > +- adm1272-adm1278-temp1-en > > + Enable temperature sampling. This is supported on adm1272 and adm1278 > > I suspect this should be something like "analog,temp1-enable". Yes. > Either case, > I would suggest to resend the series and copy DT maintainers at least on > this patch. Only the DT list matters. Rob